* [PATCH] s390: crypto: Return -EFAULT if copy_to_user() fails
@ 2021-03-01 12:08 Wang Qing
2021-03-01 12:18 ` Tony Krowiak
2021-03-01 13:13 ` Heiko Carstens
0 siblings, 2 replies; 3+ messages in thread
From: Wang Qing @ 2021-03-01 12:08 UTC (permalink / raw)
To: Tony Krowiak, Pierre Morel, Halil Pasic, Harald Freudenberger,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390,
linux-kernel
Cc: Wang Qing
The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return -EFAULT if the copy doesn't complete.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/s390/crypto/vfio_ap_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
index 41fc2e413..1ffdd41
--- a/drivers/s390/crypto/vfio_ap_ops.c
+++ b/drivers/s390/crypto/vfio_ap_ops.c
@@ -1286,7 +1286,7 @@ static int vfio_ap_mdev_get_device_info(unsigned long arg)
info.num_regions = 0;
info.num_irqs = 0;
- return copy_to_user((void __user *)arg, &info, minsz);
+ return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0;
}
static ssize_t vfio_ap_mdev_ioctl(struct mdev_device *mdev,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: crypto: Return -EFAULT if copy_to_user() fails
2021-03-01 12:08 [PATCH] s390: crypto: Return -EFAULT if copy_to_user() fails Wang Qing
@ 2021-03-01 12:18 ` Tony Krowiak
2021-03-01 13:13 ` Heiko Carstens
1 sibling, 0 replies; 3+ messages in thread
From: Tony Krowiak @ 2021-03-01 12:18 UTC (permalink / raw)
To: Wang Qing, Pierre Morel, Halil Pasic, Harald Freudenberger,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390,
linux-kernel
On 3/1/21 7:08 AM, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index 41fc2e413..1ffdd41
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -1286,7 +1286,7 @@ static int vfio_ap_mdev_get_device_info(unsigned long arg)
> info.num_regions = 0;
> info.num_irqs = 0;
>
> - return copy_to_user((void __user *)arg, &info, minsz);
> + return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0;
> }
LGTM
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
>
> static ssize_t vfio_ap_mdev_ioctl(struct mdev_device *mdev,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: crypto: Return -EFAULT if copy_to_user() fails
2021-03-01 12:08 [PATCH] s390: crypto: Return -EFAULT if copy_to_user() fails Wang Qing
2021-03-01 12:18 ` Tony Krowiak
@ 2021-03-01 13:13 ` Heiko Carstens
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2021-03-01 13:13 UTC (permalink / raw)
To: Wang Qing
Cc: Tony Krowiak, Pierre Morel, Halil Pasic, Harald Freudenberger,
Vasily Gorbik, Christian Borntraeger, linux-s390, linux-kernel
On Mon, Mar 01, 2021 at 08:08:21PM +0800, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-01 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 12:08 [PATCH] s390: crypto: Return -EFAULT if copy_to_user() fails Wang Qing
2021-03-01 12:18 ` Tony Krowiak
2021-03-01 13:13 ` Heiko Carstens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.