* [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine
@ 2020-10-01 16:22 Philippe Mathieu-Daudé
2020-10-02 7:44 ` Laszlo Ersek
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-01 16:22 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Michael S . Tsirkin, Laszlo Ersek, Dongjiu Geng,
Xiang Zheng, qemu-arm, Jonathan Cameron, Igor Mammedov,
Philippe Mathieu-Daudé
While APEI is a generic ACPI feature (usable by X86 and ARM64), only
the 'virt' machine uses it, by enabling the RAS Virtualization. See
commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option").
Restrict the APEI tables generation code to the single user: the virt
machine. If another machine wants to use it, it simply has to 'select
ACPI_APEI' in its Kconfig.
Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware error fw_cfg blob")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Reworded
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Xiang Zheng <zhengxiang9@huawei.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Igor Mammedov <imammedo@redhat.com>
---
default-configs/arm-softmmu.mak | 1 -
hw/arm/Kconfig | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 9a94ebd0be..08a32123b4 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -43,4 +43,3 @@ CONFIG_FSL_IMX7=y
CONFIG_FSL_IMX6UL=y
CONFIG_SEMIHOSTING=y
CONFIG_ALLWINNER_H3=y
-CONFIG_ACPI_APEI=y
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index f303c6bead..7d040827af 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -26,6 +26,7 @@ config ARM_VIRT
select ACPI_MEMORY_HOTPLUG
select ACPI_HW_REDUCED
select ACPI_NVDIMM
+ select ACPI_APEI
config CHEETAH
bool
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine
2020-10-01 16:22 [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine Philippe Mathieu-Daudé
@ 2020-10-02 7:44 ` Laszlo Ersek
2020-10-06 10:05 ` Igor Mammedov
2020-10-08 10:50 ` Peter Maydell
2 siblings, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2020-10-02 7:44 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Michael S . Tsirkin, Dongjiu Geng, Xiang Zheng,
qemu-arm, Jonathan Cameron, Igor Mammedov
On 10/01/20 18:22, Philippe Mathieu-Daudé wrote:
> While APEI is a generic ACPI feature (usable by X86 and ARM64), only
> the 'virt' machine uses it, by enabling the RAS Virtualization. See
> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option").
>
> Restrict the APEI tables generation code to the single user: the virt
> machine. If another machine wants to use it, it simply has to 'select
> ACPI_APEI' in its Kconfig.
>
> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware error fw_cfg blob")
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Reworded
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Xiang Zheng <zhengxiang9@huawei.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> ---
> default-configs/arm-softmmu.mak | 1 -
> hw/arm/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 9a94ebd0be..08a32123b4 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -43,4 +43,3 @@ CONFIG_FSL_IMX7=y
> CONFIG_FSL_IMX6UL=y
> CONFIG_SEMIHOSTING=y
> CONFIG_ALLWINNER_H3=y
> -CONFIG_ACPI_APEI=y
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index f303c6bead..7d040827af 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -26,6 +26,7 @@ config ARM_VIRT
> select ACPI_MEMORY_HOTPLUG
> select ACPI_HW_REDUCED
> select ACPI_NVDIMM
> + select ACPI_APEI
>
> config CHEETAH
> bool
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine
2020-10-01 16:22 [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine Philippe Mathieu-Daudé
2020-10-02 7:44 ` Laszlo Ersek
@ 2020-10-06 10:05 ` Igor Mammedov
2020-10-08 10:50 ` Peter Maydell
2 siblings, 0 replies; 5+ messages in thread
From: Igor Mammedov @ 2020-10-06 10:05 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Peter Maydell, Michael S . Tsirkin, qemu-devel, Dongjiu Geng,
Xiang Zheng, qemu-arm, Jonathan Cameron, Laszlo Ersek
On Thu, 1 Oct 2020 18:22:07 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> While APEI is a generic ACPI feature (usable by X86 and ARM64), only
> the 'virt' machine uses it, by enabling the RAS Virtualization. See
> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option").
>
> Restrict the APEI tables generation code to the single user: the virt
> machine. If another machine wants to use it, it simply has to 'select
> ACPI_APEI' in its Kconfig.
>
> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware error fw_cfg blob")
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2: Reworded
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Xiang Zheng <zhengxiang9@huawei.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> ---
> default-configs/arm-softmmu.mak | 1 -
> hw/arm/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 9a94ebd0be..08a32123b4 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -43,4 +43,3 @@ CONFIG_FSL_IMX7=y
> CONFIG_FSL_IMX6UL=y
> CONFIG_SEMIHOSTING=y
> CONFIG_ALLWINNER_H3=y
> -CONFIG_ACPI_APEI=y
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index f303c6bead..7d040827af 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -26,6 +26,7 @@ config ARM_VIRT
> select ACPI_MEMORY_HOTPLUG
> select ACPI_HW_REDUCED
> select ACPI_NVDIMM
> + select ACPI_APEI
>
> config CHEETAH
> bool
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine
2020-10-01 16:22 [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine Philippe Mathieu-Daudé
2020-10-02 7:44 ` Laszlo Ersek
2020-10-06 10:05 ` Igor Mammedov
@ 2020-10-08 10:50 ` Peter Maydell
2020-10-08 16:13 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2020-10-08 10:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Michael S . Tsirkin, QEMU Developers, Dongjiu Geng, Xiang Zheng,
qemu-arm, Jonathan Cameron, Igor Mammedov, Laszlo Ersek
On Thu, 1 Oct 2020 at 17:22, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> While APEI is a generic ACPI feature (usable by X86 and ARM64), only
> the 'virt' machine uses it, by enabling the RAS Virtualization. See
> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option").
>
> Restrict the APEI tables generation code to the single user: the virt
> machine. If another machine wants to use it, it simply has to 'select
> ACPI_APEI' in its Kconfig.
>
> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware error fw_cfg blob")
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Reworded
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Xiang Zheng <zhengxiang9@huawei.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> ---
> default-configs/arm-softmmu.mak | 1 -
> hw/arm/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
I assume this needs a respin now Paolo's reworking of
default-configs/ has gone into master.
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine
2020-10-08 10:50 ` Peter Maydell
@ 2020-10-08 16:13 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-08 16:13 UTC (permalink / raw)
To: Peter Maydell
Cc: Michael S . Tsirkin, QEMU Developers, Dongjiu Geng, Xiang Zheng,
qemu-arm, Jonathan Cameron, Igor Mammedov, Laszlo Ersek
On 10/8/20 12:50 PM, Peter Maydell wrote:
> On Thu, 1 Oct 2020 at 17:22, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> While APEI is a generic ACPI feature (usable by X86 and ARM64), only
>> the 'virt' machine uses it, by enabling the RAS Virtualization. See
>> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option").
>>
>> Restrict the APEI tables generation code to the single user: the virt
>> machine. If another machine wants to use it, it simply has to 'select
>> ACPI_APEI' in its Kconfig.
>>
>> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware error fw_cfg blob")
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> v2: Reworded
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Xiang Zheng <zhengxiang9@huawei.com>
>> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> ---
>> default-configs/arm-softmmu.mak | 1 -
>> hw/arm/Kconfig | 1 +
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> I assume this needs a respin now Paolo's reworking of
> default-configs/ has gone into master.
Ah indeed. The diff is simply:
-default-configs/arm-softmmu.mak
+default-configs/devices/arm-softmmu.mak
I'll send a v3, thanks for updating me.
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-08 16:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 16:22 [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine Philippe Mathieu-Daudé
2020-10-02 7:44 ` Laszlo Ersek
2020-10-06 10:05 ` Igor Mammedov
2020-10-08 10:50 ` Peter Maydell
2020-10-08 16:13 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.