From: Serge Semin <fancer.lancer@gmail.com> To: Leong Ching Swee <leong.ching.swee@intel.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Rohan G Thomas <rohan.g.thomas@intel.com> Subject: Re: [PATCH net-next v2 1/4] dt-bindings: net: snps,dwmac: per channel irq Date: Sun, 7 Jan 2024 23:10:37 +0300 [thread overview] Message-ID: <ffiewfybqvh66nmri4im4veupwytvlxk5jfgdy3nbj6wldxjl2@2vwvnnu37pt7> (raw) In-Reply-To: <20240105070925.2948871-2-leong.ching.swee@intel.com> On Fri, Jan 05, 2024 at 03:09:22PM +0800, Leong Ching Swee wrote: > From: Swee Leong Ching <leong.ching.swee@intel.com> > > Add dt-bindings for per channel irq. > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> > Signed-off-by: Swee Leong Ching <leong.ching.swee@intel.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 24 +++++++++++++------ > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 5c2769dc689a..e72dded824f4 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -103,17 +103,27 @@ properties: > > interrupts: > minItems: 1 > - items: > - - description: Combined signal for various interrupt events > - - description: The interrupt to manage the remote wake-up packet detection > - - description: The interrupt that occurs when Rx exits the LPI state > + maxItems: 19 > > interrupt-names: > minItems: 1 > + maxItems: 19 > items: > - - const: macirq > - - enum: [eth_wake_irq, eth_lpi] > - - const: eth_lpi > + oneOf: > + - description: Combined signal for various interrupt events > + const: macirq > + - description: The interrupt to manage the remote wake-up packet detection > + const: eth_wake_irq > + - description: The interrupt that occurs when Rx exits the LPI state > + const: eth_lpi > + - description: DMA Tx per-channel interrupt > + pattern: '^dma_tx[0-7]?$' > + - description: DMA Rx per-channel interrupt > + pattern: '^dma_rx[0-7]?$' > + > + allOf: > + - contains: > + const: macirq In order to restore the v1 discussion around this change, here is my comment copied from there: > As Rob correctly noted it's also better to make sure that 'macirq' is placed first > in the array. So instead of the constraint above I guess the next one would > make sure both the array has 'macirq' name and it's the first item: > > allOf: > - maxItems: 34 > items: > - const: macirq Leong said it didn't work: https://lore.kernel.org/netdev/CH0PR11MB54904615B45E521DE6B1A7B3CF61A@CH0PR11MB5490.namprd11.prod.outlook.com/ Rob, Krzysztof, Conor could you please clarify whether this change is ok the way it is or it would be better to preserve the stricter constraint and fix the DT-schema validation tool somehow? -Serge(y) > > clocks: > minItems: 1 > -- > 2.34.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <fancer.lancer@gmail.com> To: Leong Ching Swee <leong.ching.swee@intel.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Rohan G Thomas <rohan.g.thomas@intel.com> Subject: Re: [PATCH net-next v2 1/4] dt-bindings: net: snps,dwmac: per channel irq Date: Sun, 7 Jan 2024 23:10:37 +0300 [thread overview] Message-ID: <ffiewfybqvh66nmri4im4veupwytvlxk5jfgdy3nbj6wldxjl2@2vwvnnu37pt7> (raw) In-Reply-To: <20240105070925.2948871-2-leong.ching.swee@intel.com> On Fri, Jan 05, 2024 at 03:09:22PM +0800, Leong Ching Swee wrote: > From: Swee Leong Ching <leong.ching.swee@intel.com> > > Add dt-bindings for per channel irq. > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> > Signed-off-by: Swee Leong Ching <leong.ching.swee@intel.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 24 +++++++++++++------ > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 5c2769dc689a..e72dded824f4 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -103,17 +103,27 @@ properties: > > interrupts: > minItems: 1 > - items: > - - description: Combined signal for various interrupt events > - - description: The interrupt to manage the remote wake-up packet detection > - - description: The interrupt that occurs when Rx exits the LPI state > + maxItems: 19 > > interrupt-names: > minItems: 1 > + maxItems: 19 > items: > - - const: macirq > - - enum: [eth_wake_irq, eth_lpi] > - - const: eth_lpi > + oneOf: > + - description: Combined signal for various interrupt events > + const: macirq > + - description: The interrupt to manage the remote wake-up packet detection > + const: eth_wake_irq > + - description: The interrupt that occurs when Rx exits the LPI state > + const: eth_lpi > + - description: DMA Tx per-channel interrupt > + pattern: '^dma_tx[0-7]?$' > + - description: DMA Rx per-channel interrupt > + pattern: '^dma_rx[0-7]?$' > + > + allOf: > + - contains: > + const: macirq In order to restore the v1 discussion around this change, here is my comment copied from there: > As Rob correctly noted it's also better to make sure that 'macirq' is placed first > in the array. So instead of the constraint above I guess the next one would > make sure both the array has 'macirq' name and it's the first item: > > allOf: > - maxItems: 34 > items: > - const: macirq Leong said it didn't work: https://lore.kernel.org/netdev/CH0PR11MB54904615B45E521DE6B1A7B3CF61A@CH0PR11MB5490.namprd11.prod.outlook.com/ Rob, Krzysztof, Conor could you please clarify whether this change is ok the way it is or it would be better to preserve the stricter constraint and fix the DT-schema validation tool somehow? -Serge(y) > > clocks: > minItems: 1 > -- > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-07 20:10 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-05 7:09 [PATCH net-next v2 0/4] net: stmmac: Enable Per DMA Channel interrupt Leong Ching Swee 2024-01-05 7:09 ` Leong Ching Swee 2024-01-05 7:09 ` [PATCH net-next v2 1/4] dt-bindings: net: snps,dwmac: per channel irq Leong Ching Swee 2024-01-05 7:09 ` Leong Ching Swee 2024-01-07 20:10 ` Serge Semin [this message] 2024-01-07 20:10 ` Serge Semin 2024-01-09 9:10 ` Krzysztof Kozlowski 2024-01-09 9:10 ` Krzysztof Kozlowski 2024-01-09 22:20 ` Serge Semin 2024-01-09 22:20 ` Serge Semin 2024-01-05 7:09 ` [PATCH net-next v2 2/4] net: stmmac: Make MSI interrupt routine generic Leong Ching Swee 2024-01-05 7:09 ` Leong Ching Swee 2024-01-07 20:27 ` Serge Semin 2024-01-07 20:27 ` Serge Semin 2024-01-10 5:51 ` Swee, Leong Ching 2024-01-10 5:51 ` Swee, Leong Ching 2024-01-24 14:47 ` Serge Semin 2024-01-24 14:47 ` Serge Semin 2024-01-05 7:09 ` [PATCH net-next v2 3/4] net: stmmac: Add support for TX/RX channel interrupt Leong Ching Swee 2024-01-05 7:09 ` Leong Ching Swee 2024-01-07 20:38 ` Serge Semin 2024-01-07 20:38 ` Serge Semin 2024-01-10 5:45 ` Swee, Leong Ching 2024-01-10 5:45 ` Swee, Leong Ching 2024-01-05 7:09 ` [PATCH net-next v2 4/4] net: stmmac: Use interrupt mode INTM=1 for per channel irq Leong Ching Swee 2024-01-05 7:09 ` Leong Ching Swee 2024-01-07 20:52 ` Serge Semin 2024-01-07 20:52 ` Serge Semin 2024-01-10 5:43 ` Swee, Leong Ching 2024-01-10 5:43 ` Swee, Leong Ching 2024-01-07 16:40 ` [PATCH net-next v2 0/4] net: stmmac: Enable Per DMA Channel interrupt patchwork-bot+netdevbpf 2024-01-07 16:40 ` patchwork-bot+netdevbpf 2024-01-07 19:06 ` Krzysztof Kozlowski 2024-01-07 19:06 ` Krzysztof Kozlowski 2024-01-07 21:24 ` Serge Semin 2024-01-07 21:24 ` Serge Semin 2024-01-08 1:02 ` Jakub Kicinski 2024-01-08 1:02 ` Jakub Kicinski 2024-01-09 8:05 ` Swee, Leong Ching 2024-01-09 8:05 ` Swee, Leong Ching
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ffiewfybqvh66nmri4im4veupwytvlxk5jfgdy3nbj6wldxjl2@2vwvnnu37pt7 \ --to=fancer.lancer@gmail.com \ --cc=alexandre.torgue@foss.st.com \ --cc=conor+dt@kernel.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=joabreu@synopsys.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=leong.ching.swee@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=peppe.cavallaro@st.com \ --cc=robh+dt@kernel.org \ --cc=rohan.g.thomas@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.