All of lore.kernel.org
 help / color / mirror / Atom feed
From: Consul <void@aleksoft.net>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: Re: qcow2 corruption observed, fixed by reverting old change
Date: Thu, 12 Feb 2009 14:57:12 -0800	[thread overview]
Message-ID: <gn29ga$cjv$1@ger.gmane.org> (raw)
In-Reply-To: <20090211164814.GA7161@shareable.org>

Jamie Lokier wrote:
> 
> It was just for clarity.  If there are any bugs it's more likely to be
> truncation on a 32 bit host :-)
> 
Maybe not a proper fix, do you see the same "corruption" with this patch?
I don't know if it causes any memory leaks, but it certainly clears the 
segfaults while running my old qcow2 windows images. Perhaps this is a 
wrong place to free() or it needs a condition?

$ svn diff block.c
Index: block.c
===================================================================
--- block.c     (revision 6618)
+++ block.c     (working copy)
@@ -1263,7 +1263,7 @@
      if (!s->is_write) {
          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
      }
-    qemu_free(s->bounce);
+    //qemu_free(s->bounce);
      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
      qemu_aio_release(s->this_aiocb);
  }

WARNING: multiple messages have this Message-ID
From: Consul <void@aleksoft.net>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change
Date: Thu, 12 Feb 2009 14:57:12 -0800	[thread overview]
Message-ID: <gn29ga$cjv$1@ger.gmane.org> (raw)
In-Reply-To: <20090211164814.GA7161@shareable.org>

Jamie Lokier wrote:
> 
> It was just for clarity.  If there are any bugs it's more likely to be
> truncation on a 32 bit host :-)
> 
Maybe not a proper fix, do you see the same "corruption" with this patch?
I don't know if it causes any memory leaks, but it certainly clears the 
segfaults while running my old qcow2 windows images. Perhaps this is a 
wrong place to free() or it needs a condition?

$ svn diff block.c
Index: block.c
===================================================================
--- block.c     (revision 6618)
+++ block.c     (working copy)
@@ -1263,7 +1263,7 @@
      if (!s->is_write) {
          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
      }
-    qemu_free(s->bounce);
+    //qemu_free(s->bounce);
      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
      qemu_aio_release(s->this_aiocb);
  }

  reply	other threads:[~2009-02-12 22:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11  7:00 Jamie Lokier
2009-02-11  7:00 ` [Qemu-devel] " Jamie Lokier
2009-02-11  9:57 ` Kevin Wolf
2009-02-11 11:27   ` Jamie Lokier
2009-02-11 11:27     ` Jamie Lokier
2009-02-11 11:41   ` Jamie Lokier
2009-02-11 11:41     ` Jamie Lokier
2009-02-11 12:41     ` Kevin Wolf
2009-02-11 12:41       ` Kevin Wolf
2009-02-11 16:48       ` Jamie Lokier
2009-02-11 16:48         ` Jamie Lokier
2009-02-12 22:57         ` Consul [this message]
2009-02-12 22:57           ` Consul
2009-02-12 23:19           ` Consul
2009-02-12 23:19             ` [Qemu-devel] " Consul
2009-02-13  7:50             ` Marc Bevand
2009-02-16 12:44         ` [Qemu-devel] " Kevin Wolf
2009-02-17  0:43           ` Jamie Lokier
2009-02-17  0:43             ` Jamie Lokier
2009-03-06 22:37         ` Filip Navara
2009-03-06 22:37           ` Filip Navara
2009-02-12  5:45       ` Chris Wright
2009-02-12  5:45         ` Chris Wright
2009-02-12 11:08         ` Johannes Schindelin
2009-02-12 11:08           ` Johannes Schindelin
2009-02-13  6:41 ` Marc Bevand
2009-02-13 11:16   ` Kevin Wolf
2009-02-13 11:16     ` [Qemu-devel] " Kevin Wolf
2009-02-13 16:23     ` Jamie Lokier
2009-02-13 16:23       ` Jamie Lokier
2009-02-13 18:43       ` Chris Wright
2009-02-13 18:43         ` Chris Wright
2009-02-14  6:31       ` Marc Bevand
2009-02-14 22:28         ` Dor Laor
2009-02-14 22:28           ` Dor Laor
2009-02-15  2:27           ` Jamie Lokier
2009-02-15  7:56           ` Marc Bevand
2009-02-15  7:56             ` Marc Bevand
2009-02-15  2:37         ` Jamie Lokier
2009-02-15 10:57     ` Gleb Natapov
2009-02-15 10:57       ` [Qemu-devel] " Gleb Natapov
2009-02-15 11:46       ` Marc Bevand
2009-02-15 11:46         ` [Qemu-devel] " Marc Bevand
2009-02-15 11:54         ` Marc Bevand
2009-02-15 11:54           ` [Qemu-devel] " Marc Bevand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gn29ga$cjv$1@ger.gmane.org' \
    --to=void@aleksoft.net \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: qcow2 corruption observed, fixed by reverting old change' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.