* [PATCH 1/2] drm: Fix 3 typos in the inline doc
@ 2021-03-26 10:32 Dafna Hirschfeld
2021-03-26 10:32 ` [PATCH 2/2] drm/bridge: fix typo in Kconfig Dafna Hirschfeld
2021-03-26 10:35 ` [PATCH 1/2] drm: Fix 3 typos in the inline doc Simon Ser
0 siblings, 2 replies; 5+ messages in thread
From: Dafna Hirschfeld @ 2021-03-26 10:32 UTC (permalink / raw)
To: dri-devel
Cc: dafna.hirschfeld, airlied, dafna3, laurent.pinchart, tzimmermann,
enric.balletbo, kernel
Fix the following typos:
1. When mentioning a list of functions, the function
drm_atomic_helper_disable_plane is mentioned twice.
2. drop the word 'afterwards':
s/afterwards after that/after that/'
3. drop extra 'the':
s/but do not the support the full/but do not support the full/
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/gpu/drm/drm_atomic_helper.c | 15 +++++++--------
include/drm/drm_drv.h | 2 +-
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 560aaecba31b..eb527b63ceaa 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -61,9 +61,9 @@
*
* This library also provides implementations for all the legacy driver
* interfaces on top of the atomic interface. See drm_atomic_helper_set_config(),
- * drm_atomic_helper_disable_plane(), drm_atomic_helper_disable_plane() and the
- * various functions to implement set_property callbacks. New drivers must not
- * implement these functions themselves but must use the provided helpers.
+ * drm_atomic_helper_disable_plane(), and the various functions to implement
+ * set_property callbacks. New drivers must not implement these functions
+ * themselves but must use the provided helpers.
*
* The atomic helper uses the same function table structures as all other
* modesetting helpers. See the documentation for &struct drm_crtc_helper_funcs,
@@ -592,11 +592,10 @@ mode_valid(struct drm_atomic_state *state)
*
* Drivers which set &drm_crtc_state.mode_changed (e.g. in their
* &drm_plane_helper_funcs.atomic_check hooks if a plane update can't be done
- * without a full modeset) _must_ call this function afterwards after that
- * change. It is permitted to call this function multiple times for the same
- * update, e.g. when the &drm_crtc_helper_funcs.atomic_check functions depend
- * upon the adjusted dotclock for fifo space allocation and watermark
- * computation.
+ * without a full modeset) _must_ call this function after that change. It is
+ * permitted to call this function multiple times for the same update, e.g.
+ * when the &drm_crtc_helper_funcs.atomic_check functions depend upon the
+ * adjusted dotclock for fifo space allocation and watermark computation.
*
* RETURNS:
* Zero for success or -errno
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 827838e0a97e..b439ae1921b8 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -74,7 +74,7 @@ enum drm_driver_feature {
* @DRIVER_ATOMIC:
*
* Driver supports the full atomic modesetting userspace API. Drivers
- * which only use atomic internally, but do not the support the full
+ * which only use atomic internally, but do not support the full
* userspace API (e.g. not all properties converted to atomic, or
* multi-plane updates are not guaranteed to be tear-free) should not
* set this flag.
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/bridge: fix typo in Kconfig
2021-03-26 10:32 [PATCH 1/2] drm: Fix 3 typos in the inline doc Dafna Hirschfeld
@ 2021-03-26 10:32 ` Dafna Hirschfeld
2021-03-26 10:35 ` [PATCH 1/2] drm: Fix 3 typos in the inline doc Simon Ser
1 sibling, 0 replies; 5+ messages in thread
From: Dafna Hirschfeld @ 2021-03-26 10:32 UTC (permalink / raw)
To: dri-devel
Cc: dafna.hirschfeld, airlied, dafna3, laurent.pinchart, tzimmermann,
enric.balletbo, kernel
fix 's/controller/controllers/'
in the sentence:
Most display controller handle display connectors...
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/gpu/drm/bridge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index e4110d6ca7b3..cc55915dd0eb 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -42,7 +42,7 @@ config DRM_DISPLAY_CONNECTOR
depends on OF
help
Driver for display connectors with support for DDC and hot-plug
- detection. Most display controller handle display connectors
+ detection. Most display controllers handle display connectors
internally and don't need this driver, but the DRM subsystem is
moving towards separating connector handling from display controllers
on ARM-based platforms. Saying Y here when this driver is not needed
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm: Fix 3 typos in the inline doc
2021-03-26 10:32 [PATCH 1/2] drm: Fix 3 typos in the inline doc Dafna Hirschfeld
2021-03-26 10:32 ` [PATCH 2/2] drm/bridge: fix typo in Kconfig Dafna Hirschfeld
@ 2021-03-26 10:35 ` Simon Ser
2021-04-08 10:48 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Simon Ser @ 2021-03-26 10:35 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: airlied, dafna3, dri-devel, laurent.pinchart, tzimmermann,
enric.balletbo, kernel
Reviewed-by: Simon Ser <contact@emersion.fr>
I'll push this shortly to drm-misc-next.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm: Fix 3 typos in the inline doc
2021-03-26 10:35 ` [PATCH 1/2] drm: Fix 3 typos in the inline doc Simon Ser
@ 2021-04-08 10:48 ` Daniel Vetter
2021-04-08 10:49 ` Simon Ser
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2021-04-08 10:48 UTC (permalink / raw)
To: Simon Ser
Cc: Dafna Hirschfeld, airlied, dafna3, dri-devel, laurent.pinchart,
tzimmermann, enric.balletbo, kernel
On Fri, Mar 26, 2021 at 10:35:33AM +0000, Simon Ser wrote:
> Reviewed-by: Simon Ser <contact@emersion.fr>
>
> I'll push this shortly to drm-misc-next.
I also pushed the 2nd patch, seems to have been lost in the applying?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm: Fix 3 typos in the inline doc
2021-04-08 10:48 ` Daniel Vetter
@ 2021-04-08 10:49 ` Simon Ser
0 siblings, 0 replies; 5+ messages in thread
From: Simon Ser @ 2021-04-08 10:49 UTC (permalink / raw)
To: Daniel Vetter
Cc: Dafna Hirschfeld, airlied, dafna3, dri-devel, laurent.pinchart,
tzimmermann, enric.balletbo, kernel
Ah, I haven't seen the second patch...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-08 10:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 10:32 [PATCH 1/2] drm: Fix 3 typos in the inline doc Dafna Hirschfeld
2021-03-26 10:32 ` [PATCH 2/2] drm/bridge: fix typo in Kconfig Dafna Hirschfeld
2021-03-26 10:35 ` [PATCH 1/2] drm: Fix 3 typos in the inline doc Simon Ser
2021-04-08 10:48 ` Daniel Vetter
2021-04-08 10:49 ` Simon Ser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.