* [RFC] using kernel.bbclass rename hook for external modules as well
@ 2010-10-22 14:56 Koen Kooi
2010-10-22 17:06 ` Chris Larson
2010-10-23 7:46 ` Frans Meulenbroeks
0 siblings, 2 replies; 6+ messages in thread
From: Koen Kooi @ 2010-10-22 14:56 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
Currently kernel.bbclass splits and renames modules into
kernel-module-<foo>, but module.bbclass doesn't. What's your opinion on
making modules.bbclass follow the same logic for consistency?
To make upgrade paths work the 'kernel-modules' metapackage would be
${PN} for external modules.
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMwaYwMkyGM64RGpERAjvrAJ90+c1Eoz/1wIbcsfPsnFtcumk+5ACgoGRV
+G4w0GaBPGsBpARK7eLPG0M=
=vJ2H
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] using kernel.bbclass rename hook for external modules as well
2010-10-22 14:56 [RFC] using kernel.bbclass rename hook for external modules as well Koen Kooi
@ 2010-10-22 17:06 ` Chris Larson
2010-10-22 20:44 ` Khem Raj
2010-10-23 7:46 ` Frans Meulenbroeks
1 sibling, 1 reply; 6+ messages in thread
From: Chris Larson @ 2010-10-22 17:06 UTC (permalink / raw)
To: openembedded-devel
On Fri, Oct 22, 2010 at 7:56 AM, Koen Kooi <k.kooi@student.utwente.nl>wrote:
> Currently kernel.bbclass splits and renames modules into
> kernel-module-<foo>, but module.bbclass doesn't. What's your opinion on
> making modules.bbclass follow the same logic for consistency?
> To make upgrade paths work the 'kernel-modules' metapackage would be
> ${PN} for external modules.
>
This sounds like a very good idea to me, it would make the package list much
more consistent and improve the user experience, imo.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] using kernel.bbclass rename hook for external modules as well
2010-10-22 17:06 ` Chris Larson
@ 2010-10-22 20:44 ` Khem Raj
2010-10-23 8:28 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2010-10-22 20:44 UTC (permalink / raw)
To: openembedded-devel
On Fri, Oct 22, 2010 at 10:06 AM, Chris Larson <clarson@kergoth.com> wrote:
> On Fri, Oct 22, 2010 at 7:56 AM, Koen Kooi <k.kooi@student.utwente.nl>wrote:
>
>> Currently kernel.bbclass splits and renames modules into
>> kernel-module-<foo>, but module.bbclass doesn't. What's your opinion on
>> making modules.bbclass follow the same logic for consistency?
>> To make upgrade paths work the 'kernel-modules' metapackage would be
>> ${PN} for external modules.
>>
>
> This sounds like a very good idea to me, it would make the package list much
> more consistent and improve the user experience, imo.
yes I agree fully. Will there be issues with upgrades ?
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] using kernel.bbclass rename hook for external modules as well
2010-10-22 14:56 [RFC] using kernel.bbclass rename hook for external modules as well Koen Kooi
2010-10-22 17:06 ` Chris Larson
@ 2010-10-23 7:46 ` Frans Meulenbroeks
2010-10-23 13:14 ` Koen Kooi
1 sibling, 1 reply; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-10-23 7:46 UTC (permalink / raw)
To: openembedded-devel
2010/10/22 Koen Kooi <k.kooi@student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> Currently kernel.bbclass splits and renames modules into
> kernel-module-<foo>, but module.bbclass doesn't. What's your opinion on
> making modules.bbclass follow the same logic for consistency?
> To make upgrade paths work the 'kernel-modules' metapackage would be
> ${PN} for external modules.
The idea looks good to be, but can you explain the last sentence?
I would expect the recipes that use these modules get changed too and
with a PR bump they will drag in the new module with the new name, and
not too much additional work needed.
What I am missing?
BTW did a quick grep for "inherit module" (which also matches
module-base), matches 90 recipes (some of which are probably (nearly)
outdated as they are mainline; eg. pvrusb2)
And of course there are some recipes with older versions that are
probably not too interesting to keep)
Frans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] using kernel.bbclass rename hook for external modules as well
2010-10-22 20:44 ` Khem Raj
@ 2010-10-23 8:28 ` Koen Kooi
0 siblings, 0 replies; 6+ messages in thread
From: Koen Kooi @ 2010-10-23 8:28 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 22-10-10 22:44, Khem Raj wrote:
> On Fri, Oct 22, 2010 at 10:06 AM, Chris Larson <clarson@kergoth.com> wrote:
>> On Fri, Oct 22, 2010 at 7:56 AM, Koen Kooi <k.kooi@student.utwente.nl>wrote:
>>
>>> Currently kernel.bbclass splits and renames modules into
>>> kernel-module-<foo>, but module.bbclass doesn't. What's your opinion on
>>> making modules.bbclass follow the same logic for consistency?
>>> To make upgrade paths work the 'kernel-modules' metapackage would be
>>> ${PN} for external modules.
>>>
>>
>> This sounds like a very good idea to me, it would make the package list much
>> more consistent and improve the user experience, imo.
>
> yes I agree fully. Will there be issues with upgrades ?
There shouldn't be with the metapackage approach. What we currently do:
kernel:
'kernel-module-foo' -> have foo.ko
'kernel-modules' -> recommend all internal modules
external module:
'some-external-module' -> have bar.ko and baz.ko
In the new world:
kernel (unchanged):
'kernel-module-foo' -> have foo.ko
'kernel-modules' -> recommend all internal modules
external module:
'kernel-module-bar' -> have bar.ko
'kernel-module-baz' -> have baz.ko
'some-external-module' -> recommend kernel-module-bar kernel-module-baz
So most, if not all, external module recipes will be compatible with the
old naming.
Does that make things clearer?
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMwpzEMkyGM64RGpERAlKBAJ0fXK1V+uY4weJj9I/0WGOTzymwBACfQRPq
XBKCNHfqSVFqtwB2dVgazpU=
=UH63
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] using kernel.bbclass rename hook for external modules as well
2010-10-23 7:46 ` Frans Meulenbroeks
@ 2010-10-23 13:14 ` Koen Kooi
0 siblings, 0 replies; 6+ messages in thread
From: Koen Kooi @ 2010-10-23 13:14 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 23-10-10 09:46, Frans Meulenbroeks wrote:
> 2010/10/22 Koen Kooi <k.kooi@student.utwente.nl>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> Currently kernel.bbclass splits and renames modules into
>> kernel-module-<foo>, but module.bbclass doesn't. What's your opinion on
>> making modules.bbclass follow the same logic for consistency?
>> To make upgrade paths work the 'kernel-modules' metapackage would be
>> ${PN} for external modules.
>
> The idea looks good to be, but can you explain the last sentence?
> I would expect the recipes that use these modules get changed too and
> with a PR bump they will drag in the new module with the new name, and
> not too much additional work needed.
> What I am missing?
Khem asked a similar question which I tried to answer:
http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-October/026053.html
Does that address your question as well?
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMwt+nMkyGM64RGpERAhFhAJ9pLDQc9ngI0AB+/t+QAH9SSmnbRgCdHqOZ
O+vzfAYutIkZqD5OOfOBDY8=
=anSR
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-23 13:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-22 14:56 [RFC] using kernel.bbclass rename hook for external modules as well Koen Kooi
2010-10-22 17:06 ` Chris Larson
2010-10-22 20:44 ` Khem Raj
2010-10-23 8:28 ` Koen Kooi
2010-10-23 7:46 ` Frans Meulenbroeks
2010-10-23 13:14 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.