[PATCH] gst-ffmpeg: Add support for NEON optimization on armv7a

[PATCH] gst-ffmpeg: Add support for NEON optimization on armv7a

[Punya Prakash]

* Patch gst-ffmpeg configure script to allow passing extra config options
	* without this change parsinig of configuration for FFmpeg/libav fails for parameters like --with-ffmpeg-extra-configure="--extra-cflags='-mfpu=neon -mfloat-abi=softfp'"
* note: this patch has been accepted upstream to the mainline project
	* commit cc9d778844078d0eb2c23c7a11f7f855d013bca5
	* Target Milestone HEAD 0.10.12
---
 ...ac_cs_config-handling-for-RELEASE-0.10.11.patch |   25 ++++++++++++++++++++
 recipes/gstreamer/gst-ffmpeg_0.10.11.bb            |    4 ++-
 2 files changed, 28 insertions(+), 1 deletions(-)
 create mode 100644 recipes/gstreamer/gst-ffmpeg/0001-Fix-ac_cs_config-handling-for-RELEASE-0.10.11.patch

diff --git a/recipes/gstreamer/gst-ffmpeg/0001-Fix-ac_cs_config-handling-for-RELEASE-0.10.11.patch b/recipes/gstreamer/gst-ffmpeg/0001-Fix-ac_cs_config-handling-for-RELEASE-0.10.11.patch
new file mode 100644
index 0000000..e25c046
--- /dev/null
+++ b/recipes/gstreamer/gst-ffmpeg/0001-Fix-ac_cs_config-handling-for-RELEASE-0.10.11.patch
@@ -0,0 +1,25 @@
+From d6a20ee371feb4d6f1d94f7f0e0b012581900007 Mon Sep 17 00:00:00 2001
+From: Punya Prakash <pprakash@ti.com>
+Date: Thu, 5 May 2011 12:24:03 -0500
+Subject: [PATCH] Fix ac_cs_config handling for RELEASE-0.10.11
+
+ * Previously autoconf appended too many additional quotes to parameters like --with-ffmpeg-extra-configure=" --target-os=linux --extra-cflags='-mfpu=neon -mfloat-abi=softfp'"
+---
+ configure.ac |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index c9e5ac5..f7c01c4 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -372,7 +372,7 @@ else
+ 
+      AS_MKDIR_P(["$ac_top_build_prefix"gst-libs/ext/ffmpeg])
+      cd "$ac_top_build_prefix"gst-libs/ext/ffmpeg &&
+-         $confcmd $embffmpeg_configure_args ||
++         eval "$confcmd $embffmpeg_configure_args" ||
+          AC_MSG_ERROR([Failed to configure embedded FFmpeg tree])
+      cd "$origdir"
+     ],
+-- 
+1.7.0.4
+
diff --git a/recipes/gstreamer/gst-ffmpeg_0.10.11.bb b/recipes/gstreamer/gst-ffmpeg_0.10.11.bb
index 563521e..6eac5e8 100644
--- a/recipes/gstreamer/gst-ffmpeg_0.10.11.bb
+++ b/recipes/gstreamer/gst-ffmpeg_0.10.11.bb
@@ -5,11 +5,12 @@ LICENSE = "LGPL"
 HOMEPAGE = "http://www.gstreamer.net/"
 DEPENDS = "ffmpeg gstreamer gst-plugins-base zlib"
 
-PR = "r1"
+PR = "r2"
 
 inherit autotools pkgconfig
 
 SRC_URI = "http://gstreamer.freedesktop.org/src/${PN}/${PN}-${PV}.tar.bz2 \
+	    file://0001-Fix-ac_cs_config-handling-for-RELEASE-0.10.11.patch \
            file://lower-rank.diff \
 "
 
@@ -21,6 +22,7 @@ FILES_${PN}-dbg += "${libdir}/gstreamer-0.10/.debug"
 FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la ${libdir}/gstreamer-0.10/*.a"
 
 EXTRA_OECONF = " --with-system-ffmpeg "
+EXTRA_OECONF_armv7a = ' --with-ffmpeg-extra-configure="  --target-os=linux --extra-cflags='-march=armv7-a -mfpu=neon -mfloat-abi=softfp'"'
 
 # We do this because the install program is called with -s which causes it to
 # call "strip" and it then mangles cross compiled stuff..
-- 
1.7.0.4

Re: [PATCH] gst-ffmpeg: Add support for NEON optimization on armv7a

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06-05-11 15:33, Punya Prakash wrote:
> * Patch gst-ffmpeg configure script to allow passing extra config options
> 	* without this change parsinig of configuration for FFmpeg/libav fails for parameters like --with-ffmpeg-extra-configure="--extra-cflags='-mfpu=neon -mfloat-abi=softfp'"
> * note: this patch has been accepted upstream to the mainline project
> 	* commit cc9d778844078d0eb2c23c7a11f7f855d013bca5
> 	* Target Milestone HEAD 0.10.12

I have a comment and a nitpick, let's start with the nitpick first:

> +EXTRA_OECONF_armv7a = ' --with-ffmpeg-extra-configure="  --target-os=linux --extra-cflags='-march=armv7-a -mfpu=neon -mfloat-abi=softfp'"'

You're hardcoding linux and fb abi, which is bad.

Now the the comment:

This patch is useless, we link to the external libav (EXTRA_OECONF = "
- --with-system-ffmpeg"), which is built with the correct options. So this
patch has no effect and the way it's trying to achieve it is wrong, so:

NAK

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNxD6aMkyGM64RGpERAqzYAJ9Hy9QLRDLiKKtjcT/rtZrSrzYRqQCgr74M
wBFPHk+vCnXe1K+kS0MzIDE=
=H6dO
-----END PGP SIGNATURE-----