From: nishimura@mxp.nes.nec.co.jp
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
mingo@elte.hu,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][BUGFIX] memcg: fix for deadlock between lock_page_cgroup and mapping tree_lock
Date: Wed, 13 May 2009 13:11:28 +0900 [thread overview]
Message-ID: <isapiwc.d14e3c2a.4d44.4a0a4870.109c6.78@mail.jp.nec.com> (raw)
In-Reply-To: <20090513125558.57be0db6.kamezawa.hiroyu@jp.fujitsu.com>
> On Wed, 13 May 2009 09:32:50 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
>> On Wed, 13 May 2009 09:28:28 +0900
>> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>>
>> > On Wed, 13 May 2009 08:59:49 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> > > On Tue, 12 May 2009 19:58:23 +0900
>> > > Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote:
>> > >
>> > > > On Tue, 12 May 2009 17:13:56 +0900
>> > > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> > > >
>> > > > > On Tue, 12 May 2009 17:00:07 +0900
>> > > > > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>> > > > > > hmm, I see.
>> > > > > > cache_charge is outside of tree_lock, so moving uncharge would make sense.
>> > > > > > IMHO, we should make the period of spinlock as small as possible,
>> > > > > > and charge/uncharge of pagecache/swapcache is protected by page lock, not tree_lock.
>> > > > > >
>> > > > > How about this ?
>> > > > Looks good conceptually, but it cannot be built :)
>> > > >
>> > > > It needs a fix like this.
>> > > > Passed build test with enabling/disabling both CONFIG_MEM_RES_CTLR
>> > > > and CONFIG_SWAP.
>> > > >
>> > > ok, will update. can I add you Signed-off-by on the patch ?
>> > >
>> > Sure.
>> >
>> > Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
>> >
>> > The patch(with my fix applied) seems to work fine, I need run it
>> > for more long time though.
>> >
>> Ok, I'll treat this as an independent issue, not as "4/4".
>>
> Could you merge mine and yours and send it to Andrew ?
> I think this is a fix for dead-lock and priority is very high.
> I foumd my system broken and installing the whole system again, now.
> So, I can't post patch today.
>
Okey.
I'll post it soon.
Thanks,
Daisuke Nishimura.
WARNING: multiple messages have this Message-ID (diff)
From: nishimura@mxp.nes.nec.co.jp
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>KAMEZAWA
Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
mingo@elte.hu,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][BUGFIX] memcg: fix for deadlock between lock_page_cgroup and mapping tree_lock
Date: Wed, 13 May 2009 13:11:28 +0900 [thread overview]
Message-ID: <isapiwc.d14e3c2a.4d44.4a0a4870.109c6.78@mail.jp.nec.com> (raw)
In-Reply-To: <20090513125558.57be0db6.kamezawa.hiroyu@jp.fujitsu.com>
> On Wed, 13 May 2009 09:32:50 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
>> On Wed, 13 May 2009 09:28:28 +0900
>> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>>
>> > On Wed, 13 May 2009 08:59:49 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> > > On Tue, 12 May 2009 19:58:23 +0900
>> > > Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote:
>> > >
>> > > > On Tue, 12 May 2009 17:13:56 +0900
>> > > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> > > >
>> > > > > On Tue, 12 May 2009 17:00:07 +0900
>> > > > > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>> > > > > > hmm, I see.
>> > > > > > cache_charge is outside of tree_lock, so moving uncharge would make sense.
>> > > > > > IMHO, we should make the period of spinlock as small as possible,
>> > > > > > and charge/uncharge of pagecache/swapcache is protected by page lock, not tree_lock.
>> > > > > >
>> > > > > How about this ?
>> > > > Looks good conceptually, but it cannot be built :)
>> > > >
>> > > > It needs a fix like this.
>> > > > Passed build test with enabling/disabling both CONFIG_MEM_RES_CTLR
>> > > > and CONFIG_SWAP.
>> > > >
>> > > ok, will update. can I add you Signed-off-by on the patch ?
>> > >
>> > Sure.
>> >
>> > Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
>> >
>> > The patch(with my fix applied) seems to work fine, I need run it
>> > for more long time though.
>> >
>> Ok, I'll treat this as an independent issue, not as "4/4".
>>
> Could you merge mine and yours and send it to Andrew ?
> I think this is a fix for dead-lock and priority is very high.
> I foumd my system broken and installing the whole system again, now.
> So, I can't post patch today.
>
Okey.
I'll post it soon.
Thanks,
Daisuke Nishimura.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-13 4:16 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 1:44 [PATCH 0/3] fix stale swap cache account leak in memcg v7 KAMEZAWA Hiroyuki
2009-05-12 1:44 ` KAMEZAWA Hiroyuki
2009-05-12 1:45 ` [PATCH 1/3] add check for mem cgroup is activated KAMEZAWA Hiroyuki
2009-05-12 1:45 ` KAMEZAWA Hiroyuki
2009-05-12 1:46 ` [PATCH 2/3] fix swap cache account leak at swapin-readahead KAMEZAWA Hiroyuki
2009-05-12 1:46 ` KAMEZAWA Hiroyuki
2009-05-12 4:32 ` Daisuke Nishimura
2009-05-12 4:32 ` Daisuke Nishimura
2009-05-12 11:24 ` Johannes Weiner
2009-05-12 11:24 ` Johannes Weiner
2009-05-12 23:58 ` KAMEZAWA Hiroyuki
2009-05-12 23:58 ` KAMEZAWA Hiroyuki
2009-05-13 11:18 ` Johannes Weiner
2009-05-13 11:18 ` Johannes Weiner
2009-05-13 18:03 ` Hugh Dickins
2009-05-13 18:03 ` Hugh Dickins
2009-05-14 0:05 ` KAMEZAWA Hiroyuki
2009-05-14 0:05 ` KAMEZAWA Hiroyuki
2009-05-12 1:47 ` [PATCH 3/3] fix stale swap cache at writeback KAMEZAWA Hiroyuki
2009-05-12 1:47 ` KAMEZAWA Hiroyuki
2009-05-12 5:06 ` [PATCH 4/3] memcg: call uncharge_swapcache outside of tree_lock (Re: [PATCH 0/3] fix stale swap cache account leak in memcg v7) Daisuke Nishimura
2009-05-12 5:06 ` Daisuke Nishimura
2009-05-12 7:09 ` KAMEZAWA Hiroyuki
2009-05-12 7:09 ` KAMEZAWA Hiroyuki
2009-05-12 8:00 ` Daisuke Nishimura
2009-05-12 8:00 ` Daisuke Nishimura
2009-05-12 8:13 ` [PATCH][BUGFIX] memcg: fix for deadlock between lock_page_cgroup and mapping tree_lock KAMEZAWA Hiroyuki
2009-05-12 8:13 ` KAMEZAWA Hiroyuki
2009-05-12 10:58 ` Daisuke Nishimura
2009-05-12 10:58 ` Daisuke Nishimura
2009-05-12 23:59 ` KAMEZAWA Hiroyuki
2009-05-12 23:59 ` KAMEZAWA Hiroyuki
2009-05-13 0:28 ` Daisuke Nishimura
2009-05-13 0:28 ` Daisuke Nishimura
2009-05-13 0:32 ` KAMEZAWA Hiroyuki
2009-05-13 0:32 ` KAMEZAWA Hiroyuki
2009-05-13 3:55 ` KAMEZAWA Hiroyuki
2009-05-13 3:55 ` KAMEZAWA Hiroyuki
2009-05-13 4:11 ` nishimura [this message]
2009-05-13 4:11 ` nishimura
2009-05-12 9:51 ` [PATCH 0/3] fix stale swap cache account leak in memcg v7 Balbir Singh
2009-05-12 9:51 ` Balbir Singh
2009-05-13 0:31 ` KAMEZAWA Hiroyuki
2009-05-13 0:31 ` KAMEZAWA Hiroyuki
2009-05-14 23:47 ` KAMEZAWA Hiroyuki
2009-05-14 23:47 ` KAMEZAWA Hiroyuki
2009-05-15 0:38 ` Daisuke Nishimura
2009-05-15 0:38 ` Daisuke Nishimura
2009-05-15 0:54 ` KAMEZAWA Hiroyuki
2009-05-15 0:54 ` KAMEZAWA Hiroyuki
2009-05-15 1:12 ` Daisuke Nishimura
2009-05-15 1:12 ` Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=isapiwc.d14e3c2a.4d44.4a0a4870.109c6.78@mail.jp.nec.com \
--to=nishimura@mxp.nes.nec.co.jp \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=d-nishimura@mtf.biglobe.ne.jp \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.