Re: [Doc] class_find_device: fix reference to argument

Re: [Doc] class_find_device: fix reference to argument

[Wanlong Gao]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1165 bytes --]

no,not sure. but i think you are right.

Randy Dunlap <rdunlap@xenotime.net> wrote:

>On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
>
>> Rolf Eike Beer <eike <at> sf-mail.de> writes:
>> 
>> > 
>> > Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
>> > ---
>> >  drivers/base/class.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> > 
>> 
>> > - * @fn is allowed to do anything including calling back into class
>> > + * @match is allowed to do anything including calling back into class
>> >   * code.  There's no locking restriction.
>> >   */
>> >  struct device *class_find_device(struct class *class, struct device *start,
>> 
>> NACK, it means the function class_find_device but not the @match.
>
>Are you sure?  Looks to me like a comment that was copied from
>class_for_each_device() but shouldn't have been copied.
>
>Anyway, I'll cc: Greg to see if he knows.
>
>---
>~Randy
>*** Remember to use Documentation/SubmitChecklist when testing your code ***
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Doc] class_find_device: fix reference to argument

[Greg KH]

On Sun, Aug 21, 2011 at 02:53:55PM -0700, Randy Dunlap wrote:
> On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
> 
> > Rolf Eike Beer <eike <at> sf-mail.de> writes:
> > 
> > > 
> > > Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
> > > ---
> > >  drivers/base/class.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > 
> > > - * @fn is allowed to do anything including calling back into class
> > > + * @match is allowed to do anything including calling back into class
> > >   * code.  There's no locking restriction.
> > >   */
> > >  struct device *class_find_device(struct class *class, struct device *start,
> > 
> > NACK, it means the function class_find_device but not the @match.
> 
> Are you sure?  Looks to me like a comment that was copied from
> class_for_each_device() but shouldn't have been copied.
> 
> Anyway, I'll cc: Greg to see if he knows.

I think the above patch is probably correct, as it can reenter if
needed.

thanks,

greg k-h

Re: [Doc] class_find_device: fix reference to argument

[Randy Dunlap]

On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:

> Rolf Eike Beer <eike <at> sf-mail.de> writes:
> 
> > 
> > Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
> > ---
> >  drivers/base/class.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> 
> > - * @fn is allowed to do anything including calling back into class
> > + * @match is allowed to do anything including calling back into class
> >   * code.  There's no locking restriction.
> >   */
> >  struct device *class_find_device(struct class *class, struct device *start,
> 
> NACK, it means the function class_find_device but not the @match.

Are you sure?  Looks to me like a comment that was copied from
class_for_each_device() but shouldn't have been copied.

Anyway, I'll cc: Greg to see if he knows.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [Doc] class_find_device: fix reference to argument

[Wanlong Gao]

Rolf Eike Beer <eike <at> sf-mail.de> writes:

> 
> Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
> ---
>  drivers/base/class.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

> - * @fn is allowed to do anything including calling back into class
> + * @match is allowed to do anything including calling back into class
>   * code.  There's no locking restriction.
>   */
>  struct device *class_find_device(struct class *class, struct device *start,

NACK, it means the function class_find_device but not the @match.

Thanks
-Wanlong Gao