[meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Mehmood, Imran]

From: Imran Mehmood <Imran_Mehmood@mentor.com>

The following changes since commit 94a25d92b4d0e9379caaab127ccac1a94e9e4d28:
  Imran Mehmood (1):
        cramfs: Adds cvs version recipe (initial recipe)

are available in the git repository at:

  git://github.com/lawwama/meta-oe master
  https://github.com/lawwama/meta-oe/tree/master

Imran Mehmood (2):
  xclock: Add version 1.0.5 (initial recipe)
  twm: Add version 1.0.6 (initial recipe)

 meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb    |   16 ++++++++++++++++
 meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb |   10 ++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb
 create mode 100644 meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb

[meta-oe][PATCH v2 1/2] xclock: Add version 1.0.5 (initial recipe)

[Mehmood, Imran]

From: Imran Mehmood <Imran_Mehmood@mentor.com>

* Imported from oe.dev commit id 6e7e35679200cd55264fae308cd5dec7ef2d1d29

Signed-off-by: Imran Mehmood <Imran_Mehmood@mentor.com>
---
 meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb

diff --git a/meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb b/meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb
new file mode 100644
index 0000000..751433b
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb
@@ -0,0 +1,10 @@
+require recipes-graphics/xorg-app/xorg-app-common.inc
+
+DESCRIPTION = "analog / digital clock for X"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://COPYING;md5=857759ade8f2ddde5c7b32ef7356ea36"
+
+DEPENDS += " libxaw libxrender libxft libxkbfile libxt"
+
+SRC_URI[archive.md5sum] = "eaf124bbc9d13e1a12a29faaa2ed3612"
+SRC_URI[archive.sha256sum] = "53a9169e24f3814fbfcfee3ca0b98637840a3156ed7c7e36ae03940fabae4c9a"
-- 
1.7.0.4

Re: [meta-oe][PATCH v2 1/2] xclock: Add version 1.0.5 (initial recipe)

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-09-11 08:31, Mehmood, Imran schreef:
> From: Imran Mehmood <Imran_Mehmood@mentor.com>
> 
> * Imported from oe.dev commit id
> 6e7e35679200cd55264fae308cd5dec7ef2d1d29

It still has some shortcomings:

WARNING: For recipe xclock, the following files were installed but not
shipped in any package:
WARNING:   /usr/share/X11/app-defaults/XClock
WARNING:   /usr/share/X11/app-defaults/XClock-color
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOeuQaMkyGM64RGpERAgHtAJ9AFR2B9FitrhSC5NscGT1Ta/so8QCgiBm6
plD5s/gpjAIgrPIK0hY2L8s=
=gqzE
-----END PGP SIGNATURE-----

[meta-oe][PATCH v3 2/2] twm: Add version 1.0.6 (initial recipe)

[Mehmood, Imran]

From: Imran Mehmood <Imran_Mehmood@mentor.com>

 * Imported from oe.dev commit id d90ee2735e9aa9d1a8dd7d0eb6a5917030a233d3
 * Added bison-native to DEPENDS because during configure it searches for yacc and Defaults to the first program found out of: `bison -y', `byacc', `yacc' otherwise raises error 'yacc not found'. We don't face this error if we have built any other package that made yacc available, before building twm.

Signed-off-by: Imran Mehmood <Imran_Mehmood@mentor.com>
---
 meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb

diff --git a/meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb b/meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb
new file mode 100644
index 0000000..af27632
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb
@@ -0,0 +1,16 @@
+require recipes-graphics/xorg-app/xorg-app-common.inc
+DESCRIPTION = "tiny window manager"
+DEPENDS += " libxext libxt libxmu bison-native"
+
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://COPYING;md5=4c6d42ef60e8166aa26606524c0b9586"
+
+
+SRC_URI[archive.md5sum] = "952d06a0c2ec34687b536c7b619fc671"
+SRC_URI[archive.sha256sum] = "e7dccad7879a7570442f0cd9df0b9064e926466b5a52b710fca8cfb167f294e9"
+
+FILES_${PN} += "${datadir}/X11/twm/system.twmrc"
+ALTERNATIVE_NAME = "x-window-manager"
+ALTERNATIVE_PATH = "${bindir}/twm"
+ALTERNATIVE_LINK = "${bindir}/x-window-manager"
+ALTERNATIVE_PRIORITY = "1"
-- 
1.7.0.4

Re: [meta-oe][PATCH v3 2/2] twm: Add version 1.0.6 (initial recipe)

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-09-11 08:31, Mehmood, Imran schreef:
> From: Imran Mehmood <Imran_Mehmood@mentor.com>
> 
> * Imported from oe.dev commit id
> d90ee2735e9aa9d1a8dd7d0eb6a5917030a233d3 * Added bison-native to DEPENDS
> because during configure it searches for yacc and Defaults to the first
> program found out of: `bison -y', `byacc', `yacc' otherwise raises error
> 'yacc not found'. We don't face this error if we have built any other
> package that made yacc available, before building twm.

Applied, thanks!


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOeuQpMkyGM64RGpERAk/YAJwMpdOrJCgvsTDVZxxVXI6ejoYncQCfcYcY
6SewbpAfy1igP5lecYUHEAM=
=ffQX
-----END PGP SIGNATURE-----

Re: [meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-09-11 08:31, Mehmood, Imran schreef:
> From: Imran Mehmood <Imran_Mehmood@mentor.com>
> 
> The following changes since commit
> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: Adds
> cvs version recipe (initial recipe)

That isn't in meta-oe, so I can't pull your git tree. I'll grab the patches
from patchwork for now, but in the future please use a clean tree for pull
requests


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOetxvMkyGM64RGpERAr4DAJ9WbrqTfvlucjBccQm3UYebbaRS0wCeK9Tp
heTJQrpQAIhKyhzR2IF6yww=
=c2iD
-----END PGP SIGNATURE-----

Re: [meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Imran Mehmood]

hi koen,

On 09/22/2011 11:57 AM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 22-09-11 08:31, Mehmood, Imran schreef:
>> From: Imran Mehmood<Imran_Mehmood@mentor.com>
>>
>> The following changes since commit
>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: Adds
>> cvs version recipe (initial recipe)
> That isn't in meta-oe, so I can't pull your git tree. I'll grab the patches
> from patchwork for now, but in the future please use a clean tree for pull
> requests
>
>
Sorry for much delayed response I was busy with some other issues. I fixed the warning messages with xclock but before sending the patch again just wanted to clear a confusion regarding your response below.

I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to create-pull-request script with -r because I wanted to create pull request for all commits on my branch, made after this one. If its wrong whats the right way or thing to do? I mean

  what commit id should I pass to the script? Please explain a bit more in detail so that I can prepare next patch as per requirements.

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFOetxvMkyGM64RGpERAr4DAJ9WbrqTfvlucjBccQm3UYebbaRS0wCeK9Tp
> heTJQrpQAIhKyhzR2IF6yww=
> =c2iD
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Thanks and Regards,
Imran Mehmood

Re: [meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Imran Mehmood]

hi koen,
     I will be thankful if you can kindly comment.

On 10/03/2011 05:48 PM, Imran Mehmood wrote:
> hi koen,
>
> On 09/22/2011 11:57 AM, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Op 22-09-11 08:31, Mehmood, Imran schreef:
>>> From: Imran Mehmood<Imran_Mehmood@mentor.com>
>>>
>>> The following changes since commit
>>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: 
>>> Adds
>>> cvs version recipe (initial recipe)
>> That isn't in meta-oe, so I can't pull your git tree. I'll grab the 
>> patches
>> from patchwork for now, but in the future please use a clean tree for 
>> pull
>> requests
>>
>>
> Sorry for much delayed response I was busy with some other issues. I 
> fixed the warning messages with xclock but before sending the patch 
> again just wanted to clear a confusion regarding your response below.
>
> I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to 
> create-pull-request script with -r because I wanted to create pull 
> request for all commits on my branch, made after this one. If its 
> wrong whats the right way or thing to do? I mean
>
>  what commit id should I pass to the script? Please explain a bit more 
> in detail so that I can prepare next patch as per requirements.
>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.5 (Darwin)
>>
>> iD8DBQFOetxvMkyGM64RGpERAr4DAJ9WbrqTfvlucjBccQm3UYebbaRS0wCeK9Tp
>> heTJQrpQAIhKyhzR2IF6yww=
>> =c2iD
>> -----END PGP SIGNATURE-----
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
> Thanks and Regards,
> Imran Mehmood
>
Thanks and Regards,
Imran Mehmood

Re: [meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 07-10-11 16:15, Imran Mehmood schreef:
> hi koen, I will be thankful if you can kindly comment.

Please submit a new pull request, based on meta-oe with all the pending
mentor patches

> 
> On 10/03/2011 05:48 PM, Imran Mehmood wrote:
>> hi koen,
>> 
>> On 09/22/2011 11:57 AM, Koen Kooi wrote:
> Op 22-09-11 08:31, Mehmood, Imran schreef:
>>>>> From: Imran Mehmood<Imran_Mehmood@mentor.com>
>>>>> 
>>>>> The following changes since commit 
>>>>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1):
>>>>> cramfs: Adds cvs version recipe (initial recipe)
> That isn't in meta-oe, so I can't pull your git tree. I'll grab the
> patches from patchwork for now, but in the future please use a clean tree
> for pull requests
> 
> 
>>> Sorry for much delayed response I was busy with some other issues. I
>>> fixed the warning messages with xclock but before sending the patch
>>> again just wanted to clear a confusion regarding your response
>>> below.
>>> 
>>> I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to
>>> create-pull-request script with -r because I wanted to create pull
>>> request for all commits on my branch, made after this one. If its
>>> wrong whats the right way or thing to do? I mean
>>> 
>>> what commit id should I pass to the script? Please explain a bit more
>>> in detail so that I can prepare next patch as per requirements.
>>> 
>>> 
>>> 
>>> _______________________________________________ Openembedded-devel
>>> mailing list Openembedded-devel@lists.openembedded.org 
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>
>>
>>> 
Thanks and Regards,
>> Imran Mehmood
>> 
> Thanks and Regards, Imran Mehmood

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOjwyEMkyGM64RGpERAo3SAJ0aha3/uqMgThPCNXGrQg0LKhrjMgCeOyKu
ygNNpWq6Uc2WOn/yf03POok=
=+t4w
-----END PGP SIGNATURE-----

Re: [meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Anders Darander]

* Imran Mehmood <imran_mehmood@mentor.com> [111007 16:15]:
> On 10/03/2011 05:48 PM, Imran Mehmood wrote:
> > hi koen,

> > On 09/22/2011 11:57 AM, Koen Kooi wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1

> >> Op 22-09-11 08:31, Mehmood, Imran schreef:
> >>> From: Imran Mehmood<Imran_Mehmood@mentor.com>

> >>> The following changes since commit
> >>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: 
> >>> Adds
> >>> cvs version recipe (initial recipe)
> >> That isn't in meta-oe, so I can't pull your git tree. I'll grab the 
> >> patches
> >> from patchwork for now, but in the future please use a clean tree for 
> >> pull
> >> requests

> > Sorry for much delayed response I was busy with some other issues. I 
> > fixed the warning messages with xclock but before sending the patch 
> > again just wanted to clear a confusion regarding your response below.

> > I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to 
> > create-pull-request script with -r because I wanted to create pull 
> > request for all commits on my branch, made after this one. If its 
> > wrong whats the right way or thing to do? I mean

In order to make it easy for everyone to pull from your git tree, the
pull request should be based on a commit that is in the upstream git
tree.

In other words, the error/problem with your pull request was that you
had created a branch, then commit X-number of patches to that branch.
However, you only used the latest Y-patches (with Y being less than X)
in your pull-request.

A better approach would have been to create a new branch, cherry-pick
the Y-patches that you wanted to upstream into this new branch. And
finally, create a pull request for this new branch.

Cheers,
Anders

> >  what commit id should I pass to the script? Please explain a bit more 
> > in detail so that I can prepare next patch as per requirements.


-- 
Anders Darander
ChargeStorm AB / eStorm AB