All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, joro@8bytes.org,
	suravee.suthikulpanit@amd.com,  wei.huang2@amd.com, jgg@ziepe.ca
Subject: Re: [PATCH v5 08/14] iommu/amd: Consolidate feature detection and reporting logic
Date: Wed, 23 Aug 2023 15:30:04 -0700	[thread overview]
Message-ID: <jik5oniwfauvmvwjmemif3fvrcpfukyxk3cqqe542txrp6ejvw@mv6cvyhgn3jc> (raw)
In-Reply-To: <20230821104227.706997-9-vasant.hegde@amd.com>

On Mon, Aug 21, 2023 at 10:42:21AM +0000, Vasant Hegde wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> Currently, IOMMU driver assumes capabilities on all IOMMU instances to be
> homogeneous. During early_amd_iommu_init(), the driver probes all IVHD
> blocks and do sanity check to make sure that only features common among all
> IOMMU instances are supported. This is tracked in the global amd_iommu_efr
> and amd_iommu_efr2, which should be used whenever the driver need to check
> hardware capabilities.
> 
> Therefore, introduce check_feature() and check_feature2(), and modify
> the driver to adopt the new helper functions.
> 
> In addition, clean up the print_iommu_info() to avoid reporting redundant
> EFR/EFR2 for each IOMMU instance.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
>  drivers/iommu/amd/amd_iommu.h       | 17 ++++--
>  drivers/iommu/amd/amd_iommu_types.h |  4 ++
>  drivers/iommu/amd/init.c            | 89 ++++++++++++-----------------
>  drivers/iommu/amd/iommu.c           |  4 +-
>  4 files changed, 54 insertions(+), 60 deletions(-)
> 

Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>


  parent reply	other threads:[~2023-08-23 22:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 10:42 [PATCH v5 00/14] iommu/amd: SVA Support (Part 1) - cleanup/refactoring Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 01/14] iommu/amd: Remove unused amd_io_pgtable.pt_root variable Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 02/14] iommu/amd: Consolidate timeout pre-define to amd_iommu_type.h Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 03/14] iommu/amd: Consolidate logic to allocate protection domain Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 04/14] iommu/amd: Refactor protection domain allocation code Vasant Hegde
2023-08-22  8:06   ` Robin Murphy
2023-08-23 10:48     ` Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 05/14] iommu/amd: Introduce helper functions for managing GCR3 table Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 06/14] iommu/amd: Do not set amd_iommu_pgtable in pass-through mode Vasant Hegde
2023-08-21 10:42 ` [PATCH v5 07/14] iommu/amd: Miscellaneous clean up when free domain Vasant Hegde
2023-08-23 21:58   ` Jerry Snitselaar
2023-08-21 10:42 ` [PATCH v5 08/14] iommu/amd: Consolidate feature detection and reporting logic Vasant Hegde
2023-08-21 13:29   ` Jason Gunthorpe
2023-08-23 22:30   ` Jerry Snitselaar [this message]
2023-08-21 10:42 ` [PATCH v5 09/14] iommu/amd: Modify logic for checking GT and PPR features Vasant Hegde
2023-08-23 22:35   ` Jerry Snitselaar
2023-08-21 10:42 ` [PATCH v5 10/14] iommu/amd: Rename ats related variables Vasant Hegde
2023-08-23 22:54   ` Jerry Snitselaar
2023-08-21 10:42 ` [PATCH v5 11/14] iommu/amd: Introduce iommu_dev_data.ppr Vasant Hegde
2023-08-24  0:33   ` Jerry Snitselaar
2023-08-21 10:42 ` [PATCH v5 12/14] iommu/amd: Introduce iommu_dev_data.flags to track device capabilities Vasant Hegde
2023-08-21 13:32   ` Jason Gunthorpe
2023-08-24  2:10   ` Jerry Snitselaar
2023-08-21 10:42 ` [PATCH v5 13/14] iommu/amd: Enable device ATS/PASID/PRI capabilities independently Vasant Hegde
2023-08-24  2:19   ` Jerry Snitselaar
2023-08-21 10:42 ` [PATCH v5 14/14] iommu/amd: Initialize iommu_device->max_pasids Vasant Hegde
2023-08-24  2:24   ` Jerry Snitselaar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jik5oniwfauvmvwjmemif3fvrcpfukyxk3cqqe542txrp6ejvw@mv6cvyhgn3jc \
    --to=jsnitsel@redhat.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=vasant.hegde@amd.com \
    --cc=wei.huang2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.