[SPDK] Re: SPDK_DEBUGLOG_FLAG_ENABLED behaviour

[SPDK] Re: SPDK_DEBUGLOG_FLAG_ENABLED behaviour

[Damien Thenot]

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

Hello 
Thank you for your answer Paul. 
It is indeed not a "real" problem for me, my curiosity of this difference in the usage of log flags in this case was just big enough to make me ask publicly.
Sorry for cluttering the mailing list.


Have a nice day,

Damien


Le jeudi 13/01/2022, 18:57, Luse, Paul E a écrit :

Hi Damien,

Good question.  I don’t have the history on this but would guess they were implemented at different times and one just didn’t follow suit wrt the use of a string or not. Is this causing a problem for you? (ie why not use a string in the SPDK_DEBUGLOG_FLAG_ENABLED and a flag for SPDK_DEBUGLOG as current SPDK modules do?)

Thx
Paul

From: Damien Thenot <damien.thenot(a)vates.fr>
Date: Thursday, January 13, 2022 at 10:04 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] SPDK_DEBUGLOG_FLAG_ENABLED behaviour
Hello,

I have been tinkering with SPDK code and was trying to use the macro
`SPDK_DEBUGLOG_FLAG_ENABLED` (defined in `include/spdk/log.h`).

This macro expects a string but other uses of the log interface, e.g.
`SPDK_DEBULOG`, expects a FLAG that will be turned in a string by the
macro directly.


For my usage, I modified the macro to stringify the FLAG. Is this
behaviour the expected one or is the current behaviour the correct one?

Best regards,

Damien Thenot


Damien Thenot | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr [http://vates.fr/] | xcp-ng.org [http://xcp-ng.org/] | xen-orchestra.com [http://xen-orchestra.com/]

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org


Damien Thenot | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

[SPDK] Re: SPDK_DEBUGLOG_FLAG_ENABLED behaviour

[Luse, Paul E]

[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]

Hey, no worries that’s what the mailing list is for.  The community is also on slack if you want to check things out there and we have weekly meetings on Teams too.  Info for both are here:  https://spdk.io/community/

So wrt changing this, I’ll defer to someone who has some history on this but I suspect if there are no objections a patch to make them consistent would make sense.

Anyone have some thoughts?

Thx
Paul

From: Damien Thenot <damien.thenot(a)vates.fr>
Date: Thursday, January 13, 2022 at 12:35 PM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] Re: SPDK_DEBUGLOG_FLAG_ENABLED behaviour
Hello
Thank you for your answer Paul.
It is indeed not a "real" problem for me, my curiosity of this difference in the usage of log flags in this case was just big enough to make me ask publicly.
Sorry for cluttering the mailing list.


Have a nice day,

Damien


Le jeudi 13/01/2022, 18:57, Luse, Paul E a écrit :

Hi Damien,

Good question.  I don’t have the history on this but would guess they were implemented at different times and one just didn’t follow suit wrt the use of a string or not. Is this causing a problem for you? (ie why not use a string in the SPDK_DEBUGLOG_FLAG_ENABLED and a flag for SPDK_DEBUGLOG as current SPDK modules do?)

Thx
Paul

From: Damien Thenot <damien.thenot(a)vates.fr>
Date: Thursday, January 13, 2022 at 10:04 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] SPDK_DEBUGLOG_FLAG_ENABLED behaviour
Hello,

I have been tinkering with SPDK code and was trying to use the macro
`SPDK_DEBUGLOG_FLAG_ENABLED` (defined in `include/spdk/log.h`).

This macro expects a string but other uses of the log interface, e.g.
`SPDK_DEBULOG`, expects a FLAG that will be turned in a string by the
macro directly.


For my usage, I modified the macro to stringify the FLAG. Is this
behaviour the expected one or is the current behaviour the correct one?

Best regards,

Damien Thenot


Damien Thenot | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr [http://vates.fr/] | xcp-ng.org [http://xcp-ng.org/] | xen-orchestra.com [http://xen-orchestra.com/]

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org


Damien Thenot | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

[SPDK] Re: SPDK_DEBUGLOG_FLAG_ENABLED behaviour

[Luse, Paul E]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Hi Damien,

Good question.  I don’t have the history on this but would guess they were implemented at different times and one just didn’t follow suit wrt the use of a string or not. Is this causing a problem for you? (ie why not use a string in the SPDK_DEBUGLOG_FLAG_ENABLED and a flag for SPDK_DEBUGLOG as current SPDK modules do?)

Thx
Paul

From: Damien Thenot <damien.thenot(a)vates.fr>
Date: Thursday, January 13, 2022 at 10:04 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] SPDK_DEBUGLOG_FLAG_ENABLED behaviour
Hello,

I have been tinkering with SPDK code and was trying to use the macro
`SPDK_DEBUGLOG_FLAG_ENABLED` (defined in `include/spdk/log.h`).

This macro expects a string but other uses of the log interface, e.g.
`SPDK_DEBULOG`, expects a FLAG that will be turned in a string by the
macro directly.


For my usage, I modified the macro to stringify the FLAG. Is this
behaviour the expected one or is the current behaviour the correct one?

Best regards,

Damien Thenot


Damien Thenot | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org