All of lore.kernel.org
 help / color / mirror / Atom feed
* Force Feedback Logitech G25/G25/Driving Force Pro
@ 2011-03-11 11:15 Peter
  2011-03-15 15:44 ` Olivier Michel
  2011-03-22  4:57 ` [PATCH] G25_support Simon Wood
  0 siblings, 2 replies; 7+ messages in thread
From: Peter @ 2011-03-11 11:15 UTC (permalink / raw)
  To: linux-input

Hi,

i'd like to ask if someone could add the id's of the logitech wheels to
drivers/hid/hid-lgff.c, so that the wheels autocenter can be
enabled/disabled by userland programs like wine. There has been
discussion over this before:
http://www.mail-archive.com/linux-input@atrey.karlin.mff.cuni.cz/msg01426.html

Line 72:
        { 0x046d, 0xc294, ff_wheel },
has to be copied twice with 0xc294 changed to 0xc298 (DFP) and 0xc299
(G25/G27), because after switching to native mode the devices report
different ids:
        { 0x046d, 0xc298, ff_wheel },
        { 0x046d, 0xc299, ff_wheel },

That's it. 
I managed to get my G27 fully working in LFS (http://www.lfs.net) with
this small modification and some additional fixes to wine. The G25's
Force Feedback, all 4 axis and 20some buttons work like a charm.

Thx in advance, Peter



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Force Feedback Logitech G25/G25/Driving Force Pro
  2011-03-11 11:15 Force Feedback Logitech G25/G25/Driving Force Pro Peter
@ 2011-03-15 15:44 ` Olivier Michel
  2011-03-22  4:57 ` [PATCH] G25_support Simon Wood
  1 sibling, 0 replies; 7+ messages in thread
From: Olivier Michel @ 2011-03-15 15:44 UTC (permalink / raw)
  To: linux-input

I fully support this request, as it would be very useful to me as well and
probably to many other users (I am struggling with kernel patches to get my G27
race wheel work with force feedback)





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] G25_support
  2011-03-11 11:15 Force Feedback Logitech G25/G25/Driving Force Pro Peter
  2011-03-15 15:44 ` Olivier Michel
@ 2011-03-22  4:57 ` Simon Wood
  2011-03-22  9:40   ` Jiri Kosina
                     ` (2 more replies)
  1 sibling, 3 replies; 7+ messages in thread
From: Simon Wood @ 2011-03-22  4:57 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-input, Peter, Simon Wood

From: Peter <peter@slim-one.de>

Small patch to add support for the G25/G27 by adding USB ID's
as suggested by Peter.

Boots but otherwise untested as I don't have hardware, .debs for
kernel (2.6.38) here if want to test/run Ubuntu/Debian:
http://www.mungewell.org/Logitech_Wii_Wheel/

Reported-by: Peter <peter@slim-one.de>
Signed-off-by: Simon Wood <simon@mungewell.org>
---
 drivers/hid/hid-lgff.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
index 90d0ef2..f099079 100644
--- a/drivers/hid/hid-lgff.c
+++ b/drivers/hid/hid-lgff.c
@@ -73,6 +73,8 @@ static const struct dev_type devices[] = {
 	{ 0x046d, 0xc293, ff_joystick },
 	{ 0x046d, 0xc294, ff_wheel },
 	{ 0x046d, 0xc295, ff_joystick },
+	{ 0x046d, 0xc298, ff_wheel },
+	{ 0x046d, 0xc299, ff_wheel },
 	{ 0x046d, 0xca03, ff_wheel },
 };
 
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] G25_support
  2011-03-22  4:57 ` [PATCH] G25_support Simon Wood
@ 2011-03-22  9:40   ` Jiri Kosina
  2011-03-27 19:41   ` Jiri Kosina
  2011-05-02 19:17   ` [PATCH] G27_support Peter
  2 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2011-03-22  9:40 UTC (permalink / raw)
  To: Simon Wood; +Cc: linux-input, Peter, Christophe Borivant, Michal Malý

On Mon, 21 Mar 2011, Simon Wood wrote:

> From: Peter <peter@slim-one.de>
> 
> Small patch to add support for the G25/G27 by adding USB ID's
> as suggested by Peter.
> 
> Boots but otherwise untested as I don't have hardware, .debs for
> kernel (2.6.38) here if want to test/run Ubuntu/Debian:
> http://www.mungewell.org/Logitech_Wii_Wheel/
> 
> Reported-by: Peter <peter@slim-one.de>
> Signed-off-by: Simon Wood <simon@mungewell.org>
> ---
>  drivers/hid/hid-lgff.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
> index 90d0ef2..f099079 100644
> --- a/drivers/hid/hid-lgff.c
> +++ b/drivers/hid/hid-lgff.c
> @@ -73,6 +73,8 @@ static const struct dev_type devices[] = {
>  	{ 0x046d, 0xc293, ff_joystick },
>  	{ 0x046d, 0xc294, ff_wheel },
>  	{ 0x046d, 0xc295, ff_joystick },
> +	{ 0x046d, 0xc298, ff_wheel },
> +	{ 0x046d, 0xc299, ff_wheel },
>  	{ 0x046d, 0xca03, ff_wheel },
>  };

You are right that missing entries in this struct for devices which have 
LG_FF flag set doesn't make too much sense.

Adding Michal and Chritophe to CC, as they should have the HW to test.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] G25_support
  2011-03-22  4:57 ` [PATCH] G25_support Simon Wood
  2011-03-22  9:40   ` Jiri Kosina
@ 2011-03-27 19:41   ` Jiri Kosina
  2011-05-02 19:17   ` [PATCH] G27_support Peter
  2 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2011-03-27 19:41 UTC (permalink / raw)
  To: Simon Wood; +Cc: linux-input, Peter

On Mon, 21 Mar 2011, Simon Wood wrote:

> From: Peter <peter@slim-one.de>

Could you please provide full name here, so that I could apply the patch 
with proper authorship attribution?

Thanks.

> 
> Small patch to add support for the G25/G27 by adding USB ID's
> as suggested by Peter.
> 
> Boots but otherwise untested as I don't have hardware, .debs for
> kernel (2.6.38) here if want to test/run Ubuntu/Debian:
> http://www.mungewell.org/Logitech_Wii_Wheel/
> 
> Reported-by: Peter <peter@slim-one.de>
> Signed-off-by: Simon Wood <simon@mungewell.org>
> ---
>  drivers/hid/hid-lgff.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
> index 90d0ef2..f099079 100644
> --- a/drivers/hid/hid-lgff.c
> +++ b/drivers/hid/hid-lgff.c
> @@ -73,6 +73,8 @@ static const struct dev_type devices[] = {
>  	{ 0x046d, 0xc293, ff_joystick },
>  	{ 0x046d, 0xc294, ff_wheel },
>  	{ 0x046d, 0xc295, ff_joystick },
> +	{ 0x046d, 0xc298, ff_wheel },
> +	{ 0x046d, 0xc299, ff_wheel },
>  	{ 0x046d, 0xca03, ff_wheel },
>  };

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] G27_support
  2011-03-22  4:57 ` [PATCH] G25_support Simon Wood
  2011-03-22  9:40   ` Jiri Kosina
  2011-03-27 19:41   ` Jiri Kosina
@ 2011-05-02 19:17   ` Peter
  2011-05-02 19:21     ` Jiri Kosina
  2 siblings, 1 reply; 7+ messages in thread
From: Peter @ 2011-05-02 19:17 UTC (permalink / raw)
  To: linux-input; +Cc: Jiri Kosina, Olivier Michel, Simon Wood

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi,

here's a small patch to add support for the Logitech G27 wheel, since
the prior patch only added FF support for the Driving Force Pro and G25.
The patch contains the changes from the G25 and DFP, too, since they
were not in linux/kernel/git/jikos/hid.git.
I tested the changes with wine/LFS and got full support for all axes and
buttons.

Regards, Peter

[-- Attachment #2: G27.patch --]
[-- Type: text/x-patch, Size: 2412 bytes --]

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index c3d6626..4e33886 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1405,6 +1405,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOMO_WHEEL2) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G27_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACETRAVELLER) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index d485894..7db251c 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -394,6 +394,7 @@
 #define USB_DEVICE_ID_LOGITECH_MOMO_WHEEL	0xc295
 #define USB_DEVICE_ID_LOGITECH_DFP_WHEEL	0xc298
 #define USB_DEVICE_ID_LOGITECH_G25_WHEEL	0xc299
+#define USB_DEVICE_ID_LOGITECH_G27_WHEEL	0xc29b
 #define USB_DEVICE_ID_LOGITECH_WII_WHEEL	0xc29c
 #define USB_DEVICE_ID_LOGITECH_ELITE_KBD	0xc30a
 #define USB_DEVICE_ID_S510_RECEIVER	0xc50c
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index 3da9040..21f205f 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -377,6 +377,8 @@ static const struct hid_device_id lg_devices[] = {
 		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL),
 		.driver_data = LG_FF },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G27_WHEEL),
+		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
 		.driver_data = LG_FF },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL),
diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
index 90d0ef2..f901349 100644
--- a/drivers/hid/hid-lgff.c
+++ b/drivers/hid/hid-lgff.c
@@ -72,6 +72,9 @@ static const struct dev_type devices[] = {
 	{ 0x046d, 0xc287, ff_joystick_ac },
 	{ 0x046d, 0xc293, ff_joystick },
 	{ 0x046d, 0xc294, ff_wheel },
+	{ 0x046d, 0xc298, ff_wheel },
+	{ 0x046d, 0xc299, ff_wheel },
+	{ 0x046d, 0xc29b, ff_wheel },
 	{ 0x046d, 0xc295, ff_joystick },
 	{ 0x046d, 0xca03, ff_wheel },
 };

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] G27_support
  2011-05-02 19:17   ` [PATCH] G27_support Peter
@ 2011-05-02 19:21     ` Jiri Kosina
  0 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2011-05-02 19:21 UTC (permalink / raw)
  To: Peter; +Cc: linux-input, Olivier Michel, Simon Wood

On Mon, 2 May 2011, Peter wrote:

> Hi,
> 
> here's a small patch to add support for the Logitech G27 wheel, since
> the prior patch only added FF support for the Driving Force Pro and G25.
> The patch contains the changes from the G25 and DFP, too, since they
> were not in linux/kernel/git/jikos/hid.git.
> I tested the changes with wine/LFS and got full support for all axes and
> buttons.

Thanks a lot for the patch.

Could you please send it altogether with proper From: and Signed-off-by: 
lines, so that I could apply it?

Thanks,

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-05-02 19:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-11 11:15 Force Feedback Logitech G25/G25/Driving Force Pro Peter
2011-03-15 15:44 ` Olivier Michel
2011-03-22  4:57 ` [PATCH] G25_support Simon Wood
2011-03-22  9:40   ` Jiri Kosina
2011-03-27 19:41   ` Jiri Kosina
2011-05-02 19:17   ` [PATCH] G27_support Peter
2011-05-02 19:21     ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.