All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Freyther <holger@freyther.de>
To: ofono@ofono.org
Subject: Re: [PATCH] wavecom: Re-work modem handling to improve stability
Date: Sat, 16 Apr 2016 15:41:02 +0000	[thread overview]
Message-ID: <loom.20160416T173735-783@post.gmane.org> (raw)
In-Reply-To: <57055779.7050200@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

Denis Kenzior <denkenz@...> writes:

> 
> Hi Holger,

Dear Denis,


> 
> Just a minor nitpick here, but doc/coding-style.txt, item M1

sorry about that. I was not sure about. I should have addressed
everything now.



> > -	DBG("%p", modem);
> > +	/* TODO: Initialize GPRS support if we have an aux line */
> > +	/*
> > +	 * FIXME: This only seems to be called when no immediate
> > +	 * enabled -> online change is called
> > +	 */
> 
> ??

I had sent a separate mail about that. For some reason (well, we actually
patched the state machine in modem.c and I have to re-test), this post
sim cb was never called.

I will try to re-test when I am back to the office next week.


> 
> Please note that you can debug the wavecom plugin specifically by 
> starting ofonod with -d '*wavecom*'

thanks, I assumed it would be possible but sed -i s,DBG,o..error, was
easier when developing. :)

thank you for your fast review

  holger



  reply	other threads:[~2016-04-16 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 19:25 [PATCH] wavecom: Re-work modem handling to improve stability Holger Hans Peter Freyther
2016-04-06 18:37 ` Denis Kenzior
2016-04-16 15:41   ` Holger Freyther [this message]
2016-04-16 15:36 Holger Hans Peter Freyther
2016-04-19  2:30 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20160416T173735-783@post.gmane.org \
    --to=holger@freyther.de \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.