All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] ccache: allow CCACHE_DIR to be overriden
@ 2013-07-26  7:35 wenzong.fan
  2013-07-26  7:35 ` [PATCH 1/1] " wenzong.fan
  0 siblings, 1 reply; 3+ messages in thread
From: wenzong.fan @ 2013-07-26  7:35 UTC (permalink / raw)
  To: openembedded-core

From: Wenzong Fan <wenzong.fan@windriver.com>

Use weaker assignment for CCACHE_DIR to allow users to override it
if desired.

The following changes since commit 67864ca79da08df752487a3a4e1a975546da123d:

  systemd: Remove systemd_unitdir if systemd is not in distro features (2013-07-24 11:35:39 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib wenzong/ccache_bbclass
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/ccache_bbclass

Wenzong Fan (1):
  ccache: allow CCACHE_DIR to be overriden

 meta/classes/ccache.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.9.5



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] ccache: allow CCACHE_DIR to be overriden
  2013-07-26  7:35 [PATCH 0/1] ccache: allow CCACHE_DIR to be overriden wenzong.fan
@ 2013-07-26  7:35 ` wenzong.fan
  2013-07-31 10:05   ` Enrico Scholz
  0 siblings, 1 reply; 3+ messages in thread
From: wenzong.fan @ 2013-07-26  7:35 UTC (permalink / raw)
  To: openembedded-core

From: Wenzong Fan <wenzong.fan@windriver.com>

Use weaker assignment for CCACHE_DIR to allow users to override it
if desired.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/classes/ccache.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/ccache.bbclass b/meta/classes/ccache.bbclass
index cd06a4b..ca3ca43 100644
--- a/meta/classes/ccache.bbclass
+++ b/meta/classes/ccache.bbclass
@@ -1,5 +1,5 @@
 CCACHE = "${@bb.which(d.getVar('PATH', True), 'ccache') and 'ccache '}"
-export CCACHE_DIR = "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"
+export CCACHE_DIR ?= "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"
 CCACHE_DISABLE[unexport] = "1"
 
 do_configure[dirs] =+ "${CCACHE_DIR}"
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ccache: allow CCACHE_DIR to be overriden
  2013-07-26  7:35 ` [PATCH 1/1] " wenzong.fan
@ 2013-07-31 10:05   ` Enrico Scholz
  0 siblings, 0 replies; 3+ messages in thread
From: Enrico Scholz @ 2013-07-31 10:05 UTC (permalink / raw)
  To: openembedded-core; +Cc: wenzong.fan-CWA4WttNNZF54TAoqtyWWQ

<wenzong.fan-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> writes:

> Use weaker assignment for CCACHE_DIR to allow users to override it
> if desired.
>
> -export CCACHE_DIR = "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"
> +export CCACHE_DIR ?= "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"

This can be a dangerous change and probably does not have the intended
effect ((project) global ccache dir) due to

| do_clean[cleandirs] += "${CCACHE_DIR}"


imo, this class should be removed completely (${PN} local ccache dirs do
not make any sense) and the only useful part

| CCACHE_DISABLE[unexport] = "1"

should be solved by http://patchwork.openembedded.org/patch/32787/



Enrico


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-31 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-26  7:35 [PATCH 0/1] ccache: allow CCACHE_DIR to be overriden wenzong.fan
2013-07-26  7:35 ` [PATCH 1/1] " wenzong.fan
2013-07-31 10:05   ` Enrico Scholz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.