[PATCH] cacaoh: patches to get do_install do its work

[PATCH] cacaoh: patches to get do_install do its work

[Jaap de Jong]

 From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
From: Jaap de Jong <jaap.dejong@nedap.com>
Date: Fri, 22 Oct 2010 09:28:25 +0200
Subject: [PATCH] cacaoh: patches to get do_install do its work

Signed-off-by: Jaap de Jong <jaap.dejong@nedap.com>
---
  recipes/cacao/cacaoh-cldc-native_0.98.bb |    2 +-
  recipes/cacao/cacaoh-native.inc          |    2 +-
  recipes/cacao/cacaoh-openjdk-native.inc  |    2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/recipes/cacao/cacaoh-cldc-native_0.98.bb 
b/recipes/cacao/cacaoh-cldc-native_0.98.bb
index 9a34b36..44b81fe 100644
--- a/recipes/cacao/cacaoh-cldc-native_0.98.bb
+++ b/recipes/cacao/cacaoh-cldc-native_0.98.bb
@@ -5,7 +5,7 @@ SRC_URI = "\
    "

  do_stage() {
-    install -m 0755 src/cacaoh/.libs/cacaoh 
${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
  }

  SRC_URI[md5sum] = "8b8907c8b925761c9410bcadb9705346"
diff --git a/recipes/cacao/cacaoh-native.inc 
b/recipes/cacao/cacaoh-native.inc
index 2b3709f..d745107 100644
--- a/recipes/cacao/cacaoh-native.inc
+++ b/recipes/cacao/cacaoh-native.inc
@@ -24,7 +24,7 @@ do_compile() {

  do_install() {
    install -d ${D}${bindir}/cacaoh-${PV}
-  install -m 0755 src/cacaoh/.libs/cacaoh ${D}${bindir}/cacaoh-${PV}
+  install -m 0755 src/cacaoh/cacaoh ${D}${bindir}/cacaoh-${PV}
  }

  NATIVE_INSTALL_WORKS = "1"
diff --git a/recipes/cacao/cacaoh-openjdk-native.inc 
b/recipes/cacao/cacaoh-openjdk-native.inc
index 5070e7e..4afb955 100644
--- a/recipes/cacao/cacaoh-openjdk-native.inc
+++ b/recipes/cacao/cacaoh-openjdk-native.inc
@@ -27,5 +27,5 @@ do_compile() {
  }

  do_install() {
-    install -m 0755 src/cacaoh/.libs/cacaoh 
${STAGING_BINDIR}/cacaoh-openjdk-${PV}
+    install -m 0755 src/cacaoh/cacaoh 
${STAGING_BINDIR}/cacaoh-openjdk-${PV}
  }
-- 
1.7.1

Re: [PATCH] cacaoh: patches to get do_install do its work

[Enrico Scholz]

Jaap de Jong <jaap.dejong@nedap.com> writes:

> -    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
> +    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

This is the wrong way to install libtool binaries/libraries.  Please
use 'libtool --mode=install install -m ...' (or the platform prefixed
'libtool' program).


Enrico

Re: [PATCH] cacaoh: patches to get do_install do its work

[Khem Raj]

On Sun, Oct 24, 2010 at 6:19 AM, Enrico Scholz
<enrico.scholz@sigma-chemnitz.de> wrote:
> Jaap de Jong <jaap.dejong@nedap.com> writes:
>
>> -    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>> +    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>
> This is the wrong way to install libtool binaries/libraries.  Please
> use 'libtool --mode=install install -m ...' (or the platform prefixed
> 'libtool' program).
>

whats the difference ?

>
> Enrico
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] cacaoh: patches to get do_install do its work

[Enrico Scholz]

Khem Raj <raj.khem@gmail.com> writes:

>>> -    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>>> +    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>>
>> This is the wrong way to install libtool binaries/libraries.  Please
>> use 'libtool --mode=install install -m ...' (or the platform prefixed
>> 'libtool' program).
>
> whats the difference ?

* 'libtool --mode=install' is the documented way[1] to install libtool
  binaries (in case of libraries, a 'libtool --mode=finish' might be
  required too)

* libtool creates sometimes a wrapper script for executables (e.g. when
  they are linked against local libraries) and places the real executable
  in .libs/.  Manually installing one of them is error prone and it might
  break with other linker flags or libtool versions.


Enrico

Footnotes: 
[1]  info libtool -> Installing libraries + Installing executables

Re: [PATCH] cacaoh: patches to get do_install do its work

[Khem Raj]

On 10/25/10, Enrico Scholz <enrico.scholz@sigma-chemnitz.de> wrote:
> Khem Raj <raj.khem@gmail.com> writes:
>
>>>> -    install -m 0755 src/cacaoh/.libs/cacaoh
>>>> ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>>>> +    install -m 0755 src/cacaoh/cacaoh
>>>> ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>>>
>>> This is the wrong way to install libtool binaries/libraries.  Please
>>> use 'libtool --mode=install install -m ...' (or the platform prefixed
>>> 'libtool' program).
>>
>> whats the difference ?
>
> * 'libtool --mode=install' is the documented way[1] to install libtool
>   binaries (in case of libraries, a 'libtool --mode=finish' might be
>   required too)

that should not be a problem here as its not a library and does not have .la
files to be fixed.

>
> * libtool creates sometimes a wrapper script for executables (e.g. when
>   they are linked against local libraries) and places the real executable
>   in .libs/.  Manually installing one of them is error prone and it might
>   break with other linker flags or libtool versions.
>

the binary in .libs do not exist so the link is final in this case.
but in any case If you can come up with a patch to install it using
libtool that would be nice.

>
> Enrico
>
> Footnotes:
> [1]  info libtool -> Installing libraries + Installing executables
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


-- 
-Khem

Re: [PATCH] cacaoh: patches to get do_install do its work

[Enrico Scholz]

Khem Raj <raj.khem@gmail.com> writes:

>>>>> -    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>>>>> +    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
>>
>> * libtool creates sometimes a wrapper script for executables (e.g. when
>>   they are linked against local libraries) and places the real executable
>>   in .libs/.  Manually installing one of them is error prone and it might
>>   break with other linker flags or libtool versions.
>
> the binary in .libs do not exist so the link is final in this case.

Really?  The author of the original recipe had an environment where the
executable was in .libs/.  Are you really sure that such an environment
does not exist anymore? Or will the recipe now silently fail by installing
the shell wrapper sometimes?


> but in any case If you can come up with a patch to install it using
> libtool that would be nice.

Sorry; providing a patch means testing it (regardless whether it is
trivial).  Here, I am not sure whether 'libtool' or the platform
prefixed '<arch>-libtool' is required and how to express
'<arch>-libtool' in oe.

I gave my comment to a patch which fixed a broken recipe by replacing it
with another broken recipe.  So I expect that the author of this patch
fixes and tests his work.

For completeness; install command should be

| libtool --mode=install install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}



Enrico

Re: [PATCH] cacaoh: patches to get do_install do its work

[Stefan Schmidt]

Hello.

On Fri, 2010-10-22 at 10:11, Jaap de Jong wrote:
> From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
> From: Jaap de Jong <jaap.dejong@nedap.com>
> Date: Fri, 22 Oct 2010 09:28:25 +0200
> Subject: [PATCH] cacaoh: patches to get do_install do its work
> 
> Signed-off-by: Jaap de Jong <jaap.dejong@nedap.com>

This patch broke the openjdk-6 testing build for me. Openjdk did not compile due
to missing header files.

This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using
angstrom-2010 and therefor the 2.4 libtool?

I will start a fresh build on master instead testing-next now and then we need
to see how we could handle this regression.

regards
Stefan Schmidt

Re: [PATCH] cacaoh: patches to get do_install do its work

[Khem Raj]

On Wed, Oct 27, 2010 at 11:24 PM, Stefan Schmidt
<stefan@datenfreihafen.org> wrote:
> Hello.
>
> On Fri, 2010-10-22 at 10:11, Jaap de Jong wrote:
>> From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
>> From: Jaap de Jong <jaap.dejong@nedap.com>
>> Date: Fri, 22 Oct 2010 09:28:25 +0200
>> Subject: [PATCH] cacaoh: patches to get do_install do its work
>>
>> Signed-off-by: Jaap de Jong <jaap.dejong@nedap.com>
>
> This patch broke the openjdk-6 testing build for me. Openjdk did not compile due
> to missing header files.
>
> This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using
> angstrom-2010 and therefor the 2.4 libtool?
>

I tested it with both 2.2 ad 2.4 libtools but what Enrico suggested
might be a better fix.

> I will start a fresh build on master instead testing-next now and then we need
> to see how we could handle this regression.
>
> regards
> Stefan Schmidt
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] cacaoh: patches to get do_install do its work

[Stefan Schmidt]

Hello.

On Wed, 2010-10-27 at 23:36, Khem Raj wrote:
> On Wed, Oct 27, 2010 at 11:24 PM, Stefan Schmidt
> <stefan@datenfreihafen.org> wrote:
> >
> > On Fri, 2010-10-22 at 10:11, Jaap de Jong wrote:
> >> From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
> >> From: Jaap de Jong <jaap.dejong@nedap.com>
> >> Date: Fri, 22 Oct 2010 09:28:25 +0200
> >> Subject: [PATCH] cacaoh: patches to get do_install do its work
> >>
> >> Signed-off-by: Jaap de Jong <jaap.dejong@nedap.com>
> >
> > This patch broke the openjdk-6 testing build for me. Openjdk did not compile due
> > to missing header files.
> >
> > This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using
> > angstrom-2010 and therefor the 2.4 libtool?
> >
> 
> I tested it with both 2.2 ad 2.4 libtools but what Enrico suggested
> might be a better fix.

Hmm, that works against my theory. :)

I need to wait until my build on master is ready and if it fails as well I try
to implement Enricos suggestion.

regards
Stefan Schmidt

Re: [PATCH] cacaoh: patches to get do_install do its work

[Stefan Schmidt]

Hello.

On Tue, 2010-10-26 at 11:01, Enrico Scholz wrote:
> Khem Raj <raj.khem@gmail.com> writes:
> 
> >>>>> -    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
> >>>>> +    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
> >>
> >> * libtool creates sometimes a wrapper script for executables (e.g. when
> >>   they are linked against local libraries) and places the real executable
> >>   in .libs/.  Manually installing one of them is error prone and it might
> >>   break with other linker flags or libtool versions.
> >
> > the binary in .libs do not exist so the link is final in this case.
> 
> Really?  The author of the original recipe had an environment where the
> executable was in .libs/.  Are you really sure that such an environment
> does not exist anymore? Or will the recipe now silently fail by installing
> the shell wrapper sometimes?

For me it did silently fail. :)

The openjdk-6 build failed due to missing header files like
 exceptions.c:44:45: error: native/include/java_lang_String.h: No such file or directory

> > but in any case If you can come up with a patch to install it using
> > libtool that would be nice.
> 
> Sorry; providing a patch means testing it (regardless whether it is
> trivial).  Here, I am not sure whether 'libtool' or the platform
> prefixed '<arch>-libtool' is required and how to express
> '<arch>-libtool' in oe.
> 
> I gave my comment to a patch which fixed a broken recipe by replacing it
> with another broken recipe.  So I expect that the author of this patch
> fixes and tests his work.
> 
> For completeness; install command should be
> 
> | libtool --mode=install install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

Thanks. I implemented this and the build works fine again. Thanks for letting us
know. Will push it in when I have network connectivity again.

regards
Stefan Schmidt

Re: [PATCH] cacaoh: patches to get do_install do its work

[Jaap de Jong]

Hi,
my initial patch was only intended to show the error I got while 
building openjdk-6 and I hoped to trigger the maintainers to get it fixed.
If this patch has caused any inconvenience to anyone, I apologize for that.
Jaap

On 10/28/2010 09:44 AM, Stefan Schmidt wrote:
> Hello.
>
> On Wed, 2010-10-27 at 23:36, Khem Raj wrote:
>> On Wed, Oct 27, 2010 at 11:24 PM, Stefan Schmidt
>> <stefan@datenfreihafen.org>  wrote:
>>> On Fri, 2010-10-22 at 10:11, Jaap de Jong wrote:
>>>>  From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
>>>> From: Jaap de Jong<jaap.dejong@nedap.com>
>>>> Date: Fri, 22 Oct 2010 09:28:25 +0200
>>>> Subject: [PATCH] cacaoh: patches to get do_install do its work
>>>>
>>>> Signed-off-by: Jaap de Jong<jaap.dejong@nedap.com>
>>> This patch broke the openjdk-6 testing build for me. Openjdk did not compile due
>>> to missing header files.
>>>
>>> This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using
>>> angstrom-2010 and therefor the 2.4 libtool?
>>>
>> I tested it with both 2.2 ad 2.4 libtools but what Enrico suggested
>> might be a better fix.
> Hmm, that works against my theory. :)
>
> I need to wait until my build on master is ready and if it fails as well I try
> to implement Enricos suggestion.
>
> regards
> Stefan Schmidt
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [PATCH] cacaoh: patches to get do_install do its work

[Stefan Schmidt]

Hello.

On Thu, 2010-10-28 at 16:02, Jaap de Jong wrote:
>
> my initial patch was only intended to show the error I got while
> building openjdk-6 and I hoped to trigger the maintainers to get it
> fixed.
> If this patch has caused any inconvenience to anyone, I apologize for that.

Not a big deal. It broke for me, but thanks to Enricos and Khems hints I was
able to fix it for me. I'm pushing my fix right now. Testing on your setup would
be appreciated.

regards
Stefan Schmidt