[PATCH] dbus: use $(LIBTOOL) to install 'dbus-daemon'

[PATCH] dbus: use $(LIBTOOL) to install 'dbus-daemon'

[Enrico Scholz]

Depending on autotools/libtool version and configure flags, dbus-daemon
will be built sometimes below .libs/ and sometimes in base directory.

Using 'libtool --mode=install' is a portable way to deal with this.

Changing Makefile.am to use native automake methods to install this
files would be a better but more invasive fix.
---
 recipes/dbus/dbus-1.2.24/fix-install-daemon.patch |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/dbus/dbus-1.2.24/fix-install-daemon.patch b/recipes/dbus/dbus-1.2.24/fix-install-daemon.patch
index c317863..5e25d12 100644
--- a/recipes/dbus/dbus-1.2.24/fix-install-daemon.patch
+++ b/recipes/dbus/dbus-1.2.24/fix-install-daemon.patch
@@ -7,7 +7,7 @@ Index: dbus-0.94/bus/Makefile.am
  		chmod 755 $(DESTDIR)$(DBUS_DAEMONDIR); \
  	fi
 -	$(INSTALL_PROGRAM) dbus-daemon $(DESTDIR)$(DBUS_DAEMONDIR)
-+	$(INSTALL_PROGRAM) .libs/dbus-daemon $(DESTDIR)$(DBUS_DAEMONDIR)
++	$(LIBTOOL) --mode=install $(INSTALL_PROGRAM) dbus-daemon $(DESTDIR)$(DBUS_DAEMONDIR)
  	$(mkinstalldirs) $(DESTDIR)$(localstatedir)/run/dbus
  	$(mkinstalldirs) $(DESTDIR)$(configdir)/system.d
  	$(mkinstalldirs) $(DESTDIR)$(datadir)/dbus-1/services
-- 
1.7.0.1

Re: [PATCH] dbus: use $(LIBTOOL) to install 'dbus-daemon'

[Enrico Scholz]

Enrico Scholz <enrico.scholz@sigma-chemnitz.de> writes:

> Depending on autotools/libtool version and configure flags, dbus-daemon
> will be built sometimes below .libs/ and sometimes in base directory.
>
> Using 'libtool --mode=install' is a portable way to deal with this.
>
> Changing Makefile.am to use native automake methods to install this
> files would be a better but more invasive fix.

oops... forgot the

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>

Re: [PATCH] dbus: use $(LIBTOOL) to install 'dbus-daemon'

[Chris Larson]

On Wed, Apr 14, 2010 at 6:22 AM, Enrico Scholz <
enrico.scholz@sigma-chemnitz.de> wrote:

> Enrico Scholz <enrico.scholz@sigma-chemnitz.de> writes:
>
> > Depending on autotools/libtool version and configure flags, dbus-daemon
> > will be built sometimes below .libs/ and sometimes in base directory.
> >
> > Using 'libtool --mode=install' is a portable way to deal with this.
> >
> > Changing Makefile.am to use native automake methods to install this
> > files would be a better but more invasive fix.
>
> oops... forgot the
>
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
>

Looks reasonable.

Acked-by: Chris Larson <chris_larson@mentor.com>
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: [PATCH] dbus: use $(LIBTOOL) to install 'dbus-daemon'

[Sebastian Spaeth]

On 2010-04-14, Enrico Scholz wrote:
> Depending on autotools/libtool version and configure flags, dbus-daemon
> will be built sometimes below .libs/ and sometimes in base directory.
> 
> Using 'libtool --mode=install' is a portable way to deal with this.
> 
> Changing Makefile.am to use native automake methods to install this
> files would be a better but more invasive fix.

Looks reasonable, although I am always for going with the "better" fixes
in general :-)

Acked-by: Sebastian Spaeth <Sebastian@SSpaeth.de>

Re: [PATCH] dbus: use $(LIBTOOL) to install 'dbus-daemon'

[Enrico Scholz]

"Sebastian Spaeth" <Sebastian@SSpaeth.de> writes:

>> Changing Makefile.am to use native automake methods to install this
>> files would be a better but more invasive fix.
>
> Looks reasonable, although I am always for going with the "better" fixes
> in general :-)

I will work on a better patch which will be sent to upstream.  But I can
not say when I have time to work on it.


Enrico