[U-Boot] [PATCH] new default shortcut to config & build a board

[U-Boot] [PATCH] new default shortcut to config & build a board

[Mike Frysinger]

The majority of the time that I build things in U-Boot, I want to just
build for the board.  I don't make board config tweaks after selecting the
board.  So add a new pattern rule that allows people to combine two steps
in one go:
	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule
is used only the rule doesn't already exist.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 02393b6..bf45a0b 100644
--- a/Makefile
+++ b/Makefile
@@ -495,6 +495,10 @@ unconfig:
 		$(obj)board/*/config.tmp $(obj)board/*/*/config.tmp \
 		$(obj)include/autoconf.mk $(obj)include/autoconf.mk.dep
 
+%: %_config
+	$(MAKE) $@_config
+	$(MAKE)
+
 #========================================================================
 # PowerPC
 #========================================================================
@@ -3505,10 +3509,6 @@ BFIN_BOARDS += ibf-dsp561
 $(BFIN_BOARDS:%=%_config)	: unconfig
 	@$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=)
 
-$(BFIN_BOARDS):
-	$(MAKE) $@_config
-	$(MAKE)
-
 #========================================================================
 # AVR32
 #========================================================================
-- 
1.6.4

[U-Boot] [PATCH] new default shortcut to config & build a board

[Mike Frysinger]

On Monday 24 August 2009 17:28:26 Mike Frysinger wrote:
> The majority of the time that I build things in U-Boot, I want to just
> build for the board.  I don't make board config tweaks after selecting the
> board.  So add a new pattern rule that allows people to combine two steps
> in one go:
> 	`make foo_config && make` => `make foo`
> 
> This shouldn't conflict with any existing make rules as the pattern rule
> is used only the rule doesn't already exist.

ping
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091001/d7b45b83/attachment.pgp 

[U-Boot] [PATCH] new default shortcut to config & build a board

[Detlev Zundel]

Hi Mike,

> On Monday 24 August 2009 17:28:26 Mike Frysinger wrote:
>> The majority of the time that I build things in U-Boot, I want to just
>> build for the board.  I don't make board config tweaks after selecting the
>> board.  So add a new pattern rule that allows people to combine two steps
>> in one go:
>> 	`make foo_config && make` => `make foo`
>> 
>> This shouldn't conflict with any existing make rules as the pattern rule
>> is used only the rule doesn't already exist.

Hm, I just tried this patch and I see a strange behaviour:

[dzu at pollux u-boot-testing (mao-rd-hor)]$ make -s sequoia
Configuring for sequoia board...
Configuring for sequoia board...

It is not obvious for me why I get this message twice - all I verified
is that both messages are definitely from stdout only.

Apart from that, I don't see a reason why this should not go in.
Currently I use "./MAKEALL <board>" for the same purpose btw.

Cheers
  Detlev

-- 
If we knew what it was we were doing, we wouldn't call it research.
                                            -- Einstein
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

[U-Boot] [PATCH] new default shortcut to config & build a board

[Luigi Mantellini]

On Mon, Aug 24, 2009 at 11:28 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>
> +%: %_config
> + ? ? ? $(MAKE) $@_config <--- Delete this, because the %_config already calls the target config block

> + ? ? ? $(MAKE)
> +


best regards,

luigi


-- 
Luigi 'Comio' Mantellini
R&D - Software
Industrie Dial Face S.p.A.
Via Canzo, 4
20068 Peschiera Borromeo (MI), Italy

Tel.: +39 02 5167 2813
Fax: +39 02 5167 2459
web: www.idf-hit.com
mail: luigi.mantellini at idf-hit.com

[U-Boot] [PATCH v2] new default shortcut to config & build a board

[Mike Frysinger]

The majority of the time that I build things in U-Boot, I want to just
build for the board.  I don't make board config tweaks after selecting the
board.  So add a new pattern rule that allows people to combine two steps
in one go:
	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule
is used only the rule doesn't already exist.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
	- fix duplicate config left over from original code pointed out by Luigi

 Makefile |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 9c5b2a5..15363b8 100644
--- a/Makefile
+++ b/Makefile
@@ -501,6 +501,9 @@ unconfig:
 		$(obj)board/*/config.tmp $(obj)board/*/*/config.tmp \
 		$(obj)include/autoconf.mk $(obj)include/autoconf.mk.dep
 
+%: %_config
+	$(MAKE)
+
 #========================================================================
 # PowerPC
 #========================================================================
@@ -3525,10 +3528,6 @@ BFIN_BOARDS += ibf-dsp561
 $(BFIN_BOARDS:%=%_config)	: unconfig
 	@$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=)
 
-$(BFIN_BOARDS):
-	$(MAKE) $@_config
-	$(MAKE)
-
 #========================================================================
 # AVR32
 #========================================================================
-- 
1.6.5.rc2

[U-Boot] [PATCH v2] new default shortcut to config & build a board

[Wolfgang Denk]

Dear Mike Frysinger,

In message <1254413514-12564-1-git-send-email-vapier@gentoo.org> you wrote:
> The majority of the time that I build things in U-Boot, I want to just
> build for the board.  I don't make board config tweaks after selecting the
> board.  So add a new pattern rule that allows people to combine two steps
> in one go:
> 	`make foo_config && make` => `make foo`
> 
> This shouldn't conflict with any existing make rules as the pattern rule
> is used only the rule doesn't already exist.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> v2
> 	- fix duplicate config left over from original code pointed out by Luigi
> 
>  Makefile |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Die meisten Menschen pflegen im Kindesalter vom Zeigen auf Gegenst?n-
de (Mausbewegung) und "ga" sagen  (Mausklick)  abzukommen,  zugunsten
eines  m?chtigeren  und langwierig zu erlernenden Tools (Sprache).
                             -- Achim Linder in de.comp.os.linux.misc