From: Chris Ball <cjb@laptop.org>
To: Will Newton <will.newton@gmail.com>
Cc: James Hogan <james.hogan@imgtec.com>,
Shashidhar Hiremath <shashidharh@vayavyalabs.com>,
Will Newton <will.newton@imgtec.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c
Date: Fri, 29 Jul 2011 08:53:00 -0400 [thread overview]
Message-ID: <m2ei19ckpf.fsf@bob.laptop.org> (raw)
In-Reply-To: <CAFbHwiS9ESqXbHF8EnfMaMdR3JNCW+sPEtaAJvL0ptBY1OsFkQ@mail.gmail.com> (Will Newton's message of "Fri, 29 Jul 2011 11:07:09 +0100")
Hi Shashidhar,
On Fri, Jul 29 2011, Will Newton wrote:
>>> The mask used inside this macro was assuming Buffer_Size1's[BS1's]
>>> width to be 14 bits,
>>> it is actually of 13 bits, Modified masks used in
>>> IDMAC_SET_BUFFER1_SIZE such that
>>> they use only 13 bits instead of current 14.
>>>
>>> Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com>
>
> Yes, looks correct to me too (for some reason I didn't get the original mail).
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Pushed to mmc-next for 3.1, thanks.
(I didn't get the original mail either; it looks like the mailing lists
rejected it for some reason.)
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-07-29 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1311851023-3563-1-git-send-email-shashidharh@vayavyalabs.com>
2011-07-28 11:17 ` [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c James Hogan
2011-07-29 2:17 ` Jaehoon Chung
2011-07-29 6:51 ` Jaehoon Chung
2011-07-29 6:51 ` Jaehoon Chung
2011-07-29 10:07 ` Will Newton
2011-07-29 12:53 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ei19ckpf.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shashidharh@vayavyalabs.com \
--cc=will.newton@gmail.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.