All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
@ 2011-10-29 19:39 Juergen Kilb
  2011-10-29 20:04 ` Chris Ball
  0 siblings, 1 reply; 5+ messages in thread
From: Juergen Kilb @ 2011-10-29 19:39 UTC (permalink / raw)
  To: Chris Ball, linux-mmc; +Cc: Girish K S, linux-omap, Juergen Kilb

In commit a3c76eb9 (mmc: replace printk with appropriate
display macro) the opening parenthesis of pr_info was missing.

Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
---
 drivers/mmc/host/omap_hsmmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index e8ff123..101cd31 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
 		}
 	} else {
 		if (!host->protect_card) {
-			pr_info"%s: cover is open, "
+			pr_info("%s: cover is open, "
 					 "card is now inaccessible\n",
 					 mmc_hostname(host->mmc));
 			host->protect_card = 1;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
  2011-10-29 19:39 [PATCH] omap_hsmmc: fix missing parenthesis in pr_info Juergen Kilb
@ 2011-10-29 20:04 ` Chris Ball
  2011-11-02 23:59   ` Kevin Hilman
  0 siblings, 1 reply; 5+ messages in thread
From: Chris Ball @ 2011-10-29 20:04 UTC (permalink / raw)
  To: Juergen Kilb; +Cc: linux-mmc, Girish K S, linux-omap

Hi,

On Sat, Oct 29 2011, Juergen Kilb wrote:
> In commit a3c76eb9 (mmc: replace printk with appropriate
> display macro) the opening parenthesis of pr_info was missing.
>
> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
> ---
>  drivers/mmc/host/omap_hsmmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index e8ff123..101cd31 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
>  		}
>  	} else {
>  		if (!host->protect_card) {
> -			pr_info"%s: cover is open, "
> +			pr_info("%s: cover is open, "
>  					 "card is now inaccessible\n",
>  					 mmc_hostname(host->mmc));
>  			host->protect_card = 1;

Oops.  Thank you; I've pushed this to mmc-next now, and will send the
fix to Linus.  I've checked for other errors in the original patch.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
  2011-10-29 20:04 ` Chris Ball
@ 2011-11-02 23:59   ` Kevin Hilman
  2011-11-03  8:10     ` S, Venkatraman
  0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2011-11-02 23:59 UTC (permalink / raw)
  To: Chris Ball; +Cc: Juergen Kilb, linux-mmc, Girish K S, linux-omap

Hi Chris,

Chris Ball <cjb@laptop.org> writes:

[...]

> Oops.  Thank you; I've pushed this to mmc-next now, and will send the
> fix to Linus.  I've checked for other errors in the original patch.

Where did you push this fix?

I don't see this in the mmc-next branch of git://dev.laptop.org/users/cjb/mmc

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
  2011-11-02 23:59   ` Kevin Hilman
@ 2011-11-03  8:10     ` S, Venkatraman
  2011-11-03 10:42       ` Chris Ball
  0 siblings, 1 reply; 5+ messages in thread
From: S, Venkatraman @ 2011-11-03  8:10 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: Chris Ball, Juergen Kilb, linux-mmc, Girish K S, linux-omap

On Thu, Nov 3, 2011 at 5:29 AM, Kevin Hilman <khilman@ti.com> wrote:
> Hi Chris,
>
> Chris Ball <cjb@laptop.org> writes:
>
> [...]
>
>> Oops.  Thank you; I've pushed this to mmc-next now, and will send the
>> fix to Linus.  I've checked for other errors in the original patch.
>
> Where did you push this fix?
>
> I don't see this in the mmc-next branch of git://dev.laptop.org/users/cjb/mmc
>
MMC tree is back to kernel.org
http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=summary

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
  2011-11-03  8:10     ` S, Venkatraman
@ 2011-11-03 10:42       ` Chris Ball
  0 siblings, 0 replies; 5+ messages in thread
From: Chris Ball @ 2011-11-03 10:42 UTC (permalink / raw)
  To: S, Venkatraman
  Cc: Kevin Hilman, Juergen Kilb, linux-mmc, Girish K S, linux-omap

Hi,

On Thu, Nov 03 2011, S, Venkatraman wrote:
>>> Oops.  Thank you; I've pushed this to mmc-next now, and will send the
>>> fix to Linus.  I've checked for other errors in the original patch.
>>
>> Where did you push this fix?
>>
>> I don't see this in the mmc-next branch of git://dev.laptop.org/users/cjb/mmc
>>
> MMC tree is back to kernel.org
> http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=summary

I've deleted the dev.laptop.org mmc tree now, so that there's a clue
that it's moved back to kernel.org.  (linux-next is already back to
pulling the kernel.org tree.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-11-03 10:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-29 19:39 [PATCH] omap_hsmmc: fix missing parenthesis in pr_info Juergen Kilb
2011-10-29 20:04 ` Chris Ball
2011-11-02 23:59   ` Kevin Hilman
2011-11-03  8:10     ` S, Venkatraman
2011-11-03 10:42       ` Chris Ball

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.