* [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
@ 2013-07-19 8:24 ` Gu Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Gu Zheng @ 2013-07-19 8:24 UTC (permalink / raw)
To: Kim; +Cc: f2fs, linux-kernel
As we remove the target single node, so list_for_each is enought, in order to
clean up, we use list_for_each_entry instead.
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
---
fs/f2fs/checkpoint.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 290db04..87f7bc2 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -237,13 +237,12 @@ out:
void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
{
- struct list_head *this, *next, *head;
+ struct list_head *head;
struct orphan_inode_entry *orphan;
mutex_lock(&sbi->orphan_inode_mutex);
head = &sbi->orphan_inode_list;
- list_for_each_safe(this, next, head) {
- orphan = list_entry(this, struct orphan_inode_entry, list);
+ list_for_each_entry(orphan, head, list) {
if (orphan->ino == ino) {
list_del(&orphan->list);
kmem_cache_free(orphan_entry_slab, orphan);
--
1.7.7
^ permalink raw reply related [flat|nested] 8+ messages in thread* [f2fs-dev] [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
@ 2013-07-19 8:24 ` Gu Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Gu Zheng @ 2013-07-19 8:24 UTC (permalink / raw)
To: Kim; +Cc: linux-kernel, f2fs
As we remove the target single node, so list_for_each is enought, in order to
clean up, we use list_for_each_entry instead.
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
---
fs/f2fs/checkpoint.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 290db04..87f7bc2 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -237,13 +237,12 @@ out:
void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
{
- struct list_head *this, *next, *head;
+ struct list_head *head;
struct orphan_inode_entry *orphan;
mutex_lock(&sbi->orphan_inode_mutex);
head = &sbi->orphan_inode_list;
- list_for_each_safe(this, next, head) {
- orphan = list_entry(this, struct orphan_inode_entry, list);
+ list_for_each_entry(orphan, head, list) {
if (orphan->ino == ino) {
list_del(&orphan->list);
kmem_cache_free(orphan_entry_slab, orphan);
--
1.7.7
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
2013-07-19 8:24 ` [f2fs-dev] " Gu Zheng
@ 2013-07-22 15:36 ` Nikola Pajkovsky
-1 siblings, 0 replies; 8+ messages in thread
From: Nikola Pajkovsky @ 2013-07-22 15:36 UTC (permalink / raw)
To: Gu Zheng; +Cc: Kim, f2fs, linux-kernel
Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
> As we remove the target single node, so list_for_each is enought, in order to
> clean up, we use list_for_each_entry instead.
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/f2fs/checkpoint.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 290db04..87f7bc2 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -237,13 +237,12 @@ out:
>
> void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
> {
> - struct list_head *this, *next, *head;
> + struct list_head *head;
> struct orphan_inode_entry *orphan;
>
> mutex_lock(&sbi->orphan_inode_mutex);
> head = &sbi->orphan_inode_list;
> - list_for_each_safe(this, next, head) {
> - orphan = list_entry(this, struct orphan_inode_entry, list);
> + list_for_each_entry(orphan, head, list) {
> if (orphan->ino == ino) {
> list_del(&orphan->list);
> kmem_cache_free(orphan_entry_slab, orphan);
you have meant list_for_each_entry_safe, haven't you?
--
Nikola
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
@ 2013-07-22 15:36 ` Nikola Pajkovsky
0 siblings, 0 replies; 8+ messages in thread
From: Nikola Pajkovsky @ 2013-07-22 15:36 UTC (permalink / raw)
To: Gu Zheng; +Cc: linux-kernel, f2fs
Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
> As we remove the target single node, so list_for_each is enought, in order to
> clean up, we use list_for_each_entry instead.
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/f2fs/checkpoint.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 290db04..87f7bc2 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -237,13 +237,12 @@ out:
>
> void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
> {
> - struct list_head *this, *next, *head;
> + struct list_head *head;
> struct orphan_inode_entry *orphan;
>
> mutex_lock(&sbi->orphan_inode_mutex);
> head = &sbi->orphan_inode_list;
> - list_for_each_safe(this, next, head) {
> - orphan = list_entry(this, struct orphan_inode_entry, list);
> + list_for_each_entry(orphan, head, list) {
> if (orphan->ino == ino) {
> list_del(&orphan->list);
> kmem_cache_free(orphan_entry_slab, orphan);
you have meant list_for_each_entry_safe, haven't you?
--
Nikola
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
2013-07-22 15:36 ` [f2fs-dev] " Nikola Pajkovsky
@ 2013-07-23 1:06 ` Gu Zheng
-1 siblings, 0 replies; 8+ messages in thread
From: Gu Zheng @ 2013-07-23 1:06 UTC (permalink / raw)
To: Nikola Pajkovsky; +Cc: Kim, f2fs, linux-kernel
On 07/22/2013 11:36 PM, Nikola Pajkovsky wrote:
> Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>
>> As we remove the target single node, so list_for_each is enought, in order to
>> clean up, we use list_for_each_entry instead.
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>> ---
>> fs/f2fs/checkpoint.c | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 290db04..87f7bc2 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -237,13 +237,12 @@ out:
>>
>> void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
>> {
>> - struct list_head *this, *next, *head;
>> + struct list_head *head;
>> struct orphan_inode_entry *orphan;
>>
>> mutex_lock(&sbi->orphan_inode_mutex);
>> head = &sbi->orphan_inode_list;
>> - list_for_each_safe(this, next, head) {
>> - orphan = list_entry(this, struct orphan_inode_entry, list);
>> + list_for_each_entry(orphan, head, list) {
>> if (orphan->ino == ino) {
>> list_del(&orphan->list);
>> kmem_cache_free(orphan_entry_slab, orphan);
>
> you have meant list_for_each_entry_safe, haven't you?
No that, here list_for_each_entry is suitable, because we delete only one entry.
Thanks,
Gu
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
@ 2013-07-23 1:06 ` Gu Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Gu Zheng @ 2013-07-23 1:06 UTC (permalink / raw)
To: Nikola Pajkovsky; +Cc: linux-kernel, f2fs
On 07/22/2013 11:36 PM, Nikola Pajkovsky wrote:
> Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>
>> As we remove the target single node, so list_for_each is enought, in order to
>> clean up, we use list_for_each_entry instead.
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>> ---
>> fs/f2fs/checkpoint.c | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 290db04..87f7bc2 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -237,13 +237,12 @@ out:
>>
>> void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
>> {
>> - struct list_head *this, *next, *head;
>> + struct list_head *head;
>> struct orphan_inode_entry *orphan;
>>
>> mutex_lock(&sbi->orphan_inode_mutex);
>> head = &sbi->orphan_inode_list;
>> - list_for_each_safe(this, next, head) {
>> - orphan = list_entry(this, struct orphan_inode_entry, list);
>> + list_for_each_entry(orphan, head, list) {
>> if (orphan->ino == ino) {
>> list_del(&orphan->list);
>> kmem_cache_free(orphan_entry_slab, orphan);
>
> you have meant list_for_each_entry_safe, haven't you?
No that, here list_for_each_entry is suitable, because we delete only one entry.
Thanks,
Gu
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
2013-07-23 1:06 ` [f2fs-dev] " Gu Zheng
@ 2013-07-23 7:34 ` Nikola Pajkovsky
-1 siblings, 0 replies; 8+ messages in thread
From: Nikola Pajkovsky @ 2013-07-23 7:34 UTC (permalink / raw)
To: Gu Zheng; +Cc: Kim, f2fs, linux-kernel
Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
> On 07/22/2013 11:36 PM, Nikola Pajkovsky wrote:
>
>> Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>>
>>> As we remove the target single node, so list_for_each is enought, in order to
>>> clean up, we use list_for_each_entry instead.
>>>
>>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>>> ---
>>> fs/f2fs/checkpoint.c | 5 ++---
>>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>>> index 290db04..87f7bc2 100644
>>> --- a/fs/f2fs/checkpoint.c
>>> +++ b/fs/f2fs/checkpoint.c
>>> @@ -237,13 +237,12 @@ out:
>>>
>>> void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
>>> {
>>> - struct list_head *this, *next, *head;
>>> + struct list_head *head;
>>> struct orphan_inode_entry *orphan;
>>>
>>> mutex_lock(&sbi->orphan_inode_mutex);
>>> head = &sbi->orphan_inode_list;
>>> - list_for_each_safe(this, next, head) {
>>> - orphan = list_entry(this, struct orphan_inode_entry, list);
>>> + list_for_each_entry(orphan, head, list) {
>>> if (orphan->ino == ino) {
>>> list_del(&orphan->list);
>>> kmem_cache_free(orphan_entry_slab, orphan);
>>
>> you have meant list_for_each_entry_safe, haven't you?
>
> No that, here list_for_each_entry is suitable, because we delete only one entry.
yeah, you're correct.
--
Nikola
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()
@ 2013-07-23 7:34 ` Nikola Pajkovsky
0 siblings, 0 replies; 8+ messages in thread
From: Nikola Pajkovsky @ 2013-07-23 7:34 UTC (permalink / raw)
To: Gu Zheng; +Cc: linux-kernel, f2fs
Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
> On 07/22/2013 11:36 PM, Nikola Pajkovsky wrote:
>
>> Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>>
>>> As we remove the target single node, so list_for_each is enought, in order to
>>> clean up, we use list_for_each_entry instead.
>>>
>>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>>> ---
>>> fs/f2fs/checkpoint.c | 5 ++---
>>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>>> index 290db04..87f7bc2 100644
>>> --- a/fs/f2fs/checkpoint.c
>>> +++ b/fs/f2fs/checkpoint.c
>>> @@ -237,13 +237,12 @@ out:
>>>
>>> void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
>>> {
>>> - struct list_head *this, *next, *head;
>>> + struct list_head *head;
>>> struct orphan_inode_entry *orphan;
>>>
>>> mutex_lock(&sbi->orphan_inode_mutex);
>>> head = &sbi->orphan_inode_list;
>>> - list_for_each_safe(this, next, head) {
>>> - orphan = list_entry(this, struct orphan_inode_entry, list);
>>> + list_for_each_entry(orphan, head, list) {
>>> if (orphan->ino == ino) {
>>> list_del(&orphan->list);
>>> kmem_cache_free(orphan_entry_slab, orphan);
>>
>> you have meant list_for_each_entry_safe, haven't you?
>
> No that, here list_for_each_entry is suitable, because we delete only one entry.
yeah, you're correct.
--
Nikola
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-07-23 7:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-19 8:24 [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode() Gu Zheng
2013-07-19 8:24 ` [f2fs-dev] " Gu Zheng
2013-07-22 15:36 ` Nikola Pajkovsky
2013-07-22 15:36 ` [f2fs-dev] " Nikola Pajkovsky
2013-07-23 1:06 ` Gu Zheng
2013-07-23 1:06 ` [f2fs-dev] " Gu Zheng
2013-07-23 7:34 ` Nikola Pajkovsky
2013-07-23 7:34 ` [f2fs-dev] " Nikola Pajkovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.