[TRIVIAL] [PATCH] generic HDLC Cisco bugfix

[TRIVIAL] [PATCH] generic HDLC Cisco bugfix

[Krzysztof Halasa]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

Hi,

The attached patch fixes transmitted headers with generic HDLC + Cisco
encapsulation. Please apply. Thanks.
-- 
Krzysztof Halasa, B*FH

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hdlc-2.6.0test7.patch --]
[-- Type: text/x-patch, Size: 445 bytes --]

--- linux-2.6.orig/drivers/net/wan/hdlc_cisco.c	2003-08-09 06:34:37.000000000 +0200
+++ linux-2.6/drivers/net/wan/hdlc_cisco.c	2003-10-09 23:40:00.000000000 +0200
@@ -311,7 +311,9 @@
 		hdlc->proto.id = IF_PROTO_CISCO;
 		dev->hard_start_xmit = hdlc->xmit;
 		dev->hard_header = cisco_hard_header;
+		dev->hard_header_cache = NULL;
 		dev->type = ARPHRD_CISCO;
+		dev->flags = IFF_POINTOPOINT | IFF_NOARP;
 		dev->addr_len = 0;
 		return 0;
 	}

Re: [TRIVIAL] [PATCH] generic HDLC Cisco bugfix

[David S. Miller]

Applied.

Please, Krzysztof, linux-kernel and Linus are not the appropriate
place to submit networking (device driver or otherwise) patches.

Therefore, in the future send it to netdev@oss.sgi.com and CC: either
Jeff Garzik or myself, thanks.

I'd also not classify this patch as trivial, it's not like a missing
semicolon or a comment typo, real thought needs to be applied to
analyzing whether your fix were correct or not.

Re: [TRIVIAL] [PATCH] generic HDLC Cisco bugfix

[Jens Axboe]

On Thu, Oct 09 2003, David S. Miller wrote:
> I'd also not classify this patch as trivial, it's not like a missing
> semicolon or a comment typo, real thought needs to be applied to
> analyzing whether your fix were correct or not.

This seems to be a general problem with the trivial patchbot, people
mistake small for trivial.

-- 
Jens Axboe

Re: [TRIVIAL] [PATCH] generic HDLC Cisco bugfix

[David S. Miller]

On Fri, 10 Oct 2003 16:56:00 +0100
Kevin Curtis <kevin.curtis@farsite.co.uk> wrote:

> Is this only for 2.6.x or does it also include 2.4.x and 2.2.x
> I ask this because I will need to submit a patch for the farsync WAN drivers
> soon which will need to be applied to all three kernels.

For 2.4.x too, yes.  As for 2.2.x I want nothing to do with
that tree, and it's in "OOPS fixers only" mode these days.

RE: [TRIVIAL] [PATCH] generic HDLC Cisco bugfix

[Kevin Curtis]

Is this only for 2.6.x or does it also include 2.4.x and 2.2.x
I ask this because I will need to submit a patch for the farsync WAN drivers
soon which will need to be applied to all three kernels.

Regards

Kevin

-----Original Message-----
From: David S. Miller [mailto:davem@redhat.com] 
Sent: 10 October 2003 07:44
To: Krzysztof Halasa
Cc: torvalds@osdl.org; linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL] [PATCH] generic HDLC Cisco bugfix



Applied.

Please, Krzysztof, linux-kernel and Linus are not the appropriate place to
submit networking (device driver or otherwise) patches.

Therefore, in the future send it to netdev@oss.sgi.com and CC: either Jeff
Garzik or myself, thanks.

I'd also not classify this patch as trivial, it's not like a missing
semicolon or a comment typo, real thought needs to be applied to analyzing
whether your fix were correct or not.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/