From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 08/13] qdev: Decouple qdev_prop_drive from DriveInfo
Date: Fri, 04 Jun 2010 10:22:38 +0200 [thread overview]
Message-ID: <m3ljav6wc1.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <4C06B0E5.6010603@redhat.com> (Gerd Hoffmann's message of "Wed, 02 Jun 2010 21:28:37 +0200")
Gerd Hoffmann <kraxel@redhat.com> writes:
> Hi,
>
>> +static void free_drive(DeviceState *dev, Property *prop)
>> +{
>> + BlockDriverState **ptr = qdev_get_prop_ptr(dev, prop);
>> +
>> + if (*ptr) {
>> + blockdev_detach(*ptr, dev);
>> + }
>> +}
>
>> @@ -1043,26 +1043,26 @@ static void scsi_destroy(SCSIDevice *dev)
>> SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, dev);
>>
>> scsi_disk_purge_requests(s);
>> - drive_uninit(s->qdev.conf.dinfo);
>> }
>
> Neat. Commit message should better explain that though.
Point. I'll try to improve it.
next prev parent reply other threads:[~2010-06-04 8:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 16:55 [Qemu-devel] [PATCH 00/13] New -blockdev to define a host block device Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 01/13] block: Move error actions from DriveInfo to BlockDriverState Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 02/13] block: Decouple block device "commit all" from DriveInfo Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 03/13] monitor: Make "commit FOO" complain when FOO doesn't exist Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 04/13] block: New bdrv_next() Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 05/13] block: Decouple savevm from DriveInfo Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 06/13] blockdev: Give drives internal linkage Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 07/13] blockdev: Means to destroy blockdev only if made with drive_init() Markus Armbruster
2010-06-10 14:19 ` [Qemu-devel] " Kevin Wolf
2010-06-10 16:00 ` Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 08/13] qdev: Decouple qdev_prop_drive from DriveInfo Markus Armbruster
2010-06-02 19:28 ` [Qemu-devel] " Gerd Hoffmann
2010-06-04 8:22 ` Markus Armbruster [this message]
2010-06-02 16:55 ` [Qemu-devel] [PATCH 09/13] blockdev: drive_get_by_id() is no longer used, remove Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 10/13] qemu-option: New qemu_opts_reset() Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 11/13] qemu-option: New qemu_opt_next(), qemu_opt_name() Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 12/13] blockdev: Factor option value parsers out of drive_init() Markus Armbruster
2010-06-02 16:55 ` [Qemu-devel] [PATCH 13/13] blockdev: New -blockdev to define a host block device Markus Armbruster
2010-06-03 8:00 ` Christoph Hellwig
2010-06-04 8:23 ` Markus Armbruster
2010-06-10 15:32 ` [Qemu-devel] " Paolo Bonzini
2010-06-10 16:32 ` Markus Armbruster
2010-06-10 17:03 ` Paolo Bonzini
2010-06-14 14:46 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljav6wc1.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.