* [PATCH] fix checkpoint header exports
@ 2009-06-15 5:10 Nathan Lynch
[not found] ` <m37hze2ib6.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Lynch @ 2009-06-15 5:10 UTC (permalink / raw)
To: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
checkpoint_types.h is not useful to userspace. Unexport it.
checkpoint.h contains definitions that userspace needs. Export it.
user-cr can now be built against exported headers.
Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
---
(against ckpt-v16-x86 as of a couple days ago; git.ncl.cs.columbia.edu
appears unresponsive atm)
include/linux/Kbuild | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 25b7c0e..df43556 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -44,7 +44,7 @@ header-y += bpqether.h
header-y += bsg.h
header-y += can.h
header-y += cdk.h
-header-y += checkpoint_types.h
+header-y += checkpoint.h
header-y += checkpoint_hdr.h
header-y += chio.h
header-y += coda_psdev.h
--
1.6.0.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fix checkpoint header exports
[not found] ` <m37hze2ib6.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
@ 2009-06-15 19:54 ` Oren Laadan
2009-06-20 1:10 ` Sukadev Bhattiprolu
1 sibling, 0 replies; 4+ messages in thread
From: Oren Laadan @ 2009-06-15 19:54 UTC (permalink / raw)
To: Nathan Lynch; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Thanks, will apply.
git.ncl.cs.columbia.edu was down due to departmental network
issues. It's back to life.
Oren.
Nathan Lynch wrote:
> checkpoint_types.h is not useful to userspace. Unexport it.
>
> checkpoint.h contains definitions that userspace needs. Export it.
>
> user-cr can now be built against exported headers.
>
> Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
>
> ---
>
> (against ckpt-v16-x86 as of a couple days ago; git.ncl.cs.columbia.edu
> appears unresponsive atm)
>
> include/linux/Kbuild | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index 25b7c0e..df43556 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -44,7 +44,7 @@ header-y += bpqether.h
> header-y += bsg.h
> header-y += can.h
> header-y += cdk.h
> -header-y += checkpoint_types.h
> +header-y += checkpoint.h
> header-y += checkpoint_hdr.h
> header-y += chio.h
> header-y += coda_psdev.h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix checkpoint header exports
[not found] ` <m37hze2ib6.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-15 19:54 ` Oren Laadan
@ 2009-06-20 1:10 ` Sukadev Bhattiprolu
[not found] ` <20090620011005.GA3890-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Sukadev Bhattiprolu @ 2009-06-20 1:10 UTC (permalink / raw)
To: Nathan Lynch; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Nathan Lynch [ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org] wrote:
| checkpoint_types.h is not useful to userspace. Unexport it.
Hmm, I get this error when compiling ckpt-v16-dev when compiling for x86
home/suka/containers/build/linux-cr/usr/include/linux/fs.h:11: included
file 'linux/checkpoint_types.h' is not exported
(did not get this error on another machine).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix checkpoint header exports
[not found] ` <20090620011005.GA3890-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2009-06-20 4:34 ` Nathan Lynch
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Lynch @ 2009-06-20 4:34 UTC (permalink / raw)
To: Sukadev Bhattiprolu
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> writes:
> Nathan Lynch [ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org] wrote:
> | checkpoint_types.h is not useful to userspace. Unexport it.
>
> Hmm, I get this error when compiling ckpt-v16-dev when compiling for x86
>
> home/suka/containers/build/linux-cr/usr/include/linux/fs.h:11: included
> file 'linux/checkpoint_types.h' is not exported
Sorry. I neglected to run make headers_check with this change, which
would have caught this. Will fix this soon -- you can add
checkpoint_types.h back to headers-y to work around this, I think.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-20 4:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-15 5:10 [PATCH] fix checkpoint header exports Nathan Lynch
[not found] ` <m37hze2ib6.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-15 19:54 ` Oren Laadan
2009-06-20 1:10 ` Sukadev Bhattiprolu
[not found] ` <20090620011005.GA3890-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-20 4:34 ` Nathan Lynch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.