All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] net: Use dma_pool_zalloc()
       [not found] <20180216162849.GA10860@jordon-HP-15-Notebook-PC>
@ 2018-03-06 20:53 ` Souptick Joarder
  2018-03-08 13:45   ` Krzysztof Hałasa
  0 siblings, 1 reply; 3+ messages in thread
From: Souptick Joarder @ 2018-03-06 20:53 UTC (permalink / raw)
  To: Krzysztof Hałasa, netdev

Any comment for this patch.

On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +--
>  drivers/net/wan/ixp4xx_hss.c             | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> index aee55c0..5710ae8 100644
> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> @@ -1108,10 +1108,9 @@ static int init_queues(struct port *port)
>                         return -ENOMEM;
>         }
>
> -       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
> +       if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
>                                               &port->desc_tab_phys)))
>                 return -ENOMEM;
> -       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
>         memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
>         memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
>
> diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
> index 6a505c2..0caffbf 100644
> --- a/drivers/net/wan/ixp4xx_hss.c
> +++ b/drivers/net/wan/ixp4xx_hss.c
> @@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
>                         return -ENOMEM;
>         }
>
> -       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
> +       if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
>                                               &port->desc_tab_phys)))
>                 return -ENOMEM;
> -       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
>         memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
>         memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
>
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] net: Use dma_pool_zalloc()
  2018-03-06 20:53 ` [PATCH] net: Use dma_pool_zalloc() Souptick Joarder
@ 2018-03-08 13:45   ` Krzysztof Hałasa
  2018-03-08 14:32     ` Souptick Joarder
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Hałasa @ 2018-03-08 13:45 UTC (permalink / raw)
  To: Souptick Joarder; +Cc: netdev

Souptick Joarder <jrdr.linux@gmail.com> writes:

> Any comment for this patch.

I thought something like this was already aplied.

Acked-by: Krzysztof Halasa <khalasa@piap.pl>

> On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> ---
>>  drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +--
>>  drivers/net/wan/ixp4xx_hss.c             | 3 +--
>>  2 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
>> index aee55c0..5710ae8 100644
>> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
>> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
>> @@ -1108,10 +1108,9 @@ static int init_queues(struct port *port)
>>                         return -ENOMEM;
>>         }
>>
>> -       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
>> +       if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
>>                                               &port->desc_tab_phys)))
>>                 return -ENOMEM;
>> -       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
>>         memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
>>         memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
>>
>> diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
>> index 6a505c2..0caffbf 100644
>> --- a/drivers/net/wan/ixp4xx_hss.c
>> +++ b/drivers/net/wan/ixp4xx_hss.c
>> @@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
>>                         return -ENOMEM;
>>         }
>>
>> -       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
>> +       if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
>>                                               &port->desc_tab_phys)))
>>                 return -ENOMEM;
>> -       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
>>         memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
>>         memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
>>

-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] net: Use dma_pool_zalloc()
  2018-03-08 13:45   ` Krzysztof Hałasa
@ 2018-03-08 14:32     ` Souptick Joarder
  0 siblings, 0 replies; 3+ messages in thread
From: Souptick Joarder @ 2018-03-08 14:32 UTC (permalink / raw)
  To: Krzysztof Hałasa; +Cc: netdev

On Thu, Mar 8, 2018 at 7:15 PM, Krzysztof Hałasa <khalasa@piap.pl> wrote:
> Souptick Joarder <jrdr.linux@gmail.com> writes:
>
>> Any comment for this patch.
>
> I thought something like this was already aplied.

I am not seeing anything similar till 4.16-rc4.
Is it going to merge in netdev git ?

>
> Acked-by: Krzysztof Halasa <khalasa@piap.pl>
>
>> On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>>> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>> ---
>>>  drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +--
>>>  drivers/net/wan/ixp4xx_hss.c             | 3 +--
>>>  2 files changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
>>> index aee55c0..5710ae8 100644
>>> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
>>> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
>>> @@ -1108,10 +1108,9 @@ static int init_queues(struct port *port)
>>>                         return -ENOMEM;
>>>         }
>>>
>>> -       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
>>> +       if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
>>>                                               &port->desc_tab_phys)))
>>>                 return -ENOMEM;
>>> -       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
>>>         memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
>>>         memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
>>>
>>> diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
>>> index 6a505c2..0caffbf 100644
>>> --- a/drivers/net/wan/ixp4xx_hss.c
>>> +++ b/drivers/net/wan/ixp4xx_hss.c
>>> @@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
>>>                         return -ENOMEM;
>>>         }
>>>
>>> -       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
>>> +       if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
>>>                                               &port->desc_tab_phys)))
>>>                 return -ENOMEM;
>>> -       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
>>>         memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
>>>         memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
>>>
>
> --
> Krzysztof Halasa
>
> Industrial Research Institute for Automation and Measurements PIAP
> Al. Jerozolimskie 202, 02-486 Warsaw, Poland

-Souptick

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-08 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20180216162849.GA10860@jordon-HP-15-Notebook-PC>
2018-03-06 20:53 ` [PATCH] net: Use dma_pool_zalloc() Souptick Joarder
2018-03-08 13:45   ` Krzysztof Hałasa
2018-03-08 14:32     ` Souptick Joarder

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.