No subject

[<bogus@does.not.exist.com>]

wakeup" patch is missing.

Regards,
Rajeshwari Shinde.


On Sun, May 12, 2013 at 12:09 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Rajeshwari,
>
> On Wed, Apr 24, 2013 at 11:57 PM, Rajeshwari Shinde
> <rajeshwari.s@samsung.com> wrote:
>> This patch performs the following:
>>
>> 1) Convert the assembly code for memory and clock initialization to C co=
de.
>> 2) Move the memory and clock init codes from board/samsung to arch/arm
>> 3) Creat a common lowlevel_init file across Exynos4 and Exynos5. Convert=
ed
>>    the common lowlevel_init from assembly to C-code
>> 4) Made spl_boot.c and tzpc_init.c common for both exynos4 and exynos5.
>> 5) Enable CONFIG_SKIP_LOWLEVEL_INIT as stack pointer initialisation is a=
lready
>> done in _main.
>> 6) exynos-uboot-spl.lds made common across SMDKV310, Origen and SMDK5250=
.
>>
>> TEST: Tested SD-MMC boot on SMDK5250 and Origen.
>>       Tested USB and SPI boot on SMDK5250
>>       Compile tested for SMDKV310.
>>
>> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>
> Congratulations on getting this patch together.
>
> It looks correct, but I had some problems getting it to build.
> Probably I am missing some other patch.
>
> Configuring for smdk5250 board...
> lowlevel_init.c: In function =91do_lowlevel_init=92:
> lowlevel_init.c:50:2: warning: implicit declaration of function
> =91get_reset_status=92 [-Wimplicit-function-declaration]
> spl_boot.c: In function =91board_init_f=92:
> spl_boot.c:141:3: warning: implicit declaration of function
> =91power_exit_wakeup=92 [-Wimplicit-function-declaration]
> arch/arm/cpu/armv7/exynos/libexynos.o: In function `board_init_f':
> /mnt/host/source/src/third_party/u-boot/files/arch/arm/cpu/armv7/exynos/s=
pl_boot.c:141:
> undefined reference to `power_exit_wakeup'
> arch/arm/cpu/armv7/exynos/libexynos.o: In function `do_lowlevel_init':
> /mnt/host/source/src/third_party/u-boot/files/arch/arm/cpu/armv7/exynos/l=
owlevel_init.c:50:
> undefined reference to `get_reset_status'
> make[1]: *** [/mnt/host/source/src/third_party/u-boot/files/spl/u-boot-sp=
l]
> Error 1
>
> I will send a separate email about the patch situation. Here are the
> patches I applied in reverse order - please let me know if I missed
> any.
>
> d3858f7 (HEAD, snow2) EXYNOS: Move files from board/samsung to arch/arm.
> e666035 hack: Remove TPM definitions from exysno5-dt.h so that next
> patch applies cleanly
> c9ec2d1 EXYNOS4210: Configure GPIO for uart
> cf6e500 EXYNOS: LDS file move to common
> a40665b EXYNOS: Add API for power reset and shutdown
>
>
> Regards,
> Simon
>
>> ---
>>  arch/arm/cpu/armv7/exynos/Makefile                 |   14 +-
>>  .../arm/cpu/armv7/exynos}/clock_init.h             |    0
>>  arch/arm/cpu/armv7/exynos/clock_init_exynos4.c     |   63 +++
>>  .../arm/cpu/armv7/exynos/clock_init_exynos5.c      |   26 +-
>>  arch/arm/cpu/armv7/exynos/common_setup.h           |   44 ++
>>  .../arm/cpu/armv7/exynos}/dmc_common.c             |    7 +-
>>  .../arm/cpu/armv7/exynos}/dmc_init_ddr3.c          |   17 +-
>>  arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c       |  294 ++++++++++++
>>  .../arm/cpu/armv7/exynos/exynos4_setup.h           |   72 +++-
>>  .../arm/cpu/armv7/exynos/exynos5_setup.h           |   53 +--
>>  arch/arm/cpu/armv7/exynos/lowlevel_init.c          |   72 +++
>>  .../arm/cpu/armv7/exynos}/spl_boot.c               |   90 +++-
>>  .../arm/cpu/armv7/exynos}/tzpc_init.c              |   17 +-
>>  arch/arm/include/asm/arch-exynos/spl.h             |    1 +
>>  arch/arm/include/asm/arch-exynos/tzpc.h            |   28 ++
>>  board/samsung/origen/Makefile                      |    7 -
>>  board/samsung/origen/lowlevel_init.S               |  397 -------------=
----
>>  board/samsung/origen/mem_setup.S                   |  421 -------------=
-----
>>  board/samsung/origen/mmc_boot.c                    |   58 ---
>>  board/samsung/smdk5250/Makefile                    |    9 -
>>  board/samsung/smdk5250/lowlevel_init.S             |    2 +
>>  board/samsung/smdkv310/Makefile                    |   10 +-
>>  board/samsung/smdkv310/lowlevel_init.S             |  470 -------------=
-------
>>  board/samsung/smdkv310/mem_setup.S                 |  365 -------------=
--
>>  board/samsung/smdkv310/mmc_boot.c                  |   60 ---
>>  include/configs/exynos5250-dt.h                    |   12 +-
>>  include/configs/origen.h                           |    9 +-
>>  include/configs/smdkv310.h                         |    8 +-
>>  spl/Makefile                                       |    4 +
>>  29 files changed, 728 insertions(+), 1902 deletions(-)
>>  rename {board/samsung/smdk5250 =3D> arch/arm/cpu/armv7/exynos}/clock_in=
it.h (100%)
>>  create mode 100644 arch/arm/cpu/armv7/exynos/clock_init_exynos4.c
>>  rename board/samsung/smdk5250/clock_init.c =3D> arch/arm/cpu/armv7/exyn=
os/clock_init_exynos5.c (97%)
>>  create mode 100644 arch/arm/cpu/armv7/exynos/common_setup.h
>>  rename {board/samsung/smdk5250 =3D> arch/arm/cpu/armv7/exynos}/dmc_comm=
on.c (97%)
>>  rename {board/samsung/smdk5250 =3D> arch/arm/cpu/armv7/exynos}/dmc_init=
_ddr3.c (96%)
>>  create mode 100644 arch/arm/cpu/armv7/exynos/dmc_init_exynos4.c
>>  rename board/samsung/origen/origen_setup.h =3D> arch/arm/cpu/armv7/exyn=
os/exynos4_setup.h (89%)
>>  rename board/samsung/smdk5250/setup.h =3D> arch/arm/cpu/armv7/exynos/ex=
ynos5_setup.h (93%)
>>  create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel_init.c
>>  rename {board/samsung/smdk5250 =3D> arch/arm/cpu/armv7/exynos}/spl_boot=
.c (61%)
>>  rename {board/samsung/smdk5250 =3D> arch/arm/cpu/armv7/exynos}/tzpc_ini=
t.c (81%)
>>  delete mode 100644 board/samsung/origen/lowlevel_init.S
>>  delete mode 100644 board/samsung/origen/mem_setup.S
>>  delete mode 100644 board/samsung/origen/mmc_boot.c
>>  delete mode 100644 board/samsung/smdkv310/lowlevel_init.S
>>  delete mode 100644 board/samsung/smdkv310/mem_setup.S
>>  delete mode 100644 board/samsung/smdkv310/mmc_boot.c
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



--=20
Regards,
Rajeshwari Shinde