[patch] turn off CONFIG_FD on ia64?

[patch] turn off CONFIG_FD on ia64?

[Martin Pool]

As of linux-2.6.0-test2-ia64-030729, there seems to be no
asm-ia64/floppy.h, and so the fd driver won't work.  

Might this patch to make sure it does not accidentally get configured
on be accepted?  

--- linux-2.6.0test2-ia64/drivers/block/Kconfig.~1~	2003-07-29 12:07:02.000000000 +1000
+++ linux-2.6.0test2-ia64/drivers/block/Kconfig	2003-08-06 15:55:16.000000000 +1000
@@ -6,7 +6,7 @@ menu "Block devices"
 
 config BLK_DEV_FD
 	tristate "Normal floppy disk support"
-	depends on !X86_PC9800
+	depends on !X86_PC9800 && !IA64
 	---help---
 	  If you want to use the floppy disk drive(s) of your PC under Linux,
 	  say Y. Information about this driver, especially important for IBM


-- 
Martin 

Re: [patch] turn off CONFIG_FD on ia64?

[Martin Pool]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On 25 Aug 2003 05:30:30 -0400
Jes Sorensen <jes@wildopensource.com> wrote:

> >>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
> 
> Christoph> Anyway, we should test explicitly for configurations
> Christoph> supported by floppy.c.  So far this would be:
> 
> Christoph> CONFIG_ISA CONFIG_M68K CONFIG_SPARC
> 
> CONFIG_SPARC64 I believe. No idea about MIPS configurations.

Should I send a patch to turn off architectures which will never work? 
(Who to?)  It seems to me that allowing people to turn on options which
don't build is not very helpful.

-- 
Martin 

GNU does not eliminate all the world's problems, only some of them.
		-- The GNU Manifesto

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [patch] turn off CONFIG_FD on ia64?

[Grant Grundler]

On Mon, Aug 25, 2003 at 07:21:47PM +0100, Matthew Wilcox wrote:
> We should stop asking the question on PARISC until someone's written
> the code.

I'm ok with that.

grant

Re: [patch] turn off CONFIG_FD on ia64?

[Matthew Wilcox]

On Mon, Aug 25, 2003 at 10:05:32AM -0700, Grant Grundler wrote:
> > any more?
> 
> CONFIG_GSC_LASI and CONFIG_SUPERIO in drivers/parisc/Kconfig.
> Search for "Floppy" in  drivers/parisc/lasi.c and superio.c

It doesn't compile, has never compiled, and doesn't look likely to compile
in the near future.  It's a fairly frequent question on the mailing list.
We should stop asking the question on PARISC until someone's written
the code.

> Because of an on-going lawsuit, HP was not able to publish documentation
> for LASI floppy controller (or it's bugs). We only have one cheesy
> document for the NS87560UBD chip.

That's not true.  Everything anyone could want to know about the Lasi
floppy is in http://ftp.parisc-linux.org/docs/chips/lasi_ers.ps and that
document tells you it interfaces to a "Western Digital WD37C65C Floppy
Disk Controller chip (FDC)."

I don't know where to find documentation on that chip, but wikipedia tells
me, "in 1987 they introduced the WD37C65, a single-chip implementation
of the PC/AT's floppy disk controller circuitry, and the grandfather of
modern super I/O chips"

> I don't recall any work was completed to enable floppy under those
> chips but someone might want to take another whack at it in the future.

Then they can reenable the Kconfig option then.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: [patch] turn off CONFIG_FD on ia64?

[Randy.Dunlap]

On Mon, 25 Aug 2003 10:21:03 +0100 Christoph Hellwig <hch@infradead.org> wrote:

| On Mon, Aug 25, 2003 at 05:03:31AM -0400, Jes Sorensen wrote:
| > Martin> Other systems (such as Amiga and m68k) have non-ISA floppy
| > Martin> drives, which are reached through an ad-hoc abstraction layer
| > Martin> defined by different implementations of asm/floppy.h:
| > 
| > Catching up on old mail here, however Amiga never used the standard
| > style floppy driver, we had our own. I think there is one m68k based
| > box which used the ISA style one.
| > 
| > Sparc also uses drivers/block/floppy.c and they don't have ISA.
| 
| Anyway, we should test explicitly for configurations supported by
| floppy.c.  So far this would be:
| 
| CONFIG_ISA
| CONFIG_M68K
| CONFIG_SPARC
| 
| any more?

Currently BLK_DEV_FD says
	depends on !X86_PC9800

so it still needs to be excluded since it apparently supports ISA.
(but it's hard to tell since parts of its Kconfig seem to be missing)

--
~Randy   [mantra:  Always include kernel version.]
"Everything is relative."

Re: [patch] turn off CONFIG_FD on ia64?

[Grant Grundler]

On Mon, Aug 25, 2003 at 10:21:03AM +0100, Christoph Hellwig wrote:
> Anyway, we should test explicitly for configurations supported by
> floppy.c.

yes - agreed

> So far this would be:
> 
> CONFIG_ISA
> CONFIG_M68K
> CONFIG_SPARC
> 
> any more?

CONFIG_GSC_LASI and CONFIG_SUPERIO in drivers/parisc/Kconfig.
Search for "Floppy" in  drivers/parisc/lasi.c and superio.c

Because of an on-going lawsuit, HP was not able to publish documentation
for LASI floppy controller (or it's bugs). We only have one cheesy
document for the NS87560UBD chip.

I don't recall any work was completed to enable floppy under those
chips but someone might want to take another whack at it in the future.

grant

Re: [patch] turn off CONFIG_FD on ia64?

[Jes Sorensen]

>>>>> "Christoph" = Christoph Hellwig <hch@infradead.org> writes:

Christoph> Anyway, we should test explicitly for configurations
Christoph> supported by floppy.c.  So far this would be:

Christoph> CONFIG_ISA CONFIG_M68K CONFIG_SPARC

CONFIG_SPARC64 I believe. No idea about MIPS configurations.

Jes

Re: [patch] turn off CONFIG_FD on ia64?

[Christoph Hellwig]

On Mon, Aug 25, 2003 at 05:03:31AM -0400, Jes Sorensen wrote:
> Martin> Other systems (such as Amiga and m68k) have non-ISA floppy
> Martin> drives, which are reached through an ad-hoc abstraction layer
> Martin> defined by different implementations of asm/floppy.h:
> 
> Catching up on old mail here, however Amiga never used the standard
> style floppy driver, we had our own. I think there is one m68k based
> box which used the ISA style one.
> 
> Sparc also uses drivers/block/floppy.c and they don't have ISA.

Anyway, we should test explicitly for configurations supported by
floppy.c.  So far this would be:

CONFIG_ISA
CONFIG_M68K
CONFIG_SPARC

any more?

Re: [patch] turn off CONFIG_FD on ia64?

[Jes Sorensen]

>>>>> "Martin" = Martin Pool <mbp@samba.org> writes:

Martin> On 5 Aug 2003, David Mosberger <davidm@napali.hpl.hp.com>
Martin> wrote:
>>  Perhaps the check should be against ISA instead?  Or are there
>> non-ISA systems with such a floppy controller?  In any case, the
>> final decision of course rests with the maintainer of block/Kconfig
>> (probably best to bring it up on lkml).

Martin> Other systems (such as Amiga and m68k) have non-ISA floppy
Martin> drives, which are reached through an ad-hoc abstraction layer
Martin> defined by different implementations of asm/floppy.h:

Catching up on old mail here, however Amiga never used the standard
style floppy driver, we had our own. I think there is one m68k based
box which used the ISA style one.

Sparc also uses drivers/block/floppy.c and they don't have ISA.

Cheers,
Jes

Re: [patch] turn off CONFIG_FD on ia64?

[Matt Domsch]

> Are there any ia64 machines which come with floppy drives?  If there
> aren't, I'd like to be able to tell the maintainer so.

Of the 3 IPF system models Dell has sold or are currently selling, none 
came with a floppy, all came with LS-120 drives.

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Re: [patch] turn off CONFIG_FD on ia64?

[David Mosberger]

>>>>> On Wed, 6 Aug 2003 16:19:19 +1000, Martin Pool <mbp@samba.org> said:

  Martin> Are there any ia64 machines which come with floppy drives?

Nope.  The Merced machines came with SuperDrives (or whatever they
were called), but those attached to the IDE controller, not the floppy
controller.  The classic (AT-style) floppy controller is an ISA device
and since ia64 doesn't support ISA, such controllers never were
supported.

	--david

Re: [patch] turn off CONFIG_FD on ia64?

[Martin Pool]

On  5 Aug 2003, David Mosberger <davidm@napali.hpl.hp.com> wrote:
> >>>>> On Wed, 6 Aug 2003 16:00:28 +1000, Martin Pool <mbp@samba.org> said:
> 
>   Martin> As of linux-2.6.0-test2-ia64-030729, there seems to be no
>   Martin> asm-ia64/floppy.h, and so the fd driver won't work.
> 
>   Martin> Might this patch to make sure it does not accidentally get
>   Martin> configured on be accepted?
> 
> Perhaps the check should be against ISA instead?  Or are there non-ISA
> systems with such a floppy controller?  In any case, the final
> decision of course rests with the maintainer of block/Kconfig
> (probably best to bring it up on lkml).

Other systems (such as Amiga and m68k) have non-ISA floppy drives,
which are reached through an ad-hoc abstraction layer defined by
different implementations of asm/floppy.h:

  ~/work/linux/linux-2.6.0test2-ia64/include/:
  find . \( -name floppy.h \) -exec ls -ld {} \;
  -rw-r--r--    4 mbp      mbp          3721 Jul 11 06:12 asm-arm26/floppy.h
  -rw-r--r--    5 mbp      mbp          6155 Dec 10  2002 asm-parisc/floppy.h
  -rw-r--r--    5 mbp      mbp          2719 Dec 10  2002 asm-ppc64/floppy.h
  -rw-r--r--    5 mbp      mbp            82 Dec 10  2002 asm-um/floppy.h
  -rw-r--r--    2 mbp      mbp          5322 Jul 29 12:07 asm-m68k/floppy.h
  -rw-r--r--    2 mbp      mbp          6706 Jul 29 12:06 asm-x86_64/floppy.h
  -rw-r--r--    5 mbp      mbp          1795 Dec 10  2002 asm-ppc/floppy.h
  -rw-r--r--   13 mbp      mbp          3763 Aug 13  2001 asm-arm/floppy.h
  -rw-r--r--    4 mbp      mbp          3702 Jul 29 12:06 asm-mips/floppy.h
  -rw-r--r--    4 mbp      mbp         10371 Jul 11 06:04 asm-sparc/floppy.h
  -rw-r--r--    5 mbp      mbp          3351 Dec 10  2002 asm-alpha/floppy.h
  -rw-r--r--    4 mbp      mbp          7352 Jul 11 06:06 asm-i386/floppy.h
  -rw-r--r--    2 mbp      mbp         21132 Jul 29 12:07 asm-sparc64/floppy.h
  -rw-r--r--    4 mbp      mbp          3702 Jul 29 12:06 asm-mips64/floppy.h
  -rw-r--r--    2 mbp      mbp          6279 Jul 29 12:06 asm-sh/floppy.h

It looks like there are some similarities, but also many differences,
between support for different platforms.  I didn't want to get into
trying to unify them, which would probably be a much larger project.

Are there any ia64 machines which come with floppy drives?  If there
aren't, I'd like to be able to tell the maintainer so.

Thanks
-- 
Martin 

Re: [patch] turn off CONFIG_FD on ia64?

[David Mosberger]

>>>>> On Wed, 6 Aug 2003 16:00:28 +1000, Martin Pool <mbp@samba.org> said:

  Martin> As of linux-2.6.0-test2-ia64-030729, there seems to be no
  Martin> asm-ia64/floppy.h, and so the fd driver won't work.

  Martin> Might this patch to make sure it does not accidentally get
  Martin> configured on be accepted?

Perhaps the check should be against ISA instead?  Or are there non-ISA
systems with such a floppy controller?  In any case, the final
decision of course rests with the maintainer of block/Kconfig
(probably best to bring it up on lkml).

	--david

  Martin> --- linux-2.6.0test2-ia64/drivers/block/Kconfig.~1~	2003-07-29 12:07:02.000000000 +1000
  Martin> +++ linux-2.6.0test2-ia64/drivers/block/Kconfig	2003-08-06 15:55:16.000000000 +1000
  Martin> @@ -6,7 +6,7 @@ menu "Block devices"
 
  Martin> config BLK_DEV_FD
  Martin> tristate "Normal floppy disk support"
  Martin> -	depends on !X86_PC9800
  Martin> +	depends on !X86_PC9800 && !IA64
  Martin> ---help---
  Martin> If you want to use the floppy disk drive(s) of your PC under Linux,
  Martin> say Y. Information about this driver, especially important for IBM


  Martin> -- 
  Martin> Martin 
  Martin> -
  Martin> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
  Martin> the body of a message to majordomo@vger.kernel.org
  Martin> More majordomo info at  http://vger.kernel.org/majordomo-info.html