[PATCH] select EFI partition support by default

[PATCH] select EFI partition support by default

[John Levon]

This makes the EFI choice look like the others, and makes sure it's
selected by default if the user didn't choose Advanced Partition
Selection.

I fell foul of this, being an IA-64 newbie.

OK ?

regards
john


Index: linux-cvs/fs/partitions/Kconfig
=================================RCS file: /home/cvs/linux-2.5/fs/partitions/Kconfig,v
retrieving revision 1.5
diff -u -a -p -r1.5 Kconfig
--- linux-cvs/fs/partitions/Kconfig	27 Sep 2003 07:07:08 -0000	1.5
+++ linux-cvs/fs/partitions/Kconfig	11 Oct 2003 14:51:42 -0000
@@ -225,8 +225,8 @@ config SUN_PARTITION
 	  you don't know what all this is about, say N.
 
 config EFI_PARTITION
-	bool "EFI GUID Partition support"
-	depends on PARTITION_ADVANCED
+	bool "EFI GUID Partition support" if PARTITION_ADVANCED
+	default y if !PARTITION_ADVANCED && IA64
 	select CRC32
 	help
 	  Say Y here if you would like to use hard disks under Linux which

Re: [PATCH] select EFI partition support by default

[Matt Domsch]

> +       bool "EFI GUID Partition support" if PARTITION_ADVANCED
> +       default y if !PARTITION_ADVANCED && IA64

Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?
-Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Re: [PATCH] select EFI partition support by default

[Christoph Hellwig]

On Sat, Oct 11, 2003 at 11:11:34AM -0500, Matt Domsch wrote:
> > +       bool "EFI GUID Partition support" if PARTITION_ADVANCED
> > +       default y if !PARTITION_ADVANCED && IA64
> 
> Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?

I know the LBD backport is used with SGI disklabels in production
enviroments.  In fact that's the only production use I know of at all...

Re: [PATCH] select EFI partition support by default

[John Levon]

On Mon, Oct 13, 2003 at 10:00:47AM +0100, Christoph Hellwig wrote:

> > > +       bool "EFI GUID Partition support" if PARTITION_ADVANCED
> > > +       default y if !PARTITION_ADVANCED && IA64
> > 
> > Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?
> 
> I know the LBD backport is used with SGI disklabels in production
> enviroments.  In fact that's the only production use I know of at all...

Besides, unless I'm missing something, current 2.6 doesn't prompt for
LBD for IA64 at all ?

So, anybody want the patch :)

regards
john

-- 
Khendon's Law:
If the same point is made twice by the same person, the thread is over.

Re: [PATCH] select EFI partition support by default

[Matt_Domsch]

On Mon, 2003-10-13 at 10:21, John Levon wrote:
> On Mon, Oct 13, 2003 at 10:00:47AM +0100, Christoph Hellwig wrote:
> 
> > > > +       bool "EFI GUID Partition support" if PARTITION_ADVANCED
> > > > +       default y if !PARTITION_ADVANCED && IA64
> > > 
> > > Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?
> > 
> > I know the LBD backport is used with SGI disklabels in production
> > enviroments.  In fact that's the only production use I know of at
> all...
> 
> Besides, unless I'm missing something, current 2.6 doesn't prompt for
> LBD for IA64 at all ?
> 
> So, anybody want the patch :)

Actually, CONFIG_LBD is not necessary on IA-64.

include/linux/types.h:

 * The type used for indexing onto a disc or disc partition.
 * If required, asm/types.h can override it and define
 * HAVE_SECTOR_T
 */
#ifndef HAVE_SECTOR_T
typedef unsigned long sector_t;
#endif

Since HAVE_SECTOR_T isn't ever defined by IA-64, this does the right
thing.


-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Re: [PATCH] select EFI partition support by default

[Peter Chubb]

>>>>> "John" = John Levon <levon@movementarian.org> writes:

John> On Mon, Oct 13, 2003 at 10:00:47AM +0100, Christoph Hellwig
John> wrote:
>> > > +       bool "EFI GUID Partition support" if PARTITION_ADVANCED
>> > > +       default y if !PARTITION_ADVANCED && IA64
>> > 
>> > Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?
>> 
>> I know the LBD backport is used with SGI disklabels in production
>> enviroments.  In fact that's the only production use I know of at
>> all...

John> Besides, unless I'm missing something, current 2.6 doesn't
John> prompt for LBD for IA64 at all ?

John> So, anybody want the patch :)

There's no need to prompt for CONFIG_LBD in 2.6, as all 64-bit
architectures use  64-bit variables for sector_t.

It's only on 32-bit architectures that it's necessary.

Under 2.4, however, CONFIG_LBD is (or should be) forced on for IA64.

Peterc