Incorrect definition of pal cache_check info

Incorrect definition of pal cache_check info

[Keith Owens]

Both 2.4 and 2.6 kernels define struct pal_cache_check_info_s as

typedef struct pal_cache_check_info_s {
   u64	reserved1       : 16,
	way             : 5,    /* Way in which the
				 * error occurred
				 */
	reserved2       : 1,
	mc              : 1,    /* Machine check corrected */
	tv              : 1,    /* Target address
				 * structure is valid
				 */

	wv              : 1,    /* Way field valid */
	op              : 3,    /* Type of cache
				 * operation that
				 * caused the machine
				 * check.
				 */

	dl              : 1,    /* Failure in data part
				 * of cache line
				 */
	tl              : 1,    /* Failure in tag part
				 * of cache line
				 */
	dc              : 1,    /* Failure in dcache */
	ic              : 1,    /* Failure in icache */
	index           : 24,   /* Cache line index */
	mv              : 1,    /* mesi valid */
	mesi            : 3,    /* Cache line state */
	level           : 4;    /* Cache level */
} pal_cache_check_info_t;

which bears very little resemblance to the Cache_Check layout described
in Intel Itanium Architecture Software Developer's Manual Volume 2:
System Architecture, under PAL_MC_ERROR_INFO.  It looks like struct
pal_tlb_check_info_s is wrong as well.  What gives?

Re: Incorrect definition of pal cache_check info

[Keith Owens]

On Wed, 05 Nov 2003 17:34:19 +1100, 
Keith Owens <kaos@sgi.com> wrote:
>Both 2.4 and 2.6 kernels define struct pal_cache_check_info_s as
>...
>which bears very little resemblance to the Cache_Check layout described
>in Intel Itanium Architecture Software Developer's Manual Volume 2:
>System Architecture, under PAL_MC_ERROR_INFO.  It looks like struct
>pal_tlb_check_info_s is wrong as well.  What gives?

Answering my own question.  Some of the PAL structure definitions are
from PAL_MC_ERROR_INFO revision 1.0, the kernel has not been corrected
for revision 2.1.