* [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
@ 2021-12-31 6:11 ` Ron Economos
0 siblings, 0 replies; 10+ messages in thread
From: Ron Economos @ 2021-12-31 6:11 UTC (permalink / raw)
To: Dimitri John Ledkov
Cc: Ron Economos, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
Yash Shah, devicetree, linux-riscv, linux-kernel
This patch is required for the following commit to work.
commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
Signed-off-by: Ron Economos <w6rz@comcast.net>
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 6bfa1f24d3de..c4ed9efdff03 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -39,6 +39,11 @@ rtcclk: rtcclk {
clock-frequency = <RTCCLK_FREQ>;
clock-output-names = "rtcclk";
};
+
+ gpio-poweroff {
+ compatible = "gpio-poweroff";
+ gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
+ };
};
&uart0 {
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
@ 2021-12-31 6:11 ` Ron Economos
0 siblings, 0 replies; 10+ messages in thread
From: Ron Economos @ 2021-12-31 6:11 UTC (permalink / raw)
To: Dimitri John Ledkov
Cc: Ron Economos, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
Yash Shah, devicetree, linux-riscv, linux-kernel
This patch is required for the following commit to work.
commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
Signed-off-by: Ron Economos <w6rz@comcast.net>
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 6bfa1f24d3de..c4ed9efdff03 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -39,6 +39,11 @@ rtcclk: rtcclk {
clock-frequency = <RTCCLK_FREQ>;
clock-output-names = "rtcclk";
};
+
+ gpio-poweroff {
+ compatible = "gpio-poweroff";
+ gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
+ };
};
&uart0 {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
2021-12-31 6:11 ` Ron Economos
@ 2021-12-31 6:58 ` James Clarke
-1 siblings, 0 replies; 10+ messages in thread
From: James Clarke @ 2021-12-31 6:58 UTC (permalink / raw)
To: Ron Economos
Cc: Dimitri John Ledkov, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
Yash Shah, devicetree, linux-riscv, linux-kernel
On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>
> This patch is required for the following commit to work.
>
> commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>
> Signed-off-by: Ron Economos <w6rz@comcast.net>
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 6bfa1f24d3de..c4ed9efdff03 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -39,6 +39,11 @@ rtcclk: rtcclk {
> clock-frequency = <RTCCLK_FREQ>;
> clock-output-names = "rtcclk";
> };
> +
> + gpio-poweroff {
> + compatible = "gpio-poweroff";
> + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
> + };
Why? It’s abstracted by firmware, which works.
Jess
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
@ 2021-12-31 6:58 ` James Clarke
0 siblings, 0 replies; 10+ messages in thread
From: James Clarke @ 2021-12-31 6:58 UTC (permalink / raw)
To: Ron Economos
Cc: Dimitri John Ledkov, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
Yash Shah, devicetree, linux-riscv, linux-kernel
On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>
> This patch is required for the following commit to work.
>
> commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>
> Signed-off-by: Ron Economos <w6rz@comcast.net>
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 6bfa1f24d3de..c4ed9efdff03 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -39,6 +39,11 @@ rtcclk: rtcclk {
> clock-frequency = <RTCCLK_FREQ>;
> clock-output-names = "rtcclk";
> };
> +
> + gpio-poweroff {
> + compatible = "gpio-poweroff";
> + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
> + };
Why? It’s abstracted by firmware, which works.
Jess
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
2021-12-31 6:58 ` James Clarke
@ 2021-12-31 15:35 ` Ron Economos
-1 siblings, 0 replies; 10+ messages in thread
From: Ron Economos @ 2021-12-31 15:35 UTC (permalink / raw)
To: James Clarke
Cc: Dimitri John Ledkov, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
devicetree, linux-riscv, linux-kernel
On 12/30/21 10:58 PM, James Clarke wrote:
> On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>> This patch is required for the following commit to work.
>>
>> commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>>
>> Signed-off-by: Ron Economos <w6rz@comcast.net>
>> ---
>> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> index 6bfa1f24d3de..c4ed9efdff03 100644
>> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> @@ -39,6 +39,11 @@ rtcclk: rtcclk {
>> clock-frequency = <RTCCLK_FREQ>;
>> clock-output-names = "rtcclk";
>> };
>> +
>> + gpio-poweroff {
>> + compatible = "gpio-poweroff";
>> + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>> + };
> Why? It’s abstracted by firmware, which works.
>
> Jess
>
I didn't realize that OpenSBI 1.0 had been released last week. Please
disregard this patch.
Ron
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
@ 2021-12-31 15:35 ` Ron Economos
0 siblings, 0 replies; 10+ messages in thread
From: Ron Economos @ 2021-12-31 15:35 UTC (permalink / raw)
To: James Clarke
Cc: Dimitri John Ledkov, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
devicetree, linux-riscv, linux-kernel
On 12/30/21 10:58 PM, James Clarke wrote:
> On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>> This patch is required for the following commit to work.
>>
>> commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>>
>> Signed-off-by: Ron Economos <w6rz@comcast.net>
>> ---
>> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> index 6bfa1f24d3de..c4ed9efdff03 100644
>> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> @@ -39,6 +39,11 @@ rtcclk: rtcclk {
>> clock-frequency = <RTCCLK_FREQ>;
>> clock-output-names = "rtcclk";
>> };
>> +
>> + gpio-poweroff {
>> + compatible = "gpio-poweroff";
>> + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>> + };
> Why? It’s abstracted by firmware, which works.
>
> Jess
>
I didn't realize that OpenSBI 1.0 had been released last week. Please
disregard this patch.
Ron
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
[not found] ` <CADWks+Yjh1B=Fu8NFS4KYrvNh_bU8P5pzb+_yNvseS+1+D5H7Q@mail.gmail.com>
@ 2021-12-31 17:16 ` Jessica Clarke
0 siblings, 0 replies; 10+ messages in thread
From: Jessica Clarke @ 2021-12-31 17:16 UTC (permalink / raw)
To: Dimitri John Ledkov
Cc: Ron Economos, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
Yash Shah, devicetree, linux-riscv,
linux-kernel@vger.kernel.org List
On 31 Dec 2021, at 16:49, Dimitri John Ledkov <dimitri.ledkov@canonical.com> wrote:
>
> However, in some configurations uboot loads kernel provided dtb, then this pin needs to be defines for SBI to provide poweroff via this pin.
>
> Kernel, uboot, opensbi dtbs for unmatched must be consistent with each other and all should define poweroff pin.
U-Boot SPL loads its embedded DTB for OpenSBI’s use. U-Boot “proper”
loads the kernel’s DTB for the kernel’s use. The DTB loaded for the
kernel is never fed back somehow. Just as we don’t provide DDR timing
information in the kernel DTB, only U-Boot’s, there should be no need
to provide information about this GPIO to the kernel. Either the kernel
will prioritise SBI power-off, which renders the DTB node a complete
waste of space, and possibly confusing to exist, or the kernel will
prioritise GPIO power-off, which should be discouraged as you’re
supposed to use standardised firmware interfaces for these kinds of
platform-specific things.
Jess
> On Fri, 31 Dec 2021, 06:58 James Clarke, <jrtc27@jrtc27.com> wrote:
> On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
> >
> > This patch is required for the following commit to work.
> >
> > commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
> >
> > Signed-off-by: Ron Economos <w6rz@comcast.net>
> > ---
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 6bfa1f24d3de..c4ed9efdff03 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -39,6 +39,11 @@ rtcclk: rtcclk {
> > clock-frequency = <RTCCLK_FREQ>;
> > clock-output-names = "rtcclk";
> > };
> > +
> > + gpio-poweroff {
> > + compatible = "gpio-poweroff";
> > + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
> > + };
>
> Why? It’s abstracted by firmware, which works.
>
> Jess
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
@ 2021-12-31 17:16 ` Jessica Clarke
0 siblings, 0 replies; 10+ messages in thread
From: Jessica Clarke @ 2021-12-31 17:16 UTC (permalink / raw)
To: Dimitri John Ledkov
Cc: Ron Economos, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Vincent Pelletier, Krzysztof Kozlowski, Qiu Wenbo,
Yash Shah, devicetree, linux-riscv,
linux-kernel@vger.kernel.org List
On 31 Dec 2021, at 16:49, Dimitri John Ledkov <dimitri.ledkov@canonical.com> wrote:
>
> However, in some configurations uboot loads kernel provided dtb, then this pin needs to be defines for SBI to provide poweroff via this pin.
>
> Kernel, uboot, opensbi dtbs for unmatched must be consistent with each other and all should define poweroff pin.
U-Boot SPL loads its embedded DTB for OpenSBI’s use. U-Boot “proper”
loads the kernel’s DTB for the kernel’s use. The DTB loaded for the
kernel is never fed back somehow. Just as we don’t provide DDR timing
information in the kernel DTB, only U-Boot’s, there should be no need
to provide information about this GPIO to the kernel. Either the kernel
will prioritise SBI power-off, which renders the DTB node a complete
waste of space, and possibly confusing to exist, or the kernel will
prioritise GPIO power-off, which should be discouraged as you’re
supposed to use standardised firmware interfaces for these kinds of
platform-specific things.
Jess
> On Fri, 31 Dec 2021, 06:58 James Clarke, <jrtc27@jrtc27.com> wrote:
> On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
> >
> > This patch is required for the following commit to work.
> >
> > commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
> >
> > Signed-off-by: Ron Economos <w6rz@comcast.net>
> > ---
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 6bfa1f24d3de..c4ed9efdff03 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -39,6 +39,11 @@ rtcclk: rtcclk {
> > clock-frequency = <RTCCLK_FREQ>;
> > clock-output-names = "rtcclk";
> > };
> > +
> > + gpio-poweroff {
> > + compatible = "gpio-poweroff";
> > + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
> > + };
>
> Why? It’s abstracted by firmware, which works.
>
> Jess
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
2021-12-31 17:16 ` Jessica Clarke
@ 2022-01-20 18:17 ` Palmer Dabbelt
-1 siblings, 0 replies; 10+ messages in thread
From: Palmer Dabbelt @ 2022-01-20 18:17 UTC (permalink / raw)
To: jrtc27
Cc: dimitri.ledkov, w6rz, robh+dt, Paul Walmsley, aou, plr.vincent,
krzysztof.kozlowski, qiuwenbo, yash.shah, devicetree,
linux-riscv, linux-kernel
On Fri, 31 Dec 2021 09:16:00 PST (-0800), jrtc27@jrtc27.com wrote:
> On 31 Dec 2021, at 16:49, Dimitri John Ledkov <dimitri.ledkov@canonical.com> wrote:
>>
>> However, in some configurations uboot loads kernel provided dtb, then this pin needs to be defines for SBI to provide poweroff via this pin.
>>
>> Kernel, uboot, opensbi dtbs for unmatched must be consistent with each other and all should define poweroff pin.
>
> U-Boot SPL loads its embedded DTB for OpenSBI’s use. U-Boot “proper”
> loads the kernel’s DTB for the kernel’s use. The DTB loaded for the
> kernel is never fed back somehow. Just as we don’t provide DDR timing
> information in the kernel DTB, only U-Boot’s, there should be no need
> to provide information about this GPIO to the kernel. Either the kernel
> will prioritise SBI power-off, which renders the DTB node a complete
> waste of space, and possibly confusing to exist, or the kernel will
> prioritise GPIO power-off, which should be discouraged as you’re
> supposed to use standardised firmware interfaces for these kinds of
> platform-specific things.
The DTs (and bindings, etc) in the kernel source tree are meant for more
than just the kernel's consumption. I know we have (and will likely
always have) some diff with the other consumers of device trees, but we
can at least try to get folks on the same page about small stuff like
this.
There is also some utility to having this visible to Linux: at a bare
minimum it lets us know that GPIO pin has an important function.
This patch is on for-next.
>
> Jess
>
>> On Fri, 31 Dec 2021, 06:58 James Clarke, <jrtc27@jrtc27.com> wrote:
>> On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>> >
>> > This patch is required for the following commit to work.
>> >
>> > commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>> >
>> > Signed-off-by: Ron Economos <w6rz@comcast.net>
>> > ---
>> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> > index 6bfa1f24d3de..c4ed9efdff03 100644
>> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> > @@ -39,6 +39,11 @@ rtcclk: rtcclk {
>> > clock-frequency = <RTCCLK_FREQ>;
>> > clock-output-names = "rtcclk";
>> > };
>> > +
>> > + gpio-poweroff {
>> > + compatible = "gpio-poweroff";
>> > + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>> > + };
>>
>> Why? It’s abstracted by firmware, which works.
>>
>> Jess
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
@ 2022-01-20 18:17 ` Palmer Dabbelt
0 siblings, 0 replies; 10+ messages in thread
From: Palmer Dabbelt @ 2022-01-20 18:17 UTC (permalink / raw)
To: jrtc27
Cc: dimitri.ledkov, w6rz, robh+dt, Paul Walmsley, aou, plr.vincent,
krzysztof.kozlowski, qiuwenbo, yash.shah, devicetree,
linux-riscv, linux-kernel
On Fri, 31 Dec 2021 09:16:00 PST (-0800), jrtc27@jrtc27.com wrote:
> On 31 Dec 2021, at 16:49, Dimitri John Ledkov <dimitri.ledkov@canonical.com> wrote:
>>
>> However, in some configurations uboot loads kernel provided dtb, then this pin needs to be defines for SBI to provide poweroff via this pin.
>>
>> Kernel, uboot, opensbi dtbs for unmatched must be consistent with each other and all should define poweroff pin.
>
> U-Boot SPL loads its embedded DTB for OpenSBI’s use. U-Boot “proper”
> loads the kernel’s DTB for the kernel’s use. The DTB loaded for the
> kernel is never fed back somehow. Just as we don’t provide DDR timing
> information in the kernel DTB, only U-Boot’s, there should be no need
> to provide information about this GPIO to the kernel. Either the kernel
> will prioritise SBI power-off, which renders the DTB node a complete
> waste of space, and possibly confusing to exist, or the kernel will
> prioritise GPIO power-off, which should be discouraged as you’re
> supposed to use standardised firmware interfaces for these kinds of
> platform-specific things.
The DTs (and bindings, etc) in the kernel source tree are meant for more
than just the kernel's consumption. I know we have (and will likely
always have) some diff with the other consumers of device trees, but we
can at least try to get folks on the same page about small stuff like
this.
There is also some utility to having this visible to Linux: at a bare
minimum it lets us know that GPIO pin has an important function.
This patch is on for-next.
>
> Jess
>
>> On Fri, 31 Dec 2021, 06:58 James Clarke, <jrtc27@jrtc27.com> wrote:
>> On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>> >
>> > This patch is required for the following commit to work.
>> >
>> > commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>> >
>> > Signed-off-by: Ron Economos <w6rz@comcast.net>
>> > ---
>> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> > index 6bfa1f24d3de..c4ed9efdff03 100644
>> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>> > @@ -39,6 +39,11 @@ rtcclk: rtcclk {
>> > clock-frequency = <RTCCLK_FREQ>;
>> > clock-output-names = "rtcclk";
>> > };
>> > +
>> > + gpio-poweroff {
>> > + compatible = "gpio-poweroff";
>> > + gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>> > + };
>>
>> Why? It’s abstracted by firmware, which works.
>>
>> Jess
>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-01-20 18:17 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-31 6:11 [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff Ron Economos
2021-12-31 6:11 ` Ron Economos
2021-12-31 6:58 ` James Clarke
2021-12-31 6:58 ` James Clarke
2021-12-31 15:35 ` Ron Economos
2021-12-31 15:35 ` Ron Economos
[not found] ` <CADWks+Yjh1B=Fu8NFS4KYrvNh_bU8P5pzb+_yNvseS+1+D5H7Q@mail.gmail.com>
2021-12-31 17:16 ` Jessica Clarke
2021-12-31 17:16 ` Jessica Clarke
2022-01-20 18:17 ` Palmer Dabbelt
2022-01-20 18:17 ` Palmer Dabbelt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.