* [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-09-19 22:48 Nick Kossifidis
2018-09-29 1:44 ` Palmer Dabbelt
0 siblings, 1 reply; 7+ messages in thread
From: Nick Kossifidis @ 2018-09-19 22:48 UTC (permalink / raw)
To: linux-riscv
* Move the built-in cmdline configuration on a new menu entry "Boot
options", it doesn't make much sense to be part of the debuging menu.
* Rename "Kernel Type" menu to "Kernel features" to be more consistent with
what other architectures are using, plus "type" is a bit misleading here.
Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
---
arch/riscv/Kconfig | 40 +++++++++++++++++++++++++++++++++++++++-
arch/riscv/Kconfig.debug | 35 -----------------------------------
2 files changed, 39 insertions(+), 36 deletions(-)
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index a3449802..82172bf8 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -210,12 +210,50 @@ endmenu
endmenu
-menu "Kernel type"
+menu "Kernel features"
source "kernel/Kconfig.hz"
endmenu
+menu "Boot options"
+
+config CMDLINE_BOOL
+ bool "Built-in kernel command line"
+ help
+ For most platforms, it is firmware or second stage bootloader
+ that by default specifies the kernel command line options.
+ However, it might be necessary or advantageous to either override
+ the default kernel command line or add a few extra options to it.
+ For such cases, this option allows hardcoding command line options
+ directly into the kernel.
+
+ For that, choose 'Y' here and fill in the extra boot parameters
+ in CONFIG_CMDLINE.
+
+ The built-in options will be concatenated to the default command
+ line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
+ command line will be ignored and replaced by the built-in string.
+
+config CMDLINE
+ string "Built-in kernel command string"
+ depends on CMDLINE_BOOL
+ default ""
+ help
+ Supply command-line options at build time by entering them here.
+
+config CMDLINE_FORCE
+ bool "Built-in command line overrides bootloader arguments"
+ depends on CMDLINE_BOOL
+ help
+ Set this option to 'Y' to have the kernel ignore the bootloader
+ or firmware command line. Instead, the built-in command line
+ will be used exclusively.
+
+ If you don't know what to do here, say N.
+
+endmenu
+
menu "Bus support"
config PCI
diff --git a/arch/riscv/Kconfig.debug b/arch/riscv/Kconfig.debug
index 3224ff6e..c5a72f17 100644
--- a/arch/riscv/Kconfig.debug
+++ b/arch/riscv/Kconfig.debug
@@ -1,37 +1,2 @@
-
-config CMDLINE_BOOL
- bool "Built-in kernel command line"
- help
- For most platforms, it is firmware or second stage bootloader
- that by default specifies the kernel command line options.
- However, it might be necessary or advantageous to either override
- the default kernel command line or add a few extra options to it.
- For such cases, this option allows hardcoding command line options
- directly into the kernel.
-
- For that, choose 'Y' here and fill in the extra boot parameters
- in CONFIG_CMDLINE.
-
- The built-in options will be concatenated to the default command
- line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
- command line will be ignored and replaced by the built-in string.
-
-config CMDLINE
- string "Built-in kernel command string"
- depends on CMDLINE_BOOL
- default ""
- help
- Supply command-line options at build time by entering them here.
-
-config CMDLINE_FORCE
- bool "Built-in command line overrides bootloader arguments"
- depends on CMDLINE_BOOL
- help
- Set this option to 'Y' to have the kernel ignore the bootloader
- or firmware command line. Instead, the built-in command line
- will be used exclusively.
-
- If you don't know what to do here, say N.
-
config EARLY_PRINTK
def_bool y
--
2.16.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-09-29 1:44 ` Palmer Dabbelt
0 siblings, 0 replies; 7+ messages in thread
From: Palmer Dabbelt @ 2018-09-29 1:44 UTC (permalink / raw)
To: linux-riscv
On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick at ics.forth.gr wrote:
> * Move the built-in cmdline configuration on a new menu entry "Boot
> options", it doesn't make much sense to be part of the debuging menu.
>
> * Rename "Kernel Type" menu to "Kernel features" to be more consistent with
> what other architectures are using, plus "type" is a bit misleading here.
>
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
This seems reasonable to me. I've added it to our for-next branch, we'll see
if anyone else has comments. Thanks!
Did you, by any chance, go and check to see if these boot options actually
work? We've got a bunch of subtly different boot methods and they've been
broken in various ones at various times, so I always like to try and catalog
what actually works now so at least I know where to look when testing things.
> ---
> arch/riscv/Kconfig | 40 +++++++++++++++++++++++++++++++++++++++-
> arch/riscv/Kconfig.debug | 35 -----------------------------------
> 2 files changed, 39 insertions(+), 36 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a3449802..82172bf8 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -210,12 +210,50 @@ endmenu
>
> endmenu
>
> -menu "Kernel type"
> +menu "Kernel features"
>
> source "kernel/Kconfig.hz"
>
> endmenu
>
> +menu "Boot options"
> +
> +config CMDLINE_BOOL
> + bool "Built-in kernel command line"
> + help
> + For most platforms, it is firmware or second stage bootloader
> + that by default specifies the kernel command line options.
> + However, it might be necessary or advantageous to either override
> + the default kernel command line or add a few extra options to it.
> + For such cases, this option allows hardcoding command line options
> + directly into the kernel.
> +
> + For that, choose 'Y' here and fill in the extra boot parameters
> + in CONFIG_CMDLINE.
> +
> + The built-in options will be concatenated to the default command
> + line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
> + command line will be ignored and replaced by the built-in string.
> +
> +config CMDLINE
> + string "Built-in kernel command string"
> + depends on CMDLINE_BOOL
> + default ""
> + help
> + Supply command-line options at build time by entering them here.
> +
> +config CMDLINE_FORCE
> + bool "Built-in command line overrides bootloader arguments"
> + depends on CMDLINE_BOOL
> + help
> + Set this option to 'Y' to have the kernel ignore the bootloader
> + or firmware command line. Instead, the built-in command line
> + will be used exclusively.
> +
> + If you don't know what to do here, say N.
> +
> +endmenu
> +
> menu "Bus support"
>
> config PCI
> diff --git a/arch/riscv/Kconfig.debug b/arch/riscv/Kconfig.debug
> index 3224ff6e..c5a72f17 100644
> --- a/arch/riscv/Kconfig.debug
> +++ b/arch/riscv/Kconfig.debug
> @@ -1,37 +1,2 @@
> -
> -config CMDLINE_BOOL
> - bool "Built-in kernel command line"
> - help
> - For most platforms, it is firmware or second stage bootloader
> - that by default specifies the kernel command line options.
> - However, it might be necessary or advantageous to either override
> - the default kernel command line or add a few extra options to it.
> - For such cases, this option allows hardcoding command line options
> - directly into the kernel.
> -
> - For that, choose 'Y' here and fill in the extra boot parameters
> - in CONFIG_CMDLINE.
> -
> - The built-in options will be concatenated to the default command
> - line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
> - command line will be ignored and replaced by the built-in string.
> -
> -config CMDLINE
> - string "Built-in kernel command string"
> - depends on CMDLINE_BOOL
> - default ""
> - help
> - Supply command-line options at build time by entering them here.
> -
> -config CMDLINE_FORCE
> - bool "Built-in command line overrides bootloader arguments"
> - depends on CMDLINE_BOOL
> - help
> - Set this option to 'Y' to have the kernel ignore the bootloader
> - or firmware command line. Instead, the built-in command line
> - will be used exclusively.
> -
> - If you don't know what to do here, say N.
> -
> config EARLY_PRINTK
> def_bool y
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-09-29 1:44 ` Palmer Dabbelt
0 siblings, 0 replies; 7+ messages in thread
From: Palmer Dabbelt @ 2018-09-29 1:44 UTC (permalink / raw)
To: mick; +Cc: mick, linux-riscv, aou
On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick@ics.forth.gr wrote:
> * Move the built-in cmdline configuration on a new menu entry "Boot
> options", it doesn't make much sense to be part of the debuging menu.
>
> * Rename "Kernel Type" menu to "Kernel features" to be more consistent with
> what other architectures are using, plus "type" is a bit misleading here.
>
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
This seems reasonable to me. I've added it to our for-next branch, we'll see
if anyone else has comments. Thanks!
Did you, by any chance, go and check to see if these boot options actually
work? We've got a bunch of subtly different boot methods and they've been
broken in various ones at various times, so I always like to try and catalog
what actually works now so at least I know where to look when testing things.
> ---
> arch/riscv/Kconfig | 40 +++++++++++++++++++++++++++++++++++++++-
> arch/riscv/Kconfig.debug | 35 -----------------------------------
> 2 files changed, 39 insertions(+), 36 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a3449802..82172bf8 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -210,12 +210,50 @@ endmenu
>
> endmenu
>
> -menu "Kernel type"
> +menu "Kernel features"
>
> source "kernel/Kconfig.hz"
>
> endmenu
>
> +menu "Boot options"
> +
> +config CMDLINE_BOOL
> + bool "Built-in kernel command line"
> + help
> + For most platforms, it is firmware or second stage bootloader
> + that by default specifies the kernel command line options.
> + However, it might be necessary or advantageous to either override
> + the default kernel command line or add a few extra options to it.
> + For such cases, this option allows hardcoding command line options
> + directly into the kernel.
> +
> + For that, choose 'Y' here and fill in the extra boot parameters
> + in CONFIG_CMDLINE.
> +
> + The built-in options will be concatenated to the default command
> + line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
> + command line will be ignored and replaced by the built-in string.
> +
> +config CMDLINE
> + string "Built-in kernel command string"
> + depends on CMDLINE_BOOL
> + default ""
> + help
> + Supply command-line options at build time by entering them here.
> +
> +config CMDLINE_FORCE
> + bool "Built-in command line overrides bootloader arguments"
> + depends on CMDLINE_BOOL
> + help
> + Set this option to 'Y' to have the kernel ignore the bootloader
> + or firmware command line. Instead, the built-in command line
> + will be used exclusively.
> +
> + If you don't know what to do here, say N.
> +
> +endmenu
> +
> menu "Bus support"
>
> config PCI
> diff --git a/arch/riscv/Kconfig.debug b/arch/riscv/Kconfig.debug
> index 3224ff6e..c5a72f17 100644
> --- a/arch/riscv/Kconfig.debug
> +++ b/arch/riscv/Kconfig.debug
> @@ -1,37 +1,2 @@
> -
> -config CMDLINE_BOOL
> - bool "Built-in kernel command line"
> - help
> - For most platforms, it is firmware or second stage bootloader
> - that by default specifies the kernel command line options.
> - However, it might be necessary or advantageous to either override
> - the default kernel command line or add a few extra options to it.
> - For such cases, this option allows hardcoding command line options
> - directly into the kernel.
> -
> - For that, choose 'Y' here and fill in the extra boot parameters
> - in CONFIG_CMDLINE.
> -
> - The built-in options will be concatenated to the default command
> - line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
> - command line will be ignored and replaced by the built-in string.
> -
> -config CMDLINE
> - string "Built-in kernel command string"
> - depends on CMDLINE_BOOL
> - default ""
> - help
> - Supply command-line options at build time by entering them here.
> -
> -config CMDLINE_FORCE
> - bool "Built-in command line overrides bootloader arguments"
> - depends on CMDLINE_BOOL
> - help
> - Set this option to 'Y' to have the kernel ignore the bootloader
> - or firmware command line. Instead, the built-in command line
> - will be used exclusively.
> -
> - If you don't know what to do here, say N.
> -
> config EARLY_PRINTK
> def_bool y
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-09-29 20:45 ` Nick Kossifidis
0 siblings, 0 replies; 7+ messages in thread
From: Nick Kossifidis @ 2018-09-29 20:45 UTC (permalink / raw)
To: linux-riscv
???? 2018-09-29 04:44, Palmer Dabbelt ??????:
> On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick at ics.forth.gr wrote:
>> * Move the built-in cmdline configuration on a new menu entry "Boot
>> options", it doesn't make much sense to be part of the debuging
>> menu.
>>
>> * Rename "Kernel Type" menu to "Kernel features" to be more consistent
>> with
>> what other architectures are using, plus "type" is a bit misleading
>> here.
>>
>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
>
> This seems reasonable to me. I've added it to our for-next branch,
> we'll see if anyone else has comments. Thanks!
>
> Did you, by any chance, go and check to see if these boot options
> actually work? We've got a bunch of subtly different boot methods and
> they've been broken in various ones at various times, so I always like
> to try and catalog what actually works now so at least I know where to
> look when testing things.
>
I assumed that since it was already there it worked but you are right,
cmdline when passed from the bootloader through the generated device
tree
(https://github.com/riscv/riscv-qemu/blob/riscv-all/hw/riscv/virt.c)
works but when passed through the config option doesn't. Do you want me
to send a separate patch for that or re-send this one as well as a
series ?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-09-29 20:45 ` Nick Kossifidis
0 siblings, 0 replies; 7+ messages in thread
From: Nick Kossifidis @ 2018-09-29 20:45 UTC (permalink / raw)
To: Palmer Dabbelt; +Cc: mick, linux-riscv, aou
Στις 2018-09-29 04:44, Palmer Dabbelt έγραψε:
> On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick@ics.forth.gr wrote:
>> * Move the built-in cmdline configuration on a new menu entry "Boot
>> options", it doesn't make much sense to be part of the debuging
>> menu.
>>
>> * Rename "Kernel Type" menu to "Kernel features" to be more consistent
>> with
>> what other architectures are using, plus "type" is a bit misleading
>> here.
>>
>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
>
> This seems reasonable to me. I've added it to our for-next branch,
> we'll see if anyone else has comments. Thanks!
>
> Did you, by any chance, go and check to see if these boot options
> actually work? We've got a bunch of subtly different boot methods and
> they've been broken in various ones at various times, so I always like
> to try and catalog what actually works now so at least I know where to
> look when testing things.
>
I assumed that since it was already there it worked but you are right,
cmdline when passed from the bootloader through the generated device
tree
(https://github.com/riscv/riscv-qemu/blob/riscv-all/hw/riscv/virt.c)
works but when passed through the config option doesn't. Do you want me
to send a separate patch for that or re-send this one as well as a
series ?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-10-01 16:56 ` Palmer Dabbelt
0 siblings, 0 replies; 7+ messages in thread
From: Palmer Dabbelt @ 2018-10-01 16:56 UTC (permalink / raw)
To: linux-riscv
On Sat, 29 Sep 2018 13:45:05 PDT (-0700), mick at ics.forth.gr wrote:
> ???? 2018-09-29 04:44, Palmer Dabbelt ??????:
>> On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick at ics.forth.gr wrote:
>>> * Move the built-in cmdline configuration on a new menu entry "Boot
>>> options", it doesn't make much sense to be part of the debuging
>>> menu.
>>>
>>> * Rename "Kernel Type" menu to "Kernel features" to be more consistent
>>> with
>>> what other architectures are using, plus "type" is a bit misleading
>>> here.
>>>
>>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
>>
>> This seems reasonable to me. I've added it to our for-next branch,
>> we'll see if anyone else has comments. Thanks!
>>
>> Did you, by any chance, go and check to see if these boot options
>> actually work? We've got a bunch of subtly different boot methods and
>> they've been broken in various ones at various times, so I always like
>> to try and catalog what actually works now so at least I know where to
>> look when testing things.
>>
>
> I assumed that since it was already there it worked but you are right,
> cmdline when passed from the bootloader through the generated device
> tree
> (https://github.com/riscv/riscv-qemu/blob/riscv-all/hw/riscv/virt.c)
> works but when passed through the config option doesn't. Do you want me
> to send a separate patch for that or re-send this one as well as a
> series ?
I think it's better to send that out as a separate patch. There's really no
reason to couple the two, it's just that this reminded me that we probably had
some bugs here.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] RISC-V: Cosmetic menuconfig changes
@ 2018-10-01 16:56 ` Palmer Dabbelt
0 siblings, 0 replies; 7+ messages in thread
From: Palmer Dabbelt @ 2018-10-01 16:56 UTC (permalink / raw)
To: mick; +Cc: mick, linux-riscv, aou
On Sat, 29 Sep 2018 13:45:05 PDT (-0700), mick@ics.forth.gr wrote:
> Στις 2018-09-29 04:44, Palmer Dabbelt έγραψε:
>> On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick@ics.forth.gr wrote:
>>> * Move the built-in cmdline configuration on a new menu entry "Boot
>>> options", it doesn't make much sense to be part of the debuging
>>> menu.
>>>
>>> * Rename "Kernel Type" menu to "Kernel features" to be more consistent
>>> with
>>> what other architectures are using, plus "type" is a bit misleading
>>> here.
>>>
>>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
>>
>> This seems reasonable to me. I've added it to our for-next branch,
>> we'll see if anyone else has comments. Thanks!
>>
>> Did you, by any chance, go and check to see if these boot options
>> actually work? We've got a bunch of subtly different boot methods and
>> they've been broken in various ones at various times, so I always like
>> to try and catalog what actually works now so at least I know where to
>> look when testing things.
>>
>
> I assumed that since it was already there it worked but you are right,
> cmdline when passed from the bootloader through the generated device
> tree
> (https://github.com/riscv/riscv-qemu/blob/riscv-all/hw/riscv/virt.c)
> works but when passed through the config option doesn't. Do you want me
> to send a separate patch for that or re-send this one as well as a
> series ?
I think it's better to send that out as a separate patch. There's really no
reason to couple the two, it's just that this reminded me that we probably had
some bugs here.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-01 16:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 22:48 [PATCH] RISC-V: Cosmetic menuconfig changes Nick Kossifidis
2018-09-29 1:44 ` Palmer Dabbelt
2018-09-29 1:44 ` Palmer Dabbelt
2018-09-29 20:45 ` Nick Kossifidis
2018-09-29 20:45 ` Nick Kossifidis
2018-10-01 16:56 ` Palmer Dabbelt
2018-10-01 16:56 ` Palmer Dabbelt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.