[PATCH] Documentation: riscv: fix insufficient list item indent

[PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

When adding the ISA string ordering rules, I didn't sufficiently indent
one of the list items.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
index 2ebec4c52230..8960fac42c40 100644
--- a/Documentation/riscv/uabi.rst
+++ b/Documentation/riscv/uabi.rst
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level
-- 
2.39.1

[PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

When adding the ISA string ordering rules, I didn't sufficiently indent
one of the list items.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
index 2ebec4c52230..8960fac42c40 100644
--- a/Documentation/riscv/uabi.rst
+++ b/Documentation/riscv/uabi.rst
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level
-- 
2.39.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]

On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Seems like you forget to add link to the report:

Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/

> ---
>  Documentation/riscv/uabi.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
> index 2ebec4c52230..8960fac42c40 100644
> --- a/Documentation/riscv/uabi.rst
> +++ b/Documentation/riscv/uabi.rst
> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>     single-letter extensions and before any higher-privileged extensions.
>  
>  #. For additional standard extensions, the first letter following the 'Z'
> -  conventionally indicates the most closely related alphabetical
> -  extension category. If multiple 'Z' extensions are named, they will be ordered
> -  first by category, in canonical order, as listed above, then alphabetically
> -  within a category.
> +   conventionally indicates the most closely related alphabetical
> +   extension category. If multiple 'Z' extensions are named, they will be
> +   ordered first by category, in canonical order, as listed above, then
> +   alphabetically within a category.
>  
>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>     after standard unprivileged extensions.  If multiple supervisor-level

The warning is fixed, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Bagas Sanjaya]

[-- Attachment #1.1: Type: text/plain, Size: 1942 bytes --]

On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Seems like you forget to add link to the report:

Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/

> ---
>  Documentation/riscv/uabi.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
> index 2ebec4c52230..8960fac42c40 100644
> --- a/Documentation/riscv/uabi.rst
> +++ b/Documentation/riscv/uabi.rst
> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>     single-letter extensions and before any higher-privileged extensions.
>  
>  #. For additional standard extensions, the first letter following the 'Z'
> -  conventionally indicates the most closely related alphabetical
> -  extension category. If multiple 'Z' extensions are named, they will be ordered
> -  first by category, in canonical order, as listed above, then alphabetically
> -  within a category.
> +   conventionally indicates the most closely related alphabetical
> +   extension category. If multiple 'Z' extensions are named, they will be
> +   ordered first by category, in canonical order, as listed above, then
> +   alphabetically within a category.
>  
>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>     after standard unprivileged extensions.  If multiple supervisor-level

The warning is fixed, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

On Mon, Jan 30, 2023 at 10:05:53AM +0700, Bagas Sanjaya wrote:
> On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > When adding the ISA string ordering rules, I didn't sufficiently indent
> > one of the list items.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Seems like you forget to add link to the report:
> 
> Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/

No, I didn't forget actually. I just didn't think it added any useful
information. No harm having it though I suppose, but I'll not resend to
add it.

Thanks,
Conor.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]

On Mon, Jan 30, 2023 at 10:05:53AM +0700, Bagas Sanjaya wrote:
> On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > When adding the ISA string ordering rules, I didn't sufficiently indent
> > one of the list items.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Seems like you forget to add link to the report:
> 
> Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/

No, I didn't forget actually. I just didn't think it added any useful
information. No harm having it though I suppose, but I'll not resend to
add it.

Thanks,
Conor.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

Hey Palmer,

If you do end up having WiFi could you pick this up so that the
regressions report thingy stops whining at me?

Thanks!

On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  Documentation/riscv/uabi.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
> index 2ebec4c52230..8960fac42c40 100644
> --- a/Documentation/riscv/uabi.rst
> +++ b/Documentation/riscv/uabi.rst
> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>     single-letter extensions and before any higher-privileged extensions.
>  
>  #. For additional standard extensions, the first letter following the 'Z'
> -  conventionally indicates the most closely related alphabetical
> -  extension category. If multiple 'Z' extensions are named, they will be ordered
> -  first by category, in canonical order, as listed above, then alphabetically
> -  within a category.
> +   conventionally indicates the most closely related alphabetical
> +   extension category. If multiple 'Z' extensions are named, they will be
> +   ordered first by category, in canonical order, as listed above, then
> +   alphabetically within a category.
>  
>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>     after standard unprivileged extensions.  If multiple supervisor-level
> -- 
> 2.39.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 2003 bytes --]

Hey Palmer,

If you do end up having WiFi could you pick this up so that the
regressions report thingy stops whining at me?

Thanks!

On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  Documentation/riscv/uabi.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
> index 2ebec4c52230..8960fac42c40 100644
> --- a/Documentation/riscv/uabi.rst
> +++ b/Documentation/riscv/uabi.rst
> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>     single-letter extensions and before any higher-privileged extensions.
>  
>  #. For additional standard extensions, the first letter following the 'Z'
> -  conventionally indicates the most closely related alphabetical
> -  extension category. If multiple 'Z' extensions are named, they will be ordered
> -  first by category, in canonical order, as listed above, then alphabetically
> -  within a category.
> +   conventionally indicates the most closely related alphabetical
> +   extension category. If multiple 'Z' extensions are named, they will be
> +   ordered first by category, in canonical order, as listed above, then
> +   alphabetically within a category.
>  
>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>     after standard unprivileged extensions.  If multiple supervisor-level
> -- 
> 2.39.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Palmer Dabbelt]

On Sun, 29 Jan 2023 23:57:01 +0000, Conor Dooley wrote:
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> 

Applied, thanks!

[1/1] Documentation: riscv: fix insufficient list item indent
      https://git.kernel.org/palmer/c/377804b13d8b

Best regards,
-- 
Palmer Dabbelt <palmer@rivosinc.com>

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Palmer Dabbelt]

On Sun, 29 Jan 2023 23:57:01 +0000, Conor Dooley wrote:
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> 

Applied, thanks!

[1/1] Documentation: riscv: fix insufficient list item indent
      https://git.kernel.org/palmer/c/377804b13d8b

Best regards,
-- 
Palmer Dabbelt <palmer@rivosinc.com>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Palmer Dabbelt]

On Tue, 07 Feb 2023 06:58:54 PST (-0800), Conor Dooley wrote:
> Hey Palmer,
>
> If you do end up having WiFi could you pick this up so that the
> regressions report thingy stops whining at me?

Sorry I forgot about this one, it's on for-next.

>
> Thanks!
>
> On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>> 
>> When adding the ISA string ordering rules, I didn't sufficiently indent
>> one of the list items.
>> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>>  Documentation/riscv/uabi.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
>> index 2ebec4c52230..8960fac42c40 100644
>> --- a/Documentation/riscv/uabi.rst
>> +++ b/Documentation/riscv/uabi.rst
>> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>>     single-letter extensions and before any higher-privileged extensions.
>>  
>>  #. For additional standard extensions, the first letter following the 'Z'
>> -  conventionally indicates the most closely related alphabetical
>> -  extension category. If multiple 'Z' extensions are named, they will be ordered
>> -  first by category, in canonical order, as listed above, then alphabetically
>> -  within a category.
>> +   conventionally indicates the most closely related alphabetical
>> +   extension category. If multiple 'Z' extensions are named, they will be
>> +   ordered first by category, in canonical order, as listed above, then
>> +   alphabetically within a category.
>>  
>>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>>     after standard unprivileged extensions.  If multiple supervisor-level
>> -- 
>> 2.39.1
>> 
>> 
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>> 

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Palmer Dabbelt]

On Tue, 07 Feb 2023 06:58:54 PST (-0800), Conor Dooley wrote:
> Hey Palmer,
>
> If you do end up having WiFi could you pick this up so that the
> regressions report thingy stops whining at me?

Sorry I forgot about this one, it's on for-next.

>
> Thanks!
>
> On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>> 
>> When adding the ISA string ordering rules, I didn't sufficiently indent
>> one of the list items.
>> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>>  Documentation/riscv/uabi.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
>> index 2ebec4c52230..8960fac42c40 100644
>> --- a/Documentation/riscv/uabi.rst
>> +++ b/Documentation/riscv/uabi.rst
>> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>>     single-letter extensions and before any higher-privileged extensions.
>>  
>>  #. For additional standard extensions, the first letter following the 'Z'
>> -  conventionally indicates the most closely related alphabetical
>> -  extension category. If multiple 'Z' extensions are named, they will be ordered
>> -  first by category, in canonical order, as listed above, then alphabetically
>> -  within a category.
>> +   conventionally indicates the most closely related alphabetical
>> +   extension category. If multiple 'Z' extensions are named, they will be
>> +   ordered first by category, in canonical order, as listed above, then
>> +   alphabetically within a category.
>>  
>>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>>     after standard unprivileged extensions.  If multiple supervisor-level
>> -- 
>> 2.39.1
>> 
>> 
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Palmer Dabbelt]

On Sun, 29 Jan 2023 19:05:53 PST (-0800), bagasdotme@gmail.com wrote:
> On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>> 
>> When adding the ISA string ordering rules, I didn't sufficiently indent
>> one of the list items.
>> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>
> Seems like you forget to add link to the report:
>
> Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/

Is that the normal way to do it?  I've only been adding the Reported-by 
like the bot suggests, but I guess it's kind of nice information to have 
the bug report as well.  From looking at git history it's kind of a mix.

Maybe the bot should suggest this in the bug report, right next to the other
tag?

>> ---
>>  Documentation/riscv/uabi.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
>> index 2ebec4c52230..8960fac42c40 100644
>> --- a/Documentation/riscv/uabi.rst
>> +++ b/Documentation/riscv/uabi.rst
>> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>>     single-letter extensions and before any higher-privileged extensions.
>>  
>>  #. For additional standard extensions, the first letter following the 'Z'
>> -  conventionally indicates the most closely related alphabetical
>> -  extension category. If multiple 'Z' extensions are named, they will be ordered
>> -  first by category, in canonical order, as listed above, then alphabetically
>> -  within a category.
>> +   conventionally indicates the most closely related alphabetical
>> +   extension category. If multiple 'Z' extensions are named, they will be
>> +   ordered first by category, in canonical order, as listed above, then
>> +   alphabetically within a category.
>>  
>>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>>     after standard unprivileged extensions.  If multiple supervisor-level
>
> The warning is fixed, thanks!
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
> -- 
> An old man doll... just what I always wanted! - Clara

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Palmer Dabbelt]

On Sun, 29 Jan 2023 19:05:53 PST (-0800), bagasdotme@gmail.com wrote:
> On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>> 
>> When adding the ISA string ordering rules, I didn't sufficiently indent
>> one of the list items.
>> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>
> Seems like you forget to add link to the report:
>
> Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/

Is that the normal way to do it?  I've only been adding the Reported-by 
like the bot suggests, but I guess it's kind of nice information to have 
the bug report as well.  From looking at git history it's kind of a mix.

Maybe the bot should suggest this in the bug report, right next to the other
tag?

>> ---
>>  Documentation/riscv/uabi.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
>> index 2ebec4c52230..8960fac42c40 100644
>> --- a/Documentation/riscv/uabi.rst
>> +++ b/Documentation/riscv/uabi.rst
>> @@ -21,10 +21,10 @@ so for our purposes the following rules apply:
>>     single-letter extensions and before any higher-privileged extensions.
>>  
>>  #. For additional standard extensions, the first letter following the 'Z'
>> -  conventionally indicates the most closely related alphabetical
>> -  extension category. If multiple 'Z' extensions are named, they will be ordered
>> -  first by category, in canonical order, as listed above, then alphabetically
>> -  within a category.
>> +   conventionally indicates the most closely related alphabetical
>> +   extension category. If multiple 'Z' extensions are named, they will be
>> +   ordered first by category, in canonical order, as listed above, then
>> +   alphabetically within a category.
>>  
>>  #. Standard supervisor-level extensions (starting with 'S') will be listed
>>     after standard unprivileged extensions.  If multiple supervisor-level
>
> The warning is fixed, thanks!
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
> -- 
> An old man doll... just what I always wanted! - Clara

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

On Thu, Feb 09, 2023 at 10:48:58AM -0800, Palmer Dabbelt wrote:
> On Sun, 29 Jan 2023 19:05:53 PST (-0800), bagasdotme@gmail.com wrote:
> > On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > > 
> > > When adding the ISA string ordering rules, I didn't sufficiently indent
> > > one of the list items.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > Seems like you forget to add link to the report:
> > 
> > Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/
> 
> Is that the normal way to do it?  I've only been adding the Reported-by like
> the bot suggests, but I guess it's kind of nice information to have the bug
> report as well.  From looking at git history it's kind of a mix.

IMO it totally depends on whether there is something useful in the
thread on lore. I see no point adding the links if they're just a
regurgitation of something conveyed in a commit message.

But then again, I don't bother adding a lore link to patchsets I apply
either. I'm in the Torvald's camp of only using those tags to link to
things containing "actual new information". There was a discussion of
that a while back, see [1] & [2] if you care, although it was largely
born out of frustration at links added by maintainers to original
submissions, not subjectively redundant bot emails.

Following that logic, I didn't bother adding one here, just as I
wouldn't for a compilation error if I included it in the commit log.

We've probably spent more time typing emails about it than the issue
warrants, but that's par for the course I suppose!

1 - https://lore.kernel.org/all/CAHk-=wj9zKJGA_6SJOMPiQEoYke6cKX-FV3X_5zNXOcFJX1kOQ@mail.gmail.com/
2 - https://lore.kernel.org/all/CAHk-=wgzRUT1fBpuz3xcN+YdsX0SxqOzHWRtj0ReHpUBb5TKbA@mail.gmail.com/
> Maybe the bot should suggest this in the bug report, right next to the other
> tag?

Iff the bot knows its own message-id before sending, I think that could
be nice to have. Does Intel's mail system may support that?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 2284 bytes --]

On Thu, Feb 09, 2023 at 10:48:58AM -0800, Palmer Dabbelt wrote:
> On Sun, 29 Jan 2023 19:05:53 PST (-0800), bagasdotme@gmail.com wrote:
> > On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > > 
> > > When adding the ISA string ordering rules, I didn't sufficiently indent
> > > one of the list items.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > Seems like you forget to add link to the report:
> > 
> > Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@intel.com/
> 
> Is that the normal way to do it?  I've only been adding the Reported-by like
> the bot suggests, but I guess it's kind of nice information to have the bug
> report as well.  From looking at git history it's kind of a mix.

IMO it totally depends on whether there is something useful in the
thread on lore. I see no point adding the links if they're just a
regurgitation of something conveyed in a commit message.

But then again, I don't bother adding a lore link to patchsets I apply
either. I'm in the Torvald's camp of only using those tags to link to
things containing "actual new information". There was a discussion of
that a while back, see [1] & [2] if you care, although it was largely
born out of frustration at links added by maintainers to original
submissions, not subjectively redundant bot emails.

Following that logic, I didn't bother adding one here, just as I
wouldn't for a compilation error if I included it in the commit log.

We've probably spent more time typing emails about it than the issue
warrants, but that's par for the course I suppose!

1 - https://lore.kernel.org/all/CAHk-=wj9zKJGA_6SJOMPiQEoYke6cKX-FV3X_5zNXOcFJX1kOQ@mail.gmail.com/
2 - https://lore.kernel.org/all/CAHk-=wgzRUT1fBpuz3xcN+YdsX0SxqOzHWRtj0ReHpUBb5TKbA@mail.gmail.com/
> Maybe the bot should suggest this in the bug report, right next to the other
> tag?

Iff the bot knows its own message-id before sending, I think that could
be nice to have. Does Intel's mail system may support that?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Sun, 29 Jan 2023 23:57:01 +0000 you wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> 
> [...]

Here is the summary with links:
  - Documentation: riscv: fix insufficient list item indent
    https://git.kernel.org/riscv/c/2a5303b499b1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Sun, 29 Jan 2023 23:57:01 +0000 you wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When adding the ISA string ordering rules, I didn't sufficiently indent
> one of the list items.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> 
> [...]

Here is the summary with links:
  - Documentation: riscv: fix insufficient list item indent
    https://git.kernel.org/riscv/c/2a5303b499b1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv