All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
@ 2021-02-05  3:41 ` Palmer Dabbelt
  0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-02-05  3:41 UTC (permalink / raw)
  To: schwab
  Cc: robh+dt, Palmer Dabbelt, Paul Walmsley, aou, sagar.kadam, anup,
	yash.shah, devicetree, linux-riscv, linux-kernel, kernel-team,
	Palmer Dabbelt, stable

From: Palmer Dabbelt <palmerdabbelt@google.com>

VSC8541 phys need a special reset sequence, which the driver doesn't
currentlny support.  As a result enabling the reset via GPIO essentially
guarnteees that the device won't work correctly.

This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.

Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 24d75a146e02..60846e88ae4b 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -90,7 +90,6 @@ &eth0 {
 	phy0: ethernet-phy@0 {
 		compatible = "ethernet-phy-id0007.0771";
 		reg = <0>;
-		reset-gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
 	};
 };
 
-- 
2.30.0.478.g8a0d178c01-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
@ 2021-02-05  3:41 ` Palmer Dabbelt
  0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-02-05  3:41 UTC (permalink / raw)
  To: schwab
  Cc: devicetree, aou, anup, Palmer Dabbelt, linux-kernel, stable,
	yash.shah, robh+dt, Palmer Dabbelt, sagar.kadam, Paul Walmsley,
	linux-riscv, kernel-team

From: Palmer Dabbelt <palmerdabbelt@google.com>

VSC8541 phys need a special reset sequence, which the driver doesn't
currentlny support.  As a result enabling the reset via GPIO essentially
guarnteees that the device won't work correctly.

This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.

Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 24d75a146e02..60846e88ae4b 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -90,7 +90,6 @@ &eth0 {
 	phy0: ethernet-phy@0 {
 		compatible = "ethernet-phy-id0007.0771";
 		reg = <0>;
-		reset-gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
 	};
 };
 
-- 
2.30.0.478.g8a0d178c01-goog


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
  2021-02-05  3:41 ` Palmer Dabbelt
@ 2021-02-10 12:47   ` Andreas Schwab
  -1 siblings, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2021-02-10 12:47 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: devicetree, aou, anup, Palmer Dabbelt, linux-kernel, stable,
	yash.shah, robh+dt, sagar.kadam, Paul Walmsley, linux-riscv,
	kernel-team

On Feb 04 2021, Palmer Dabbelt wrote:

> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> VSC8541 phys need a special reset sequence, which the driver doesn't
> currentlny support.  As a result enabling the reset via GPIO essentially
> guarnteees that the device won't work correctly.
>
> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>
> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
> Cc: stable@vger.kernel.org
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

This fixes ethernet on the HiFive Unleashed with 5.10.12.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
@ 2021-02-10 12:47   ` Andreas Schwab
  0 siblings, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2021-02-10 12:47 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: devicetree, aou, anup, Palmer Dabbelt, linux-kernel, stable,
	yash.shah, robh+dt, sagar.kadam, Paul Walmsley, linux-riscv,
	kernel-team

On Feb 04 2021, Palmer Dabbelt wrote:

> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> VSC8541 phys need a special reset sequence, which the driver doesn't
> currentlny support.  As a result enabling the reset via GPIO essentially
> guarnteees that the device won't work correctly.
>
> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>
> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
> Cc: stable@vger.kernel.org
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

This fixes ethernet on the HiFive Unleashed with 5.10.12.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
  2021-02-10 12:47   ` Andreas Schwab
@ 2021-02-13  0:43     ` Palmer Dabbelt
  -1 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-02-13  0:43 UTC (permalink / raw)
  To: schwab
  Cc: devicetree, aou, anup, linux-kernel, stable, yash.shah, robh+dt,
	sagar.kadam, Paul Walmsley, linux-riscv, kernel-team

On Wed, 10 Feb 2021 04:47:34 PST (-0800), schwab@linux-m68k.org wrote:
> On Feb 04 2021, Palmer Dabbelt wrote:
>
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> VSC8541 phys need a special reset sequence, which the driver doesn't
>> currentlny support.  As a result enabling the reset via GPIO essentially
>> guarnteees that the device won't work correctly.
>>
>> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>>
>> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
>
> This fixes ethernet on the HiFive Unleashed with 5.10.12.

Thanks for testing.  Looks like I forgot to reply, but it's in Linus' tree and 
should end up in stable.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
@ 2021-02-13  0:43     ` Palmer Dabbelt
  0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-02-13  0:43 UTC (permalink / raw)
  To: schwab
  Cc: devicetree, aou, anup, linux-kernel, stable, yash.shah, robh+dt,
	sagar.kadam, Paul Walmsley, linux-riscv, kernel-team

On Wed, 10 Feb 2021 04:47:34 PST (-0800), schwab@linux-m68k.org wrote:
> On Feb 04 2021, Palmer Dabbelt wrote:
>
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> VSC8541 phys need a special reset sequence, which the driver doesn't
>> currentlny support.  As a result enabling the reset via GPIO essentially
>> guarnteees that the device won't work correctly.
>>
>> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>>
>> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
>
> This fixes ethernet on the HiFive Unleashed with 5.10.12.

Thanks for testing.  Looks like I forgot to reply, but it's in Linus' tree and 
should end up in stable.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-13  0:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05  3:41 [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset" Palmer Dabbelt
2021-02-05  3:41 ` Palmer Dabbelt
2021-02-10 12:47 ` Andreas Schwab
2021-02-10 12:47   ` Andreas Schwab
2021-02-13  0:43   ` Palmer Dabbelt
2021-02-13  0:43     ` Palmer Dabbelt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.