All of lore.kernel.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: yamada.masahiro@socionext.com
Cc: aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
	yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig
Date: Thu, 06 Sep 2018 02:45:03 -0700 (PDT)	[thread overview]
Message-ID: <mhng-89887f62-7423-4fcf-9df5-f5777e6644db@palmer-si-x1c4> (raw)
In-Reply-To: <1535099634-29439-1-git-send-email-yamada.masahiro@socionext.com>

On Fri, 24 Aug 2018 01:33:53 PDT (-0700), yamada.masahiro@socionext.com wrote:
> This becomes much neater in Kconfig.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  arch/riscv/Kconfig  | 1 +
>  arch/riscv/Makefile | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a344980..ed81df4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -112,6 +112,7 @@ config ARCH_RV32I
>  config ARCH_RV64I
>  	bool "RV64I"
>  	select 64BIT
> +	select ARCH_SUPPORTS_INT128 if GCC_VERSION >= 50000
>  	select HAVE_FUNCTION_TRACER
>  	select HAVE_FUNCTION_GRAPH_TRACER
>  	select HAVE_FTRACE_MCOUNT_RECORD
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 61ec424..33700e4 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -25,8 +25,6 @@ ifeq ($(CONFIG_ARCH_RV64I),y)
>
>  	KBUILD_CFLAGS += -mabi=lp64
>  	KBUILD_AFLAGS += -mabi=lp64
> -
> -	KBUILD_CFLAGS	+= $(call cc-ifversion, -ge, 0500, -DCONFIG_ARCH_SUPPORTS_INT128)
>
>  	KBUILD_MARCH = rv64im
>  	KBUILD_LDFLAGS += -melf64lriscv

FWIW, while there isn't an official RISC-V GCC port that old (IIRC 6 was our 
first version, but it may have been 7) there are out-of-tree ports so I think 
this is OK to leave as it stands.

WARNING: multiple messages have this Message-ID (diff)
From: palmer@sifive.com (Palmer Dabbelt)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] riscv: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig
Date: Thu, 06 Sep 2018 02:45:03 -0700 (PDT)	[thread overview]
Message-ID: <mhng-89887f62-7423-4fcf-9df5-f5777e6644db@palmer-si-x1c4> (raw)
In-Reply-To: <1535099634-29439-1-git-send-email-yamada.masahiro@socionext.com>

On Fri, 24 Aug 2018 01:33:53 PDT (-0700), yamada.masahiro at socionext.com wrote:
> This becomes much neater in Kconfig.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  arch/riscv/Kconfig  | 1 +
>  arch/riscv/Makefile | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a344980..ed81df4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -112,6 +112,7 @@ config ARCH_RV32I
>  config ARCH_RV64I
>  	bool "RV64I"
>  	select 64BIT
> +	select ARCH_SUPPORTS_INT128 if GCC_VERSION >= 50000
>  	select HAVE_FUNCTION_TRACER
>  	select HAVE_FUNCTION_GRAPH_TRACER
>  	select HAVE_FTRACE_MCOUNT_RECORD
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 61ec424..33700e4 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -25,8 +25,6 @@ ifeq ($(CONFIG_ARCH_RV64I),y)
>
>  	KBUILD_CFLAGS += -mabi=lp64
>  	KBUILD_AFLAGS += -mabi=lp64
> -
> -	KBUILD_CFLAGS	+= $(call cc-ifversion, -ge, 0500, -DCONFIG_ARCH_SUPPORTS_INT128)
>
>  	KBUILD_MARCH = rv64im
>  	KBUILD_LDFLAGS += -melf64lriscv

FWIW, while there isn't an official RISC-V GCC port that old (IIRC 6 was our 
first version, but it may have been 7) there are out-of-tree ports so I think 
this is OK to leave as it stands.

  reply	other threads:[~2018-09-06  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24  8:33 [PATCH] riscv: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig Masahiro Yamada
2018-08-24  8:33 ` Masahiro Yamada
2018-09-06  9:45 ` Palmer Dabbelt [this message]
2018-09-06  9:45   ` Palmer Dabbelt
2018-09-06 10:45   ` Masahiro Yamada
2018-09-06 10:45     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-89887f62-7423-4fcf-9df5-f5777e6644db@palmer-si-x1c4 \
    --to=palmer@sifive.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.