All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] RISC-V: remove the unused return_to_handler export
@ 2018-09-21  6:43 Christoph Hellwig
  2018-10-09 16:15   ` Christoph Hellwig
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2018-09-21  6:43 UTC (permalink / raw)
  To: linux-riscv

This export is not only not needed, but also breaks symbol versioning
due to being an undeclared assembly export.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/riscv/kernel/mcount.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kernel/mcount.S b/arch/riscv/kernel/mcount.S
index 5721624886a1..8a5593ff9ff3 100644
--- a/arch/riscv/kernel/mcount.S
+++ b/arch/riscv/kernel/mcount.S
@@ -75,7 +75,6 @@ ENTRY(return_to_handler)
 	RESTORE_RET_ABI_STATE
 	jalr	a1
 ENDPROC(return_to_handler)
-EXPORT_SYMBOL(return_to_handler)
 #endif
 
 #ifndef CONFIG_DYNAMIC_FTRACE
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] RISC-V: remove the unused return_to_handler export
@ 2018-10-09 16:15   ` Christoph Hellwig
  0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2018-10-09 16:15 UTC (permalink / raw)
  To: linux-riscv

ping?

On Fri, Sep 21, 2018 at 08:43:21AM +0200, Christoph Hellwig wrote:
> This export is not only not needed, but also breaks symbol versioning
> due to being an undeclared assembly export.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/riscv/kernel/mcount.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/mcount.S b/arch/riscv/kernel/mcount.S
> index 5721624886a1..8a5593ff9ff3 100644
> --- a/arch/riscv/kernel/mcount.S
> +++ b/arch/riscv/kernel/mcount.S
> @@ -75,7 +75,6 @@ ENTRY(return_to_handler)
>  	RESTORE_RET_ABI_STATE
>  	jalr	a1
>  ENDPROC(return_to_handler)
> -EXPORT_SYMBOL(return_to_handler)
>  #endif
>  
>  #ifndef CONFIG_DYNAMIC_FTRACE
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
---end quoted text---

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] RISC-V: remove the unused return_to_handler export
@ 2018-10-09 16:15   ` Christoph Hellwig
  0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2018-10-09 16:15 UTC (permalink / raw)
  To: palmer; +Cc: linux-riscv

ping?

On Fri, Sep 21, 2018 at 08:43:21AM +0200, Christoph Hellwig wrote:
> This export is not only not needed, but also breaks symbol versioning
> due to being an undeclared assembly export.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/riscv/kernel/mcount.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/mcount.S b/arch/riscv/kernel/mcount.S
> index 5721624886a1..8a5593ff9ff3 100644
> --- a/arch/riscv/kernel/mcount.S
> +++ b/arch/riscv/kernel/mcount.S
> @@ -75,7 +75,6 @@ ENTRY(return_to_handler)
>  	RESTORE_RET_ABI_STATE
>  	jalr	a1
>  ENDPROC(return_to_handler)
> -EXPORT_SYMBOL(return_to_handler)
>  #endif
>  
>  #ifndef CONFIG_DYNAMIC_FTRACE
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
---end quoted text---

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] RISC-V: remove the unused return_to_handler export
@ 2018-10-09 17:39     ` Palmer Dabbelt
  0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-10-09 17:39 UTC (permalink / raw)
  To: linux-riscv

Sorry, this must have gotten lost.  It'll be in for-next soon.

On Tue, 09 Oct 2018 09:15:33 PDT (-0700), Christoph Hellwig wrote:
> ping?
>
> On Fri, Sep 21, 2018 at 08:43:21AM +0200, Christoph Hellwig wrote:
>> This export is not only not needed, but also breaks symbol versioning
>> due to being an undeclared assembly export.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>>  arch/riscv/kernel/mcount.S | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/riscv/kernel/mcount.S b/arch/riscv/kernel/mcount.S
>> index 5721624886a1..8a5593ff9ff3 100644
>> --- a/arch/riscv/kernel/mcount.S
>> +++ b/arch/riscv/kernel/mcount.S
>> @@ -75,7 +75,6 @@ ENTRY(return_to_handler)
>>  	RESTORE_RET_ABI_STATE
>>  	jalr	a1
>>  ENDPROC(return_to_handler)
>> -EXPORT_SYMBOL(return_to_handler)
>>  #endif
>>
>>  #ifndef CONFIG_DYNAMIC_FTRACE
>> --
>> 2.18.0
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
> ---end quoted text---

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] RISC-V: remove the unused return_to_handler export
@ 2018-10-09 17:39     ` Palmer Dabbelt
  0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-10-09 17:39 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-riscv

Sorry, this must have gotten lost.  It'll be in for-next soon.

On Tue, 09 Oct 2018 09:15:33 PDT (-0700), Christoph Hellwig wrote:
> ping?
>
> On Fri, Sep 21, 2018 at 08:43:21AM +0200, Christoph Hellwig wrote:
>> This export is not only not needed, but also breaks symbol versioning
>> due to being an undeclared assembly export.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>>  arch/riscv/kernel/mcount.S | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/riscv/kernel/mcount.S b/arch/riscv/kernel/mcount.S
>> index 5721624886a1..8a5593ff9ff3 100644
>> --- a/arch/riscv/kernel/mcount.S
>> +++ b/arch/riscv/kernel/mcount.S
>> @@ -75,7 +75,6 @@ ENTRY(return_to_handler)
>>  	RESTORE_RET_ABI_STATE
>>  	jalr	a1
>>  ENDPROC(return_to_handler)
>> -EXPORT_SYMBOL(return_to_handler)
>>  #endif
>>
>>  #ifndef CONFIG_DYNAMIC_FTRACE
>> --
>> 2.18.0
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
> ---end quoted text---

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-10-09 18:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21  6:43 [PATCH] RISC-V: remove the unused return_to_handler export Christoph Hellwig
2018-10-09 16:15 ` Christoph Hellwig
2018-10-09 16:15   ` Christoph Hellwig
2018-10-09 17:39   ` Palmer Dabbelt
2018-10-09 17:39     ` Palmer Dabbelt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.