All of lore.kernel.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@rivosinc.com>
To: heiko@sntech.de
Cc: linux-riscv@lists.infradead.org, stable@vger.kernel.org,
	lkp@intel.com, conor.dooley@microchip.com
Subject: Re: [PATCH] RISC-V: Avoid coupling the T-Head CMOs and Zicbom
Date: Fri, 16 Sep 2022 03:13:54 -0700 (PDT)	[thread overview]
Message-ID: <mhng-ccfa026e-f1ec-4266-bda0-5cf07d7b47a3@palmer-ri-x1c9> (raw)
In-Reply-To: <2123713.Mh6RI2rZIc@phil>

On Thu, 15 Sep 2022 14:15:13 PDT (-0700), heiko@sntech.de wrote:
> Am Donnerstag, 15. September 2022, 19:09:00 CEST schrieb Palmer Dabbelt:
>> We could make the T-Head CMOs depend on a new-enough assembler to have
>> Zicbom, but it's not strictly necessary because the T-Head CMOs
>> circumvent the assembler.
>>
>> Fixes: 8f7e001e0325 ("RISC-V: Clean up the Zicbom block size probing")
>> Cc: stable@vger.kernel.org
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Conor Dooley <conor.dooley@microchip.com>
>> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks, this is on fixes (a little late this week due to the 
conferences, but I'm still hoping for rc6).

>
>> ---
>>  arch/riscv/include/asm/cacheflush.h | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/include/asm/cacheflush.h b/arch/riscv/include/asm/cacheflush.h
>> index a89c005b4bbf..273ece6b622f 100644
>> --- a/arch/riscv/include/asm/cacheflush.h
>> +++ b/arch/riscv/include/asm/cacheflush.h
>> @@ -42,8 +42,12 @@ void flush_icache_mm(struct mm_struct *mm, bool local);
>>
>>  #endif /* CONFIG_SMP */
>>
>> -#ifdef CONFIG_RISCV_ISA_ZICBOM
>> +/*
>> + * The T-Head CMO errata internally probe the CBOM block size, but otherwise
>> + * don't depend on Zicbom.
>> + */
>>  extern unsigned int riscv_cbom_block_size;
>> +#ifdef CONFIG_RISCV_ISA_ZICBOM
>>  void riscv_init_cbom_blocksize(void);
>>  #else
>>  static inline void riscv_init_cbom_blocksize(void) { }
>>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@rivosinc.com>
To: heiko@sntech.de
Cc: linux-riscv@lists.infradead.org, stable@vger.kernel.org,
	lkp@intel.com, conor.dooley@microchip.com
Subject: Re: [PATCH] RISC-V: Avoid coupling the T-Head CMOs and Zicbom
Date: Fri, 16 Sep 2022 03:13:54 -0700 (PDT)	[thread overview]
Message-ID: <mhng-ccfa026e-f1ec-4266-bda0-5cf07d7b47a3@palmer-ri-x1c9> (raw)
In-Reply-To: <2123713.Mh6RI2rZIc@phil>

On Thu, 15 Sep 2022 14:15:13 PDT (-0700), heiko@sntech.de wrote:
> Am Donnerstag, 15. September 2022, 19:09:00 CEST schrieb Palmer Dabbelt:
>> We could make the T-Head CMOs depend on a new-enough assembler to have
>> Zicbom, but it's not strictly necessary because the T-Head CMOs
>> circumvent the assembler.
>>
>> Fixes: 8f7e001e0325 ("RISC-V: Clean up the Zicbom block size probing")
>> Cc: stable@vger.kernel.org
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Conor Dooley <conor.dooley@microchip.com>
>> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks, this is on fixes (a little late this week due to the 
conferences, but I'm still hoping for rc6).

>
>> ---
>>  arch/riscv/include/asm/cacheflush.h | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/include/asm/cacheflush.h b/arch/riscv/include/asm/cacheflush.h
>> index a89c005b4bbf..273ece6b622f 100644
>> --- a/arch/riscv/include/asm/cacheflush.h
>> +++ b/arch/riscv/include/asm/cacheflush.h
>> @@ -42,8 +42,12 @@ void flush_icache_mm(struct mm_struct *mm, bool local);
>>
>>  #endif /* CONFIG_SMP */
>>
>> -#ifdef CONFIG_RISCV_ISA_ZICBOM
>> +/*
>> + * The T-Head CMO errata internally probe the CBOM block size, but otherwise
>> + * don't depend on Zicbom.
>> + */
>>  extern unsigned int riscv_cbom_block_size;
>> +#ifdef CONFIG_RISCV_ISA_ZICBOM
>>  void riscv_init_cbom_blocksize(void);
>>  #else
>>  static inline void riscv_init_cbom_blocksize(void) { }
>>

  reply	other threads:[~2022-09-16 10:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 17:09 [PATCH] RISC-V: Avoid coupling the T-Head CMOs and Zicbom Palmer Dabbelt
2022-09-15 17:09 ` Palmer Dabbelt
2022-09-15 17:13 ` Conor.Dooley
2022-09-15 17:13   ` Conor.Dooley
2022-09-16 12:22   ` Conor.Dooley
2022-09-16 12:22     ` Conor.Dooley
2022-09-17 14:41     ` Palmer Dabbelt
2022-09-17 14:41       ` Palmer Dabbelt
2022-09-17 14:54       ` Conor Dooley
2022-09-17 14:54         ` Conor Dooley
2022-09-15 21:15 ` Heiko Stuebner
2022-09-15 21:15   ` Heiko Stuebner
2022-09-16 10:13   ` Palmer Dabbelt [this message]
2022-09-16 10:13     ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-ccfa026e-f1ec-4266-bda0-5cf07d7b47a3@palmer-ri-x1c9 \
    --to=palmer@rivosinc.com \
    --cc=conor.dooley@microchip.com \
    --cc=heiko@sntech.de \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.