* [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
@ 2021-12-29 19:24 ` Lukas Bulwahn
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2021-12-29 19:24 UTC (permalink / raw)
To: Damien Le Moal, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
The config SYSCON never existed in the kernel repository; so, the select of
that config in ./drivers/soc/canaan/Kconfig has no effect.
Presumably, this was just some mistake, assuming some symmetry in handling
and naming of configs that simply does not exist.
Remove this useless select of a non-existing config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/soc/canaan/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
index 853096b7e84c..2527cf5757ec 100644
--- a/drivers/soc/canaan/Kconfig
+++ b/drivers/soc/canaan/Kconfig
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
depends on RISCV && SOC_CANAAN && OF
default SOC_CANAAN
select PM
- select SYSCON
select MFD_SYSCON
help
Canaan Kendryte K210 SoC system controller driver.
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
@ 2021-12-29 19:24 ` Lukas Bulwahn
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2021-12-29 19:24 UTC (permalink / raw)
To: Damien Le Moal, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
The config SYSCON never existed in the kernel repository; so, the select of
that config in ./drivers/soc/canaan/Kconfig has no effect.
Presumably, this was just some mistake, assuming some symmetry in handling
and naming of configs that simply does not exist.
Remove this useless select of a non-existing config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/soc/canaan/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
index 853096b7e84c..2527cf5757ec 100644
--- a/drivers/soc/canaan/Kconfig
+++ b/drivers/soc/canaan/Kconfig
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
depends on RISCV && SOC_CANAAN && OF
default SOC_CANAAN
select PM
- select SYSCON
select MFD_SYSCON
help
Canaan Kendryte K210 SoC system controller driver.
--
2.17.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
2021-12-29 19:24 ` Lukas Bulwahn
@ 2021-12-30 5:23 ` Damien Le Moal
-1 siblings, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2021-12-30 5:23 UTC (permalink / raw)
To: paul.walmsley, palmer, linux-riscv, lukas.bulwahn, aou
Cc: kernel-janitors, linux-kernel
On Wed, 2021-12-29 at 20:24 +0100, Lukas Bulwahn wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.
My bad :)
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
@ 2021-12-30 5:23 ` Damien Le Moal
0 siblings, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2021-12-30 5:23 UTC (permalink / raw)
To: paul.walmsley, palmer, linux-riscv, lukas.bulwahn, aou
Cc: kernel-janitors, linux-kernel
On Wed, 2021-12-29 at 20:24 +0100, Lukas Bulwahn wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.
My bad :)
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
2021-12-29 19:24 ` Lukas Bulwahn
@ 2022-01-20 18:17 ` Palmer Dabbelt
-1 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2022-01-20 18:17 UTC (permalink / raw)
To: lukas.bulwahn
Cc: damien.lemoal, Paul Walmsley, aou, linux-riscv, kernel-janitors,
linux-kernel, lukas.bulwahn
On Wed, 29 Dec 2021 11:24:58 PST (-0800), lukas.bulwahn@gmail.com wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.
Thanks, this is on for-next.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
@ 2022-01-20 18:17 ` Palmer Dabbelt
0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2022-01-20 18:17 UTC (permalink / raw)
To: lukas.bulwahn
Cc: damien.lemoal, Paul Walmsley, aou, linux-riscv, kernel-janitors,
linux-kernel, lukas.bulwahn
On Wed, 29 Dec 2021 11:24:58 PST (-0800), lukas.bulwahn@gmail.com wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.
Thanks, this is on for-next.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-20 18:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-29 19:24 [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON Lukas Bulwahn
2021-12-29 19:24 ` Lukas Bulwahn
2021-12-30 5:23 ` Damien Le Moal
2021-12-30 5:23 ` Damien Le Moal
2022-01-20 18:17 ` Palmer Dabbelt
2022-01-20 18:17 ` Palmer Dabbelt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.