* [PATCH] riscv: disable stack-protector for vDSO
@ 2020-07-29 7:51 Tobias Klauser
2020-07-31 3:58 ` Palmer Dabbelt
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2020-07-29 7:51 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Albert Ou; +Cc: linux-riscv, Palmer Dabbelt
Currently, building the vDSO with clang leads assembler errors like the
following:
/tmp/vgettimeofday-1ae0d2.s: Assembler messages:
/tmp/vgettimeofday-1ae0d2.s:28: Error: bad expression
/tmp/vgettimeofday-1ae0d2.s:28: Error: illegal operands `auipc a2,%got_pcrel_hi(__stack_chk_guard)'
Disable the stack-protector for vDSO to fix these.
Link: https://github.com/ClangBuiltLinux/linux/issues/1112
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
arch/riscv/kernel/vdso/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
index c8c9e40023c6..478e7338ddc1 100644
--- a/arch/riscv/kernel/vdso/Makefile
+++ b/arch/riscv/kernel/vdso/Makefile
@@ -16,6 +16,8 @@ vdso-syms += flush_icache
# Files to link into the vdso
obj-vdso = $(patsubst %, %.o, $(vdso-syms)) note.o
+ccflags-y := -fno-stack-protector
+
ifneq ($(c-gettimeofday-y),)
CFLAGS_vgettimeofday.o += -fPIC -include $(c-gettimeofday-y)
endif
--
2.27.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] riscv: disable stack-protector for vDSO
2020-07-29 7:51 [PATCH] riscv: disable stack-protector for vDSO Tobias Klauser
@ 2020-07-31 3:58 ` Palmer Dabbelt
0 siblings, 0 replies; 2+ messages in thread
From: Palmer Dabbelt @ 2020-07-31 3:58 UTC (permalink / raw)
To: tklauser; +Cc: linux-riscv, aou, Paul Walmsley
On Wed, 29 Jul 2020 00:51:29 PDT (-0700), tklauser@distanz.ch wrote:
> Currently, building the vDSO with clang leads assembler errors like the
> following:
>
> /tmp/vgettimeofday-1ae0d2.s: Assembler messages:
> /tmp/vgettimeofday-1ae0d2.s:28: Error: bad expression
> /tmp/vgettimeofday-1ae0d2.s:28: Error: illegal operands `auipc a2,%got_pcrel_hi(__stack_chk_guard)'
>
> Disable the stack-protector for vDSO to fix these.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1112
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> arch/riscv/kernel/vdso/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
> index c8c9e40023c6..478e7338ddc1 100644
> --- a/arch/riscv/kernel/vdso/Makefile
> +++ b/arch/riscv/kernel/vdso/Makefile
> @@ -16,6 +16,8 @@ vdso-syms += flush_icache
> # Files to link into the vdso
> obj-vdso = $(patsubst %, %.o, $(vdso-syms)) note.o
>
> +ccflags-y := -fno-stack-protector
> +
> ifneq ($(c-gettimeofday-y),)
> CFLAGS_vgettimeofday.o += -fPIC -include $(c-gettimeofday-y)
> endif
Thanks, this is on fixes.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-31 3:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 7:51 [PATCH] riscv: disable stack-protector for vDSO Tobias Klauser
2020-07-31 3:58 ` Palmer Dabbelt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.