From: Palmer Dabbelt <palmer@dabbelt.com> To: zong.li@sifive.com Cc: mturquette@baylibre.com, sboyd@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>, lee.jones@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, zong.li@sifive.com Subject: Re: [PATCH 0/4] Refactor the PRCI driver to reduce the complexity Date: Fri, 04 Feb 2022 10:56:21 -0800 (PST) [thread overview] Message-ID: <mhng-ffd770d4-8f8a-417a-a589-f14d09f55282@palmer-ri-x1c9> (raw) In-Reply-To: <cover.1642582832.git.zong.li@sifive.com> On Wed, 19 Jan 2022 01:28:37 PST (-0800), zong.li@sifive.com wrote: > This patch set tries to improve the PRCI driver to reduce the > complexity, we remove the SoCs C files by putting putting all stuff in > each SoCs header file, and include these SoCs-specific header files in > core of PRCI. It can also avoid the W=1 kernel build warnings about > variable defined but not used [-Wunused-const-variable=], like 'commit > 487dc7bb6a0c ("clk: sifive:fu540-prci: Declare static const variable > 'prci_clk_fu540' where it's used")' does. > > This patch set also contains the dt-bindings and dts change, because > we change the macro name for fu540 and fu740 by adding the prefix > respectively. > > Thanks all for your review and suggestions. > > Zong Li (4): > dt-bindings: change the macro name of prci in header files and example > riscv: dts: Change the macro name of prci in each device node > clk: sifive: Add SoCs prefix in each SoCs-dependent data IIUC these there aren't bisectable: the bindings change will break builds of the DTs and drivers. I'm not sure what's generally the way to go with these, but I always try to avoid broken builds in the middle of patch sets. Aside from that this generally looks good to me, but the DT and clock folks are probably a better bet for a proper review here. Happy to take this through the RISC-V tree, but IMO it's a better candidate for the clock tree so Acked-by: Palmer Dabbelt <palmer@rivosinc.com> # aside from breaking bisect Thanks! > clk: sifive: Move all stuff into SoCs header files from C files > > .../devicetree/bindings/gpio/sifive,gpio.yaml | 2 +- > .../bindings/pci/sifive,fu740-pcie.yaml | 2 +- > .../bindings/serial/sifive-serial.yaml | 2 +- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 22 +-- > arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 26 ++-- > drivers/clk/sifive/Makefile | 2 +- > drivers/clk/sifive/fu540-prci.c | 89 ------------ > drivers/clk/sifive/fu540-prci.h | 91 +++++++++++- > drivers/clk/sifive/fu740-prci.c | 134 ------------------ > drivers/clk/sifive/fu740-prci.h | 130 ++++++++++++++++- > drivers/clk/sifive/sifive-prci.c | 5 - > include/dt-bindings/clock/sifive-fu540-prci.h | 8 +- > include/dt-bindings/clock/sifive-fu740-prci.h | 18 +-- > 13 files changed, 254 insertions(+), 277 deletions(-) > delete mode 100644 drivers/clk/sifive/fu540-prci.c > delete mode 100644 drivers/clk/sifive/fu740-prci.c _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com> To: zong.li@sifive.com Cc: mturquette@baylibre.com, sboyd@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>, lee.jones@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, zong.li@sifive.com Subject: Re: [PATCH 0/4] Refactor the PRCI driver to reduce the complexity Date: Fri, 04 Feb 2022 10:56:21 -0800 (PST) [thread overview] Message-ID: <mhng-ffd770d4-8f8a-417a-a589-f14d09f55282@palmer-ri-x1c9> (raw) In-Reply-To: <cover.1642582832.git.zong.li@sifive.com> On Wed, 19 Jan 2022 01:28:37 PST (-0800), zong.li@sifive.com wrote: > This patch set tries to improve the PRCI driver to reduce the > complexity, we remove the SoCs C files by putting putting all stuff in > each SoCs header file, and include these SoCs-specific header files in > core of PRCI. It can also avoid the W=1 kernel build warnings about > variable defined but not used [-Wunused-const-variable=], like 'commit > 487dc7bb6a0c ("clk: sifive:fu540-prci: Declare static const variable > 'prci_clk_fu540' where it's used")' does. > > This patch set also contains the dt-bindings and dts change, because > we change the macro name for fu540 and fu740 by adding the prefix > respectively. > > Thanks all for your review and suggestions. > > Zong Li (4): > dt-bindings: change the macro name of prci in header files and example > riscv: dts: Change the macro name of prci in each device node > clk: sifive: Add SoCs prefix in each SoCs-dependent data IIUC these there aren't bisectable: the bindings change will break builds of the DTs and drivers. I'm not sure what's generally the way to go with these, but I always try to avoid broken builds in the middle of patch sets. Aside from that this generally looks good to me, but the DT and clock folks are probably a better bet for a proper review here. Happy to take this through the RISC-V tree, but IMO it's a better candidate for the clock tree so Acked-by: Palmer Dabbelt <palmer@rivosinc.com> # aside from breaking bisect Thanks! > clk: sifive: Move all stuff into SoCs header files from C files > > .../devicetree/bindings/gpio/sifive,gpio.yaml | 2 +- > .../bindings/pci/sifive,fu740-pcie.yaml | 2 +- > .../bindings/serial/sifive-serial.yaml | 2 +- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 22 +-- > arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 26 ++-- > drivers/clk/sifive/Makefile | 2 +- > drivers/clk/sifive/fu540-prci.c | 89 ------------ > drivers/clk/sifive/fu540-prci.h | 91 +++++++++++- > drivers/clk/sifive/fu740-prci.c | 134 ------------------ > drivers/clk/sifive/fu740-prci.h | 130 ++++++++++++++++- > drivers/clk/sifive/sifive-prci.c | 5 - > include/dt-bindings/clock/sifive-fu540-prci.h | 8 +- > include/dt-bindings/clock/sifive-fu740-prci.h | 18 +-- > 13 files changed, 254 insertions(+), 277 deletions(-) > delete mode 100644 drivers/clk/sifive/fu540-prci.c > delete mode 100644 drivers/clk/sifive/fu740-prci.c
next prev parent reply other threads:[~2022-02-04 18:56 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-19 9:28 [PATCH 0/4] Refactor the PRCI driver to reduce the complexity Zong Li 2022-01-19 9:28 ` Zong Li 2022-01-19 9:28 ` [PATCH 1/4] dt-bindings: change the macro name of prci in header files and example Zong Li 2022-01-19 9:28 ` Zong Li 2022-02-09 2:56 ` Rob Herring 2022-02-09 2:56 ` Rob Herring 2022-01-19 9:28 ` [PATCH 2/4] riscv: dts: Change the macro name of prci in each device node Zong Li 2022-01-19 9:28 ` Zong Li 2022-01-19 9:28 ` [PATCH 3/4] clk: sifive: Add SoCs prefix in each SoCs-dependent data Zong Li 2022-01-19 9:28 ` Zong Li 2022-01-19 9:28 ` [PATCH 4/4] clk: sifive: Move all stuff into SoCs header files from C files Zong Li 2022-01-19 9:28 ` Zong Li 2022-01-19 11:02 ` Lee Jones 2022-01-19 11:02 ` Lee Jones 2022-01-25 5:12 ` [PATCH 0/4] Refactor the PRCI driver to reduce the complexity Zong Li 2022-01-25 5:12 ` Zong Li 2022-02-04 18:56 ` Palmer Dabbelt [this message] 2022-02-04 18:56 ` Palmer Dabbelt 2022-02-07 5:21 ` Zong Li 2022-02-07 5:21 ` Zong Li [not found] ` <20220218222339.9BF5CC340E9@smtp.kernel.org> 2022-02-23 7:33 ` Zong Li 2022-02-23 7:33 ` Zong Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=mhng-ffd770d4-8f8a-417a-a589-f14d09f55282@palmer-ri-x1c9 \ --to=palmer@dabbelt.com \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mturquette@baylibre.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=zong.li@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.