* [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build
@ 2021-08-09 13:02 Andreas Schwab
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2021-08-09 13:02 UTC (permalink / raw)
To: u-boot; +Cc: Pragnesh Patel, Bhargav Shah
CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
in an SPL build. For non-SPL builds, crc16.o is already added
unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the
sifive board configs, which is only relevant for some ARM boards and was
only set for its side effect of adding crc16.o.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
configs/sifive_unleashed_defconfig | 1 -
configs/sifive_unmatched_defconfig | 1 -
lib/Makefile | 1 +
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/configs/sifive_unleashed_defconfig b/configs/sifive_unleashed_defconfig
index fd686dfadc..d6448dbf5e 100644
--- a/configs/sifive_unleashed_defconfig
+++ b/configs/sifive_unleashed_defconfig
@@ -22,7 +22,6 @@ CONFIG_SPL_SEPARATE_BSS=y
CONFIG_SPL_DM_SPI_FLASH=y
CONFIG_SPL_DM_RESET=y
CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_SPL_CLK=y
diff --git a/configs/sifive_unmatched_defconfig b/configs/sifive_unmatched_defconfig
index 38b7acd536..d37c019cda 100644
--- a/configs/sifive_unmatched_defconfig
+++ b/configs/sifive_unmatched_defconfig
@@ -20,7 +20,6 @@ CONFIG_DISPLAY_BOARDINFO=y
CONFIG_DISPLAY_BOARDINFO_LATE=y
CONFIG_SPL_SEPARATE_BSS=y
CONFIG_SPL_DM_RESET=y
-CONFIG_SPL_YMODEM_SUPPORT=y
CONFIG_CMD_EEPROM=y
CONFIG_CMD_MEMINFO=y
CONFIG_CMD_PWM=y
diff --git a/lib/Makefile b/lib/Makefile
index 07c2ccd7cf..7ae2ccf537 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -87,6 +87,7 @@ endif
ifdef CONFIG_SPL_BUILD
obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o
obj-$(CONFIG_$(SPL_TPL_)HASH_SUPPORT) += crc16.o
+obj-$(CONFIG_MMC_SPI_CRC_ON) += crc16.o
obj-y += net_utils.o
endif
obj-$(CONFIG_ADDR_MAP) += addr_map.o
--
2.32.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build
2021-09-03 0:52 ` Bin Meng
@ 2021-09-03 0:54 ` Tom Rini
0 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2021-09-03 0:54 UTC (permalink / raw)
To: Bin Meng
Cc: Andreas Schwab, U-Boot Mailing List, Pragnesh Patel, Bhargav Shah
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Fri, Sep 03, 2021 at 08:52:18AM +0800, Bin Meng wrote:
> On Fri, Sep 3, 2021 at 6:42 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:
> >
> > > CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> > > in an SPL build. For non-SPL builds, crc16.o is already added
> > > unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> > > sifive board configs, which is only relevant for some ARM boards and was
> > > only set for its side effect of adding crc16.o.
> >
> > Applied to u-boot/next, thanks!
>
> I thought I replied this email, but it seems not.
>
> This patch is missing SoB tag.
Yes, I also saw, but it's also small / obvious enough that it's not
worrisome. By which I also mean, if you check through the linux kernel,
there's still an occasional no-SoB tag commit. Not often, but non-zero.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build
2021-09-02 22:42 ` Tom Rini
@ 2021-09-03 0:52 ` Bin Meng
2021-09-03 0:54 ` Tom Rini
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2021-09-03 0:52 UTC (permalink / raw)
To: Tom Rini
Cc: Andreas Schwab, U-Boot Mailing List, Pragnesh Patel, Bhargav Shah
On Fri, Sep 3, 2021 at 6:42 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:
>
> > CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> > in an SPL build. For non-SPL builds, crc16.o is already added
> > unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> > sifive board configs, which is only relevant for some ARM boards and was
> > only set for its side effect of adding crc16.o.
>
> Applied to u-boot/next, thanks!
I thought I replied this email, but it seems not.
This patch is missing SoB tag.
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build
2021-08-17 10:51 Andreas Schwab
@ 2021-09-02 22:42 ` Tom Rini
2021-09-03 0:52 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2021-09-02 22:42 UTC (permalink / raw)
To: Andreas Schwab; +Cc: u-boot, Pragnesh Patel, Bhargav Shah, Bin Meng
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:
> CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> in an SPL build. For non-SPL builds, crc16.o is already added
> unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> sifive board configs, which is only relevant for some ARM boards and was
> only set for its side effect of adding crc16.o.
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build
@ 2021-08-17 10:51 Andreas Schwab
2021-09-02 22:42 ` Tom Rini
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2021-08-17 10:51 UTC (permalink / raw)
To: u-boot; +Cc: Pragnesh Patel, Bhargav Shah, Bin Meng
CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
in an SPL build. For non-SPL builds, crc16.o is already added
unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the
sifive board configs, which is only relevant for some ARM boards and was
only set for its side effect of adding crc16.o.
---
configs/sifive_unleashed_defconfig | 1 -
configs/sifive_unmatched_defconfig | 1 -
lib/Makefile | 1 +
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/configs/sifive_unleashed_defconfig b/configs/sifive_unleashed_defconfig
index fd686dfadc..d6448dbf5e 100644
--- a/configs/sifive_unleashed_defconfig
+++ b/configs/sifive_unleashed_defconfig
@@ -22,7 +22,6 @@ CONFIG_SPL_SEPARATE_BSS=y
CONFIG_SPL_DM_SPI_FLASH=y
CONFIG_SPL_DM_RESET=y
CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_SPL_CLK=y
diff --git a/configs/sifive_unmatched_defconfig b/configs/sifive_unmatched_defconfig
index 6c40a35bc2..59c4a383e0 100644
--- a/configs/sifive_unmatched_defconfig
+++ b/configs/sifive_unmatched_defconfig
@@ -20,7 +20,6 @@ CONFIG_DISPLAY_BOARDINFO=y
CONFIG_DISPLAY_BOARDINFO_LATE=y
CONFIG_SPL_SEPARATE_BSS=y
CONFIG_SPL_DM_RESET=y
-CONFIG_SPL_YMODEM_SUPPORT=y
CONFIG_CMD_EEPROM=y
CONFIG_CMD_MEMINFO=y
CONFIG_CMD_PWM=y
diff --git a/lib/Makefile b/lib/Makefile
index 8ba745faa0..2d29cdad1e 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -88,6 +88,7 @@ endif
ifdef CONFIG_SPL_BUILD
obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o
obj-$(CONFIG_$(SPL_TPL_)HASH_SUPPORT) += crc16.o
+obj-$(CONFIG_MMC_SPI_CRC_ON) += crc16.o
obj-y += net_utils.o
endif
obj-$(CONFIG_ADDR_MAP) += addr_map.o
--
2.33.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-03 0:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 13:02 [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build Andreas Schwab
2021-08-17 10:51 Andreas Schwab
2021-09-02 22:42 ` Tom Rini
2021-09-03 0:52 ` Bin Meng
2021-09-03 0:54 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.