* [PATCH] omap3: beagle: Fix USB host port power control
@ 2009-10-24 7:59 Jarkko Nikula
2009-11-03 14:11 ` Koen Kooi
2009-11-09 23:54 ` [APPLIED] " Tony Lindgren
0 siblings, 2 replies; 5+ messages in thread
From: Jarkko Nikula @ 2009-10-24 7:59 UTC (permalink / raw)
To: linux-omap; +Cc: Jarkko Nikula, Steve Sakoman
The host port power is enabled by driving the nEN_USB_PWR low as stated in
the comment. This fix is originally from Steve Sakoman <steve@sakoman.com>.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Steve Sakoman <steve@sakoman.com>
---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 6cb99f6..7ad9846 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device *dev,
/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
- gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+ gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3: beagle: Fix USB host port power control
2009-10-24 7:59 [PATCH] omap3: beagle: Fix USB host port power control Jarkko Nikula
@ 2009-11-03 14:11 ` Koen Kooi
2009-11-03 17:21 ` Tony Lindgren
2009-11-04 2:22 ` Sid Boyce
2009-11-09 23:54 ` [APPLIED] " Tony Lindgren
1 sibling, 2 replies; 5+ messages in thread
From: Koen Kooi @ 2009-11-03 14:11 UTC (permalink / raw)
To: linux-omap@vger.kernel.org List
Any comments on this, I need this on beagleboard to make ehci work.
regards,
Koen
Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:
> The host port power is enabled by driving the nEN_USB_PWR low as
> stated in
> the comment. This fix is originally from Steve Sakoman <steve@sakoman.com
> >.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Steve Sakoman <steve@sakoman.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-
> omap2/board-omap3beagle.c
> index 6cb99f6..7ad9846 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device
> *dev,
>
> /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low)
> */
> gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
> - gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
> + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
>
> /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
> gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3: beagle: Fix USB host port power control
2009-11-03 14:11 ` Koen Kooi
@ 2009-11-03 17:21 ` Tony Lindgren
2009-11-04 2:22 ` Sid Boyce
1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2009-11-03 17:21 UTC (permalink / raw)
To: Koen Kooi; +Cc: linux-omap@vger.kernel.org List
* Koen Kooi <k.kooi@student.utwente.nl> [091103 06:11]:
> Any comments on this, I need this on beagleboard to make ehci work.
Looks like a fix to me, will queue.
Tony
> regards,
>
> Koen
>
> Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:
>
> >The host port power is enabled by driving the nEN_USB_PWR low as
> >stated in
> >the comment. This fix is originally from Steve Sakoman
> ><steve@sakoman.com>.
> >
> >Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> >Cc: Steve Sakoman <steve@sakoman.com>
> >---
> >arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
> >1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
> >b/arch/arm/mach-omap2/board-omap3beagle.c
> >index 6cb99f6..7ad9846 100644
> >--- a/arch/arm/mach-omap2/board-omap3beagle.c
> >+++ b/arch/arm/mach-omap2/board-omap3beagle.c
> >@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device
> >*dev,
> >
> > /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active
> >low) */
> > gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
> >- gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
> >+ gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> >
> > /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
> > gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
> >--
> >1.6.3.3
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-
> >omap" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3: beagle: Fix USB host port power control
2009-11-03 14:11 ` Koen Kooi
2009-11-03 17:21 ` Tony Lindgren
@ 2009-11-04 2:22 ` Sid Boyce
1 sibling, 0 replies; 5+ messages in thread
From: Sid Boyce @ 2009-11-04 2:22 UTC (permalink / raw)
To: Koen Kooi; +Cc: linux-omap@vger.kernel.org List
On 03/11/09 14:11, Koen Kooi wrote:
> Any comments on this, I need this on beagleboard to make ehci work.
>
> regards,
>
> Koen
>
> Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:
>
>> The host port power is enabled by driving the nEN_USB_PWR low as
>> stated in
>> the comment. This fix is originally from Steve Sakoman
>> <steve@sakoman.com>.
>>
>> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
>> Cc: Steve Sakoman <steve@sakoman.com>
>> ---
>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
>> b/arch/arm/mach-omap2/board-omap3beagle.c
>> index 6cb99f6..7ad9846 100644
>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>> @@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device *dev,
>>
>> /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active
>> low) */
>> gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
>> - gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
>> + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
>>
>> /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
>> gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
>> --
>> 1.6.3.3
>>
>> --
Certainly works on 2.6.32-rc5, all EHCI devices are now enumerated.
Regards
Sid.
--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [APPLIED] [PATCH] omap3: beagle: Fix USB host port power control
2009-10-24 7:59 [PATCH] omap3: beagle: Fix USB host port power control Jarkko Nikula
2009-11-03 14:11 ` Koen Kooi
@ 2009-11-09 23:54 ` Tony Lindgren
1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2009-11-09 23:54 UTC (permalink / raw)
To: linux-omap
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Branch in linux-omap: omap-fixes
Initial commit ID (Likely to change): 12187e35445bef725406b8f0bbf745ac5501da63
PatchWorks
http://patchwork.kernel.org/patch/55703/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=12187e35445bef725406b8f0bbf745ac5501da63
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-09 23:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-24 7:59 [PATCH] omap3: beagle: Fix USB host port power control Jarkko Nikula
2009-11-03 14:11 ` Koen Kooi
2009-11-03 17:21 ` Tony Lindgren
2009-11-04 2:22 ` Sid Boyce
2009-11-09 23:54 ` [APPLIED] " Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.