* [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection
@ 2017-10-18 15:27 Jason Gerecke
2017-10-18 16:38 ` Benjamin Tissoires
2017-10-19 8:22 ` Jiri Kosina
0 siblings, 2 replies; 5+ messages in thread
From: Jason Gerecke @ 2017-10-18 15:27 UTC (permalink / raw)
To: linux-input, Jiri Kosina
Cc: Ping Cheng, Benjamin Tissoires, Jason Gerecke, stable, Jason Gerecke
The WACOM_PEN_FIELD macro is used to determine if a given HID field should be
associated with pen input. This field includes several known collection types
that Wacom pen data is contained in, but the WACOM_HID_WD_PEN application
collection type is notably missing. This can result in fields within this
kind of collection being completely ignored by the `wacom_usage_mapping`
function, preventing the later '*_event' functions from being notified about
changes to their value.
Fixes: c9c095874a ("HID: wacom: generic: Support and use 'Custom HID' mode and usages")
Fixes: ac2423c975 ("HID: wacom: generic: add vendor defined touch")
Cc: stable@vger.kernel.org
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
drivers/hid/wacom_wac.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
index 8a03654048bf..feb62fd4dfc3 100644
--- a/drivers/hid/wacom_wac.h
+++ b/drivers/hid/wacom_wac.h
@@ -166,6 +166,7 @@
((f)->physical == HID_DG_PEN) || \
((f)->application == HID_DG_PEN) || \
((f)->application == HID_DG_DIGITIZER) || \
+ ((f)->application == WACOM_HID_WD_PEN) || \
((f)->application == WACOM_HID_WD_DIGITIZER) || \
((f)->application == WACOM_HID_G9_PEN) || \
((f)->application == WACOM_HID_G11_PEN))
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection
2017-10-18 15:27 [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection Jason Gerecke
@ 2017-10-18 16:38 ` Benjamin Tissoires
2017-10-19 8:22 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2017-10-18 16:38 UTC (permalink / raw)
To: Jason Gerecke; +Cc: linux-input, Jiri Kosina, Ping Cheng, stable, Jason Gerecke
On Oct 18 2017 or thereabouts, Jason Gerecke wrote:
> The WACOM_PEN_FIELD macro is used to determine if a given HID field should be
> associated with pen input. This field includes several known collection types
> that Wacom pen data is contained in, but the WACOM_HID_WD_PEN application
> collection type is notably missing. This can result in fields within this
> kind of collection being completely ignored by the `wacom_usage_mapping`
> function, preventing the later '*_event' functions from being notified about
> changes to their value.
>
> Fixes: c9c095874a ("HID: wacom: generic: Support and use 'Custom HID' mode and usages")
> Fixes: ac2423c975 ("HID: wacom: generic: add vendor defined touch")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
> ---
Looks good:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/wacom_wac.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
> index 8a03654048bf..feb62fd4dfc3 100644
> --- a/drivers/hid/wacom_wac.h
> +++ b/drivers/hid/wacom_wac.h
> @@ -166,6 +166,7 @@
> ((f)->physical == HID_DG_PEN) || \
> ((f)->application == HID_DG_PEN) || \
> ((f)->application == HID_DG_DIGITIZER) || \
> + ((f)->application == WACOM_HID_WD_PEN) || \
> ((f)->application == WACOM_HID_WD_DIGITIZER) || \
> ((f)->application == WACOM_HID_G9_PEN) || \
> ((f)->application == WACOM_HID_G11_PEN))
> --
> 2.14.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection
2017-10-18 15:27 [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection Jason Gerecke
2017-10-18 16:38 ` Benjamin Tissoires
@ 2017-10-19 8:22 ` Jiri Kosina
2017-11-09 16:54 ` Jason Gerecke
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2017-10-19 8:22 UTC (permalink / raw)
To: Jason Gerecke
Cc: linux-input, Ping Cheng, Benjamin Tissoires, stable, Jason Gerecke
On Wed, 18 Oct 2017, Jason Gerecke wrote:
> The WACOM_PEN_FIELD macro is used to determine if a given HID field should be
> associated with pen input. This field includes several known collection types
> that Wacom pen data is contained in, but the WACOM_HID_WD_PEN application
> collection type is notably missing. This can result in fields within this
> kind of collection being completely ignored by the `wacom_usage_mapping`
> function, preventing the later '*_event' functions from being notified about
> changes to their value.
>
> Fixes: c9c095874a ("HID: wacom: generic: Support and use 'Custom HID' mode and usages")
> Fixes: ac2423c975 ("HID: wacom: generic: add vendor defined touch")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Applied to for-4.14/upstream-fixes
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection
2017-10-19 8:22 ` Jiri Kosina
@ 2017-11-09 16:54 ` Jason Gerecke
2017-11-10 8:45 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Jason Gerecke @ 2017-11-09 16:54 UTC (permalink / raw)
To: Jiri Kosina
Cc: Linux Input, Ping Cheng, Benjamin Tissoires, # v3.17+, Jason Gerecke
On Thu, Oct 19, 2017 at 1:22 AM, Jiri Kosina <jikos@kernel.org> wrote:
> On Wed, 18 Oct 2017, Jason Gerecke wrote:
>
>> The WACOM_PEN_FIELD macro is used to determine if a given HID field should be
>> associated with pen input. This field includes several known collection types
>> that Wacom pen data is contained in, but the WACOM_HID_WD_PEN application
>> collection type is notably missing. This can result in fields within this
>> kind of collection being completely ignored by the `wacom_usage_mapping`
>> function, preventing the later '*_event' functions from being notified about
>> changes to their value.
>>
>> Fixes: c9c095874a ("HID: wacom: generic: Support and use 'Custom HID' mode and usages")
>> Fixes: ac2423c975 ("HID: wacom: generic: add vendor defined touch")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
>
> Applied to for-4.14/upstream-fixes
>
> --
> Jiri Kosina
> SUSE Labs
>
Was this branch ever sent to Linus? I don't see any mention of it (or
this patch) in the 4.14-rc8 history...
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection
2017-11-09 16:54 ` Jason Gerecke
@ 2017-11-10 8:45 ` Jiri Kosina
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2017-11-10 8:45 UTC (permalink / raw)
To: Jason Gerecke; +Cc: Linux Input, Ping Cheng, Benjamin Tissoires, Jason Gerecke
On Thu, 9 Nov 2017, Jason Gerecke wrote:
> Was this branch ever sent to Linus? I don't see any mention of it (or
> this patch) in the 4.14-rc8 history...
I take the blame here; last few weeks were a bit crazy for me, and this
slipped through cracks.
I'll be submitting the whole lot for stable, so that it gets included
everywhere properly.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-10 8:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-18 15:27 [PATCH] HID: wacom: generic: Recognize WACOM_HID_WD_PEN as a type of pen collection Jason Gerecke
2017-10-18 16:38 ` Benjamin Tissoires
2017-10-19 8:22 ` Jiri Kosina
2017-11-09 16:54 ` Jason Gerecke
2017-11-10 8:45 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.