All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] add backlight level quirk for Asus ROG laptops
@ 2017-10-28  7:31 Mustafa Kuscu
  2017-11-09 11:50 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Mustafa Kuscu @ 2017-10-28  7:31 UTC (permalink / raw)
  To: linux-input; +Cc: jikos, benjamin.tissoires, linux-kernel, Mustafa C Kuscu

On laptops such as Asus GL553VD, setting keyboard backlight levels 
does not work. This change enables F3/F4 keys to set backlight levels 
(from 0 to 3, total 4 levels) on such laptops. 

It is intended only to the following device: 0x0b05 1854:
P: Vendor=0b05 ProdID=1854 Rev=03.02
S: Manufacturer=ITE Tech. Inc.
S: Product=ITE Device(8910)

Note: Just reloading the hid_asus module would not suffice, reload 
the whole thing or reboot, you know.

Signed-off-by: Mustafa C Kuscu <mustafakuscu@gmail.com>
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index a4a3c38bc145..39068eddc03c 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -593,7 +593,7 @@ static const struct hid_device_id asus_devices[] = {
 	{ HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK,
 		USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPAD), I2C_TOUCHPAD_QUIRKS },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
-		USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) },
+		USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1), QUIRK_USE_KBD_BACKLIGHT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
 		USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] add backlight level quirk for Asus ROG laptops
  2017-10-28  7:31 [PATCH] add backlight level quirk for Asus ROG laptops Mustafa Kuscu
@ 2017-11-09 11:50 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2017-11-09 11:50 UTC (permalink / raw)
  To: Mustafa Kuscu; +Cc: linux-input, benjamin.tissoires, linux-kernel

On Sat, 28 Oct 2017, Mustafa Kuscu wrote:

> On laptops such as Asus GL553VD, setting keyboard backlight levels 
> does not work. This change enables F3/F4 keys to set backlight levels 
> (from 0 to 3, total 4 levels) on such laptops. 
> 
> It is intended only to the following device: 0x0b05 1854:
> P: Vendor=0b05 ProdID=1854 Rev=03.02
> S: Manufacturer=ITE Tech. Inc.
> S: Product=ITE Device(8910)
> 
> Note: Just reloading the hid_asus module would not suffice, reload 
> the whole thing or reboot, you know.
> 
> Signed-off-by: Mustafa C Kuscu <mustafakuscu@gmail.com>

I've reformatted the changelog/shortlog a little bit and applied to 
for-4.15/asus. Thanks,

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-09 11:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-28  7:31 [PATCH] add backlight level quirk for Asus ROG laptops Mustafa Kuscu
2017-11-09 11:50 ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.