From: Jiri Kosina <jikos@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: lg-g15: make a const array static, makes object smaller
Date: Fri, 5 Feb 2021 10:13:54 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2102051013440.28696@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210204172748.107406-1-colin.king@canonical.com>
On Thu, 4 Feb 2021, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array led_names on the stack but instead make
> it static. Makes the object code smaller by 79 bytes:
>
> Before:
> text data bss dec hex filename
> 19686 7952 256 27894 6cf6 drivers/hid/hid-lg-g15.o
>
> After:
> text data bss dec hex filename
> 19543 8016 256 27815 6ca7 drivers/hid/hid-lg-g15.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
--
Jiri Kosina
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Kosina <jikos@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: lg-g15: make a const array static, makes object smaller
Date: Fri, 05 Feb 2021 09:13:54 +0000 [thread overview]
Message-ID: <nycvar.YFH.7.76.2102051013440.28696@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210204172748.107406-1-colin.king@canonical.com>
On Thu, 4 Feb 2021, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array led_names on the stack but instead make
> it static. Makes the object code smaller by 79 bytes:
>
> Before:
> text data bss dec hex filename
> 19686 7952 256 27894 6cf6 drivers/hid/hid-lg-g15.o
>
> After:
> text data bss dec hex filename
> 19543 8016 256 27815 6ca7 drivers/hid/hid-lg-g15.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-02-05 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:27 [PATCH] HID: lg-g15: make a const array static, makes object smaller Colin King
2021-02-04 17:27 ` Colin King
2021-02-05 9:13 ` Jiri Kosina [this message]
2021-02-05 9:13 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2102051013440.28696@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=colin.king@canonical.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.