From: Jiri Kosina <jikos@kernel.org>
To: Denis Efremov <efremov@linux.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
regressions@lists.linux.dev, Mark Hounschell <markh@compro.net>,
Wim Osterholt <wim@djo.tudelft.nl>,
Kurt Garloff <kurt@garloff.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "floppy: reintroduce O_NDELAY fix"
Date: Mon, 16 Aug 2021 09:17:30 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2108160914070.8253@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210808074246.33449-1-efremov@linux.com>
On Sun, 8 Aug 2021, Denis Efremov wrote:
> The patch breaks userspace implementations (e.g. fdutils) and introduces
> regressions in behaviour. Previously, it was possible to O_NDELAY open a
> floppy device with no media inserted or with write protected media without
> an error. Some userspace tools use this particular behavior for probing.
>
> It's not the first time when we revert this patch. Previous revert is in
> commit f2791e7eadf4 (Revert "floppy: refactor open() flags handling").
>
> This reverts commit 8a0c014cd20516ade9654fc13b51345ec58e7be8.
By reverting it you bring back the bugs that were fixed by it -- e.g. the
possibility to livelock mmap() on the returned fd to keep waiting on the
page unlock bit forever, or the functionality bug reported at [1], and
likely others.
[1] https://bugzilla.suse.com/show_bug.cgi?id=1181018
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-08-16 7:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 18:47 [BUG] FLOPPY DRIVER since 5.10.20 Mark Hounschell
2021-07-26 7:57 ` Denis Efremov
2021-07-26 11:15 ` Mark Hounschell
2021-07-26 11:17 ` Mark Hounschell
2021-07-26 11:37 ` Denis Efremov
2021-07-26 12:23 ` Mark Hounschell
2021-07-26 16:34 ` Denis Efremov
2021-07-30 5:15 ` Denis Efremov
2021-08-01 11:14 ` Kurt Garloff
2021-08-08 7:42 ` [PATCH] Revert "floppy: reintroduce O_NDELAY fix" Denis Efremov
2021-08-16 7:17 ` Jiri Kosina [this message]
2021-08-16 7:17 ` Jiri Kosina
2021-08-18 15:53 ` Denis Efremov
2021-08-30 9:20 ` Thorsten Leemhuis
2021-09-20 11:29 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2108160914070.8253@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=efremov@linux.com \
--cc=kurt@garloff.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=wim@djo.tudelft.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.