* [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
@ 2019-07-23 10:47 ` P J P
2019-07-23 13:10 ` Stefan Hajnoczi
` (2 more replies)
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
` (3 subsequent siblings)
4 siblings, 3 replies; 23+ messages in thread
From: P J P @ 2019-07-23 10:47 UTC (permalink / raw)
To: QEMU Developers
Cc: Riccardo Schirone, Li Qiang, Jason Wang, Daniel P . Berrangé,
Prasad J Pandit
From: Prasad J Pandit <pjp@fedoraproject.org>
The network interface name in Linux is defined to be of size
IFNAMSIZ(=16), including the terminating null('\0') byte.
The same is applied to interface names read from 'bridge.conf'
file to form ACL rules. If user supplied '--br=bridge' name
is not restricted to the same length, it could lead to ACL bypass
issue. Restrict interface name to IFNAMSIZ, including null byte.
Reported-by: Riccardo Schirone <rschiron@redhat.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
qemu-bridge-helper.c | 11 +++++++++++
1 file changed, 11 insertions(+)
Reviewed v3
-> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00245.html
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index f9940deefd..e90c22f07d 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -109,6 +109,13 @@ static int parse_acl_file(const char *filename, ACLList *acl_list)
}
*argend = 0;
+ if (!g_str_equal(cmd, "include") && strlen(arg) >= IFNAMSIZ) {
+ fprintf(stderr, "name `%s' too long: %zu\n", arg, strlen(arg));
+ fclose(f);
+ errno = EINVAL;
+ return -1;
+ }
+
if (strcmp(cmd, "deny") == 0) {
acl_rule = g_malloc(sizeof(*acl_rule));
if (strcmp(arg, "all") == 0) {
@@ -259,6 +266,10 @@ int main(int argc, char **argv)
usage();
return EXIT_FAILURE;
}
+ if (strlen(bridge) >= IFNAMSIZ) {
+ fprintf(stderr, "name `%s' too long: %zu\n", bridge, strlen(bridge));
+ return EXIT_FAILURE;
+ }
/* parse default acl file */
QSIMPLEQ_INIT(&acl_list);
--
2.21.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
@ 2019-07-23 13:10 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2 siblings, 0 replies; 23+ messages in thread
From: Stefan Hajnoczi @ 2019-07-23 13:10 UTC (permalink / raw)
To: P J P
Cc: Riccardo Schirone, Daniel P . Berrangé,
Prasad J Pandit, Jason Wang, Li Qiang, QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Tue, Jul 23, 2019 at 04:17:52PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> The network interface name in Linux is defined to be of size
> IFNAMSIZ(=16), including the terminating null('\0') byte.
> The same is applied to interface names read from 'bridge.conf'
> file to form ACL rules. If user supplied '--br=bridge' name
> is not restricted to the same length, it could lead to ACL bypass
> issue. Restrict interface name to IFNAMSIZ, including null byte.
>
> Reported-by: Riccardo Schirone <rschiron@redhat.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> qemu-bridge-helper.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> Reviewed v3
> -> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00245.html
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
2019-07-23 13:10 ` Stefan Hajnoczi
@ 2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2 siblings, 0 replies; 23+ messages in thread
From: Daniel P. Berrangé @ 2019-07-23 13:12 UTC (permalink / raw)
To: P J P
Cc: Riccardo Schirone, Jason Wang, Li Qiang, QEMU Developers,
Prasad J Pandit
On Tue, Jul 23, 2019 at 04:17:52PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> The network interface name in Linux is defined to be of size
> IFNAMSIZ(=16), including the terminating null('\0') byte.
> The same is applied to interface names read from 'bridge.conf'
> file to form ACL rules. If user supplied '--br=bridge' name
> is not restricted to the same length, it could lead to ACL bypass
> issue. Restrict interface name to IFNAMSIZ, including null byte.
>
> Reported-by: Riccardo Schirone <rschiron@redhat.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> qemu-bridge-helper.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
2019-07-23 13:10 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
@ 2019-07-23 15:07 ` Li Qiang
2 siblings, 0 replies; 23+ messages in thread
From: Li Qiang @ 2019-07-23 15:07 UTC (permalink / raw)
To: P J P
Cc: Riccardo Schirone, Jason Wang, Daniel P . Berrangé,
QEMU Developers, Prasad J Pandit
P J P <ppandit@redhat.com> 于2019年7月23日周二 下午6:50写道:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> The network interface name in Linux is defined to be of size
> IFNAMSIZ(=16), including the terminating null('\0') byte.
> The same is applied to interface names read from 'bridge.conf'
> file to form ACL rules. If user supplied '--br=bridge' name
> is not restricted to the same length, it could lead to ACL bypass
> issue. Restrict interface name to IFNAMSIZ, including null byte.
>
> Reported-by: Riccardo Schirone <rschiron@redhat.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> qemu-bridge-helper.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> Reviewed v3
> ->
> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00245.html
>
> diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
> index f9940deefd..e90c22f07d 100644
> --- a/qemu-bridge-helper.c
> +++ b/qemu-bridge-helper.c
> @@ -109,6 +109,13 @@ static int parse_acl_file(const char *filename,
> ACLList *acl_list)
> }
> *argend = 0;
>
> + if (!g_str_equal(cmd, "include") && strlen(arg) >= IFNAMSIZ) {
> + fprintf(stderr, "name `%s' too long: %zu\n", arg,
> strlen(arg));
> + fclose(f);
> + errno = EINVAL;
> + return -1;
> + }
> +
> if (strcmp(cmd, "deny") == 0) {
> acl_rule = g_malloc(sizeof(*acl_rule));
> if (strcmp(arg, "all") == 0) {
> @@ -259,6 +266,10 @@ int main(int argc, char **argv)
> usage();
> return EXIT_FAILURE;
> }
> + if (strlen(bridge) >= IFNAMSIZ) {
> + fprintf(stderr, "name `%s' too long: %zu\n", bridge,
> strlen(bridge));
> + return EXIT_FAILURE;
> + }
>
> /* parse default acl file */
> QSIMPLEQ_INIT(&acl_list);
> --
> 2.21.0
>
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
@ 2019-07-23 10:47 ` P J P
2019-07-23 13:00 ` Stefan Hajnoczi
` (2 more replies)
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls P J P
` (2 subsequent siblings)
4 siblings, 3 replies; 23+ messages in thread
From: P J P @ 2019-07-23 10:47 UTC (permalink / raw)
To: QEMU Developers
Cc: Li Qiang, Jason Wang, Daniel P . Berrangé, Prasad J Pandit
From: Prasad J Pandit <pjp@fedoraproject.org>
Move repeating error handling sequence in parse_acl_file routine
to an 'err' label.
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
qemu-bridge-helper.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
Reviewed v3:
-> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00247.html
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index e90c22f07d..91a02f9611 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -92,9 +92,7 @@ static int parse_acl_file(const char *filename, ACLList *acl_list)
if (arg == NULL) {
fprintf(stderr, "Invalid config line:\n %s\n", line);
- fclose(f);
- errno = EINVAL;
- return -1;
+ goto err;
}
*arg = 0;
@@ -111,9 +109,7 @@ static int parse_acl_file(const char *filename, ACLList *acl_list)
if (!g_str_equal(cmd, "include") && strlen(arg) >= IFNAMSIZ) {
fprintf(stderr, "name `%s' too long: %zu\n", arg, strlen(arg));
- fclose(f);
- errno = EINVAL;
- return -1;
+ goto err;
}
if (strcmp(cmd, "deny") == 0) {
@@ -139,15 +135,18 @@ static int parse_acl_file(const char *filename, ACLList *acl_list)
parse_acl_file(arg, acl_list);
} else {
fprintf(stderr, "Unknown command `%s'\n", cmd);
- fclose(f);
- errno = EINVAL;
- return -1;
+ goto err;
}
}
fclose(f);
-
return 0;
+
+err:
+ fclose(f);
+ errno = EINVAL;
+ return -1;
+
}
static bool has_vnet_hdr(int fd)
--
2.21.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
@ 2019-07-23 13:00 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2 siblings, 0 replies; 23+ messages in thread
From: Stefan Hajnoczi @ 2019-07-23 13:00 UTC (permalink / raw)
To: P J P
Cc: Daniel P . Berrangé,
Jason Wang, Li Qiang, QEMU Developers, Prasad J Pandit
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Tue, Jul 23, 2019 at 04:17:53PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Move repeating error handling sequence in parse_acl_file routine
> to an 'err' label.
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> qemu-bridge-helper.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> Reviewed v3:
> -> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00247.html
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
2019-07-23 13:00 ` Stefan Hajnoczi
@ 2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2 siblings, 0 replies; 23+ messages in thread
From: Daniel P. Berrangé @ 2019-07-23 13:12 UTC (permalink / raw)
To: P J P; +Cc: Jason Wang, Li Qiang, QEMU Developers, Prasad J Pandit
On Tue, Jul 23, 2019 at 04:17:53PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Move repeating error handling sequence in parse_acl_file routine
> to an 'err' label.
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> qemu-bridge-helper.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
2019-07-23 13:00 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
@ 2019-07-23 15:07 ` Li Qiang
2 siblings, 0 replies; 23+ messages in thread
From: Li Qiang @ 2019-07-23 15:07 UTC (permalink / raw)
To: P J P
Cc: Jason Wang, Daniel P . Berrangé, QEMU Developers, Prasad J Pandit
P J P <ppandit@redhat.com> 于2019年7月23日周二 下午6:50写道:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Move repeating error handling sequence in parse_acl_file routine
> to an 'err' label.
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> qemu-bridge-helper.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> Reviewed v3:
> ->
> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00247.html
>
> diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
> index e90c22f07d..91a02f9611 100644
> --- a/qemu-bridge-helper.c
> +++ b/qemu-bridge-helper.c
> @@ -92,9 +92,7 @@ static int parse_acl_file(const char *filename, ACLList
> *acl_list)
>
> if (arg == NULL) {
> fprintf(stderr, "Invalid config line:\n %s\n", line);
> - fclose(f);
> - errno = EINVAL;
> - return -1;
> + goto err;
> }
>
> *arg = 0;
> @@ -111,9 +109,7 @@ static int parse_acl_file(const char *filename,
> ACLList *acl_list)
>
> if (!g_str_equal(cmd, "include") && strlen(arg) >= IFNAMSIZ) {
> fprintf(stderr, "name `%s' too long: %zu\n", arg,
> strlen(arg));
> - fclose(f);
> - errno = EINVAL;
> - return -1;
> + goto err;
> }
>
> if (strcmp(cmd, "deny") == 0) {
> @@ -139,15 +135,18 @@ static int parse_acl_file(const char *filename,
> ACLList *acl_list)
> parse_acl_file(arg, acl_list);
> } else {
> fprintf(stderr, "Unknown command `%s'\n", cmd);
> - fclose(f);
> - errno = EINVAL;
> - return -1;
> + goto err;
> }
> }
>
> fclose(f);
> -
> return 0;
> +
> +err:
> + fclose(f);
> + errno = EINVAL;
> + return -1;
> +
> }
>
> static bool has_vnet_hdr(int fd)
> --
> 2.21.0
>
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
@ 2019-07-23 10:47 ` P J P
2019-07-23 13:03 ` Stefan Hajnoczi
2019-07-23 13:13 ` Daniel P. Berrangé
2019-07-23 17:44 ` [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ no-reply
2019-07-26 10:26 ` Jason Wang
4 siblings, 2 replies; 23+ messages in thread
From: P J P @ 2019-07-23 10:47 UTC (permalink / raw)
To: QEMU Developers
Cc: Li Qiang, Jason Wang, Daniel P . Berrangé, Prasad J Pandit
From: Prasad J Pandit <pjp@fedoraproject.org>
When invoking qemu-bridge-helper in 'net_bridge_run_helper',
instead of using fixed sized buffers, use dynamically allocated
ones initialised and returned by g_strdup_printf().
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
net/tap.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
Update v4: only replace snprintf with g_strdup_printf calls
-> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg00578.html
diff --git a/net/tap.c b/net/tap.c
index e8aadd8d4b..fc38029f41 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -498,9 +498,9 @@ static int net_bridge_run_helper(const char *helper, const char *bridge,
}
if (pid == 0) {
int open_max = sysconf(_SC_OPEN_MAX), i;
- char fd_buf[6+10];
- char br_buf[6+IFNAMSIZ] = {0};
- char helper_cmd[PATH_MAX + sizeof(fd_buf) + sizeof(br_buf) + 15];
+ char *fd_buf = NULL;
+ char *br_buf = NULL;
+ char *helper_cmd = NULL;
for (i = 3; i < open_max; i++) {
if (i != sv[1]) {
@@ -508,17 +508,17 @@ static int net_bridge_run_helper(const char *helper, const char *bridge,
}
}
- snprintf(fd_buf, sizeof(fd_buf), "%s%d", "--fd=", sv[1]);
+ fd_buf = g_strdup_printf("%s%d", "--fd=", sv[1]);
if (strrchr(helper, ' ') || strrchr(helper, '\t')) {
/* assume helper is a command */
if (strstr(helper, "--br=") == NULL) {
- snprintf(br_buf, sizeof(br_buf), "%s%s", "--br=", bridge);
+ br_buf = g_strdup_printf("%s%s", "--br=", bridge);
}
- snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
- helper, "--use-vnet", fd_buf, br_buf);
+ helper_cmd = g_strdup_printf("%s %s %s %s", helper,
+ "--use-vnet", fd_buf, br_buf ? br_buf : "");
parg = args;
*parg++ = (char *)"sh";
@@ -527,10 +527,11 @@ static int net_bridge_run_helper(const char *helper, const char *bridge,
*parg++ = NULL;
execv("/bin/sh", args);
+ g_free(helper_cmd);
} else {
/* assume helper is just the executable path name */
- snprintf(br_buf, sizeof(br_buf), "%s%s", "--br=", bridge);
+ br_buf = g_strdup_printf("%s%s", "--br=", bridge);
parg = args;
*parg++ = (char *)helper;
@@ -541,6 +542,8 @@ static int net_bridge_run_helper(const char *helper, const char *bridge,
execv(helper, args);
}
+ g_free(fd_buf);
+ g_free(br_buf);
_exit(1);
} else {
--
2.21.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls P J P
@ 2019-07-23 13:03 ` Stefan Hajnoczi
2019-07-23 15:43 ` Li Qiang
2019-07-23 13:13 ` Daniel P. Berrangé
1 sibling, 1 reply; 23+ messages in thread
From: Stefan Hajnoczi @ 2019-07-23 13:03 UTC (permalink / raw)
To: P J P
Cc: Daniel P . Berrangé,
Jason Wang, Li Qiang, QEMU Developers, Prasad J Pandit
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> - snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
> - helper, "--use-vnet", fd_buf, br_buf);
> + helper_cmd = g_strdup_printf("%s %s %s %s", helper,
> + "--use-vnet", fd_buf, br_buf ? br_buf : "");
The change to the br_buf argument isn't covered in the commit
description. Why did you change this, was it a bug, etc?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-23 13:03 ` Stefan Hajnoczi
@ 2019-07-23 15:43 ` Li Qiang
2019-07-24 5:48 ` P J P
0 siblings, 1 reply; 23+ messages in thread
From: Li Qiang @ 2019-07-23 15:43 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Jason Wang, Prasad J Pandit, Daniel P . Berrangé,
QEMU Developers, P J P
Stefan Hajnoczi <stefanha@gmail.com> 于2019年7月23日周二 下午9:03写道:
> On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> > - snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
> > - helper, "--use-vnet", fd_buf, br_buf);
> > + helper_cmd = g_strdup_printf("%s %s %s %s", helper,
> > + "--use-vnet", fd_buf, br_buf ? br_buf : "");
>
> The change to the br_buf argument isn't covered in the commit
> description. Why did you change this, was it a bug, etc?
>
IIUC, if we pass the NULL argument in g_strdup_printf, the 'helper_cmd'
will contain the '(null)' char.
If we pass "" to g_strdup_printf, there is nothing in 'helper_cmd'. The
original is like this.
So here Prasad has to check the 'fd_buf'.
So:
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Thanks,
Li Qiang
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-23 15:43 ` Li Qiang
@ 2019-07-24 5:48 ` P J P
2019-07-29 15:04 ` Stefan Hajnoczi
0 siblings, 1 reply; 23+ messages in thread
From: P J P @ 2019-07-24 5:48 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Daniel P . Berrangé, Jason Wang, Li Qiang, QEMU Developers
+-- On Tue, 23 Jul 2019, Li Qiang wrote --+
| Stefan Hajnoczi <stefanha@gmail.com> 于2019年7月23日周二 下午9:03写道:
| > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
| > > - snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
| > > - helper, "--use-vnet", fd_buf, br_buf);
| > > + helper_cmd = g_strdup_printf("%s %s %s %s", helper,
| > > + "--use-vnet", fd_buf, br_buf ? br_buf : "");
| >
| > The change to the br_buf argument isn't covered in the commit
| > description. Why did you change this, was it a bug, etc?
|
| IIUC, if we pass the NULL argument in g_strdup_printf, the 'helper_cmd' will
| contain the '(null)' char.
Yep, right.
| Reviewed-by: Li Qiang <liq3ea@gmail.com>
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-24 5:48 ` P J P
@ 2019-07-29 15:04 ` Stefan Hajnoczi
2019-07-31 4:58 ` Jason Wang
0 siblings, 1 reply; 23+ messages in thread
From: Stefan Hajnoczi @ 2019-07-29 15:04 UTC (permalink / raw)
To: P J P; +Cc: Daniel P . Berrangé, Jason Wang, Li Qiang, QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]
On Wed, Jul 24, 2019 at 11:18:09AM +0530, P J P wrote:
> +-- On Tue, 23 Jul 2019, Li Qiang wrote --+
> | Stefan Hajnoczi <stefanha@gmail.com> 于2019年7月23日周二 下午9:03写道:
> | > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> | > > - snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
> | > > - helper, "--use-vnet", fd_buf, br_buf);
> | > > + helper_cmd = g_strdup_printf("%s %s %s %s", helper,
> | > > + "--use-vnet", fd_buf, br_buf ? br_buf : "");
> | >
> | > The change to the br_buf argument isn't covered in the commit
> | > description. Why did you change this, was it a bug, etc?
> |
> | IIUC, if we pass the NULL argument in g_strdup_printf, the 'helper_cmd' will
> | contain the '(null)' char.
>
> Yep, right.
This change isn't related to the topic of the patch. It's a separate
bug fix.
Please either document it in the commit description so it's clear the
change is intentional, or send it as a separate patch.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-29 15:04 ` Stefan Hajnoczi
@ 2019-07-31 4:58 ` Jason Wang
2019-07-31 6:42 ` P J P
0 siblings, 1 reply; 23+ messages in thread
From: Jason Wang @ 2019-07-31 4:58 UTC (permalink / raw)
To: Stefan Hajnoczi, P J P; +Cc: Li Qiang, Daniel P. Berrangé, QEMU Developers
On 2019/7/29 下午11:04, Stefan Hajnoczi wrote:
> On Wed, Jul 24, 2019 at 11:18:09AM +0530, P J P wrote:
>> +-- On Tue, 23 Jul 2019, Li Qiang wrote --+
>> | Stefan Hajnoczi <stefanha@gmail.com> 于2019年7月23日周二 下午9:03写道:
>> | > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
>> | > > - snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
>> | > > - helper, "--use-vnet", fd_buf, br_buf);
>> | > > + helper_cmd = g_strdup_printf("%s %s %s %s", helper,
>> | > > + "--use-vnet", fd_buf, br_buf ? br_buf : "");
>> | >
>> | > The change to the br_buf argument isn't covered in the commit
>> | > description. Why did you change this, was it a bug, etc?
>> |
>> | IIUC, if we pass the NULL argument in g_strdup_printf, the 'helper_cmd' will
>> | contain the '(null)' char.
>>
>> Yep, right.
> This change isn't related to the topic of the patch. It's a separate
> bug fix.
>
> Please either document it in the commit description so it's clear the
> change is intentional, or send it as a separate patch.
>
> Stefan
Prasad, please send a patch for this.
Thanks
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-31 4:58 ` Jason Wang
@ 2019-07-31 6:42 ` P J P
2019-07-31 6:59 ` Jason Wang
0 siblings, 1 reply; 23+ messages in thread
From: P J P @ 2019-07-31 6:42 UTC (permalink / raw)
To: Jason Wang
Cc: Stefan Hajnoczi, Li Qiang, Daniel P. Berrangé, QEMU Developers
+-- On Wed, 31 Jul 2019, Jason Wang wrote --+
| On 2019/7/29 下午11:04, Stefan Hajnoczi wrote:
| > This change isn't related to the topic of the patch. It's a separate bug
| > fix.
| >
| > Please either document it in the commit description so it's clear the
| > change is intentional, or send it as a separate patch.
|
| Prasad, please send a patch for this.
Okay, do I redo the series, or just this one patch is okay? (to confirm)
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-31 6:42 ` P J P
@ 2019-07-31 6:59 ` Jason Wang
2019-07-31 9:23 ` P J P
0 siblings, 1 reply; 23+ messages in thread
From: Jason Wang @ 2019-07-31 6:59 UTC (permalink / raw)
To: P J P; +Cc: Stefan Hajnoczi, Li Qiang, Daniel P. Berrangé, QEMU Developers
On 2019/7/31 下午2:42, P J P wrote:
> +-- On Wed, 31 Jul 2019, Jason Wang wrote --+
> | On 2019/7/29 下午11:04, Stefan Hajnoczi wrote:
> | > This change isn't related to the topic of the patch. It's a separate bug
> | > fix.
> | >
> | > Please either document it in the commit description so it's clear the
> | > change is intentional, or send it as a separate patch.
> |
> | Prasad, please send a patch for this.
>
> Okay, do I redo the series, or just this one patch is okay? (to confirm)
The series has been merged. Just need a patch on top and I can queue it
for next release.
Thanks
>
> Thank you.
> --
> Prasad J Pandit / Red Hat Product Security Team
> 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-31 6:59 ` Jason Wang
@ 2019-07-31 9:23 ` P J P
0 siblings, 0 replies; 23+ messages in thread
From: P J P @ 2019-07-31 9:23 UTC (permalink / raw)
To: Jason Wang
Cc: Stefan Hajnoczi, Li Qiang, Daniel P. Berrangé, QEMU Developers
+-- On Wed, 31 Jul 2019, Jason Wang wrote --+
| The series has been merged. Just need a patch on top and I can queue it for
| next release.
Sent patch v5. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls P J P
2019-07-23 13:03 ` Stefan Hajnoczi
@ 2019-07-23 13:13 ` Daniel P. Berrangé
1 sibling, 0 replies; 23+ messages in thread
From: Daniel P. Berrangé @ 2019-07-23 13:13 UTC (permalink / raw)
To: P J P; +Cc: Jason Wang, Li Qiang, QEMU Developers, Prasad J Pandit
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> When invoking qemu-bridge-helper in 'net_bridge_run_helper',
> instead of using fixed sized buffers, use dynamically allocated
> ones initialised and returned by g_strdup_printf().
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> net/tap.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
` (2 preceding siblings ...)
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls P J P
@ 2019-07-23 17:44 ` no-reply
2019-07-25 4:01 ` Jason Wang
2019-07-26 10:26 ` Jason Wang
4 siblings, 1 reply; 23+ messages in thread
From: no-reply @ 2019-07-23 17:44 UTC (permalink / raw)
To: ppandit; +Cc: berrange, jasowang, liq3ea, qemu-devel, pjp
Patchew URL: https://patchew.org/QEMU/20190723104754.29324-1-ppandit@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-coroutine"
==7880==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==7880==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fffae69e000; bottom 0x7fd8498f8000; size: 0x002764da6000 (169195757568)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==7900==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 12 test-aio /aio/event/flush
PASS 13 test-aio /aio/event/wait/no-flush-cb
PASS 10 fdc-test /x86_64/fdc/read_no_dma_1
==7912==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 14 test-aio /aio/timer/schedule
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
---
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-aio-multithread -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-aio-multithread"
PASS 11 fdc-test /x86_64/fdc/read_no_dma_18
PASS 1 test-aio-multithread /aio/multi/lifecycle
==7918==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 2 test-aio-multithread /aio/multi/schedule
PASS 3 test-aio-multithread /aio/multi/mutex/contended
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="ide-test"
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
==7946==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 1 ide-test /x86_64/ide/identify
==7963==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-throttle"
PASS 2 ide-test /x86_64/ide/flush
---
PASS 6 test-throttle /throttle/detach_attach
PASS 7 test-throttle /throttle/config_functions
PASS 8 test-throttle /throttle/accounting
==7971==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 9 test-throttle /throttle/groups
PASS 10 test-throttle /throttle/config/enabled
PASS 11 test-throttle /throttle/config/conflicting
---
PASS 13 test-throttle /throttle/config/ranges
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
==7973==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-thread-pool"
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
==7984==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
==7981==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
PASS 4 ide-test /x86_64/ide/bmdma/trim
==8055==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 5 test-thread-pool /thread-pool/cancel
PASS 5 ide-test /x86_64/ide/bmdma/short_prdt
==8061==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 6 ide-test /x86_64/ide/bmdma/one_sector_short_prdt
==8067==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 6 test-thread-pool /thread-pool/cancel-async
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-hbitmap -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-hbitmap"
PASS 7 ide-test /x86_64/ide/bmdma/long_prdt
---
PASS 2 test-hbitmap /hbitmap/size/0
PASS 3 test-hbitmap /hbitmap/size/unaligned
PASS 4 test-hbitmap /hbitmap/iter/empty
==8078==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 5 test-hbitmap /hbitmap/iter/partial
==8078==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fffe965b000; bottom 0x7fcd1c326000; size: 0x0032cd335000 (218191056896)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 6 test-hbitmap /hbitmap/iter/granularity
---
PASS 28 test-hbitmap /hbitmap/truncate/shrink/medium
PASS 29 test-hbitmap /hbitmap/truncate/shrink/large
PASS 30 test-hbitmap /hbitmap/meta/zero
==8089==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 10 ide-test /x86_64/ide/flush/empty_drive
==8094==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 11 ide-test /x86_64/ide/flush/retry_pci
==8100==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 12 ide-test /x86_64/ide/flush/retry_isa
==8106==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 31 test-hbitmap /hbitmap/meta/one
PASS 32 test-hbitmap /hbitmap/meta/byte
PASS 33 test-hbitmap /hbitmap/meta/word
PASS 13 ide-test /x86_64/ide/cdrom/pio
PASS 34 test-hbitmap /hbitmap/meta/sector
PASS 35 test-hbitmap /hbitmap/serialize/align
==8112==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 14 ide-test /x86_64/ide/cdrom/pio_large
PASS 36 test-hbitmap /hbitmap/serialize/basic
PASS 37 test-hbitmap /hbitmap/serialize/part
---
PASS 42 test-hbitmap /hbitmap/next_dirty_area/next_dirty_area_1
PASS 43 test-hbitmap /hbitmap/next_dirty_area/next_dirty_area_4
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-bdrv-drain -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-bdrv-drain"
==8118==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8121==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-bdrv-drain /bdrv-drain/nested
PASS 2 test-bdrv-drain /bdrv-drain/multiparent
PASS 3 test-bdrv-drain /bdrv-drain/set_aio_context
---
PASS 39 test-bdrv-drain /bdrv-drain/detach/driver_cb
PASS 40 test-bdrv-drain /bdrv-drain/attach/drain
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-bdrv-graph-mod -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-bdrv-graph-mod"
==8173==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-bdrv-graph-mod /bdrv-graph-mod/update-perm-tree
PASS 2 test-bdrv-graph-mod /bdrv-graph-mod/should-update-child
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-blockjob -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-blockjob"
==8180==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-blockjob /blockjob/ids
PASS 2 test-blockjob /blockjob/cancel/created
PASS 3 test-blockjob /blockjob/cancel/running
---
PASS 6 test-blockjob /blockjob/cancel/standby
PASS 7 test-blockjob /blockjob/cancel/pending
PASS 8 test-blockjob /blockjob/cancel/concluded
==8178==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-blockjob-txn -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-blockjob-txn"
==8189==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-blockjob-txn /single/success
PASS 2 test-blockjob-txn /single/failure
PASS 3 test-blockjob-txn /single/cancel
---
PASS 7 test-blockjob-txn /pair/fail-cancel-race
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-block-backend -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-block-backend"
PASS 1 ahci-test /x86_64/ahci/sanity
==8195==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-block-backend /block-backend/drain_aio_error
PASS 2 test-block-backend /block-backend/drain_all_aio_error
==8197==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-block-iothread -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-block-iothread"
==8205==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-block-iothread /sync-op/pread
PASS 2 test-block-iothread /sync-op/pwrite
PASS 3 test-block-iothread /sync-op/load_vmstate
---
PASS 16 test-block-iothread /propagate/mirror
PASS 2 ahci-test /x86_64/ahci/pci_spec
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-image-locking -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-image-locking"
==8228==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-image-locking /image-locking/basic
PASS 2 test-image-locking /image-locking/set-perm-abort
==8226==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-x86-cpuid -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-x86-cpuid"
PASS 1 test-x86-cpuid /cpuid/topology/basic
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-xbzrle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-xbzrle"
---
PASS 4 test-xbzrle /xbzrle/encode_decode_1_byte
PASS 5 test-xbzrle /xbzrle/encode_decode_overflow
PASS 3 ahci-test /x86_64/ahci/pci_enable
==8244==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 6 test-xbzrle /xbzrle/encode_decode
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-vmstate -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-vmstate"
PASS 1 test-vmstate /vmstate/tmp_struct
---
PASS 1 test-mul64 /host-utils/mulu64
PASS 2 test-mul64 /host-utils/muls64
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-int128 -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-int128"
==8264==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-int128 /int128/int128_and
PASS 2 test-int128 /int128/int128_add
PASS 3 test-int128 /int128/int128_sub
---
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/rcutorture -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="rcutorture"
PASS 5 ahci-test /x86_64/ahci/hba_enable
PASS 1 rcutorture /rcu/torture/1reader
==8289==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 2 rcutorture /rcu/torture/10readers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-rcu-list -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-rcu-list"
PASS 6 ahci-test /x86_64/ahci/identify
==8316==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-rcu-list /rcu/qlist/single-threaded
PASS 7 ahci-test /x86_64/ahci/max
PASS 2 test-rcu-list /rcu/qlist/short-few
==8330==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 8 ahci-test /x86_64/ahci/reset
PASS 3 test-rcu-list /rcu/qlist/long-many
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-rcu-simpleq -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-rcu-simpleq"
==8357==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8357==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffc81503000; bottom 0x7f50255fe000; size: 0x00ac5bf05000 (740276850688)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 9 ahci-test /x86_64/ahci/io/pio/lba28/simple/zero
PASS 1 test-rcu-simpleq /rcu/qsimpleq/single-threaded
==8370==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8370==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fff5c131000; bottom 0x7f747b3fe000; size: 0x008ae0d33000 (596477423616)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 2 test-rcu-simpleq /rcu/qsimpleq/short-few
PASS 10 ahci-test /x86_64/ahci/io/pio/lba28/simple/low
==8403==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8403==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffc3282b000; bottom 0x7ffa555fe000; size: 0x0001dd22d000 (8005013504)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 11 ahci-test /x86_64/ahci/io/pio/lba28/simple/high
PASS 3 test-rcu-simpleq /rcu/qsimpleq/long-many
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-rcu-tailq -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-rcu-tailq"
==8409==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8409==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffdaef38000; bottom 0x7fa24b7fe000; size: 0x005b6373a000 (392510545920)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-rcu-tailq /rcu/qtailq/single-threaded
PASS 12 ahci-test /x86_64/ahci/io/pio/lba28/double/zero
==8428==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8428==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffd00cf4000; bottom 0x7f3a305fe000; size: 0x00c2d06f6000 (836720615424)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 2 test-rcu-tailq /rcu/qtailq/short-few
PASS 13 ahci-test /x86_64/ahci/io/pio/lba28/double/low
==8455==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8455==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffc6bec9000; bottom 0x7f43c05fe000; size: 0x00b8ab8cb000 (793152106496)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 14 ahci-test /x86_64/ahci/io/pio/lba28/double/high
---
PASS 7 test-qdist /qdist/binning/expand
PASS 8 test-qdist /qdist/binning/shrink
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-qht -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-qht"
==8461==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8461==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffff947a000; bottom 0x7f89353fe000; size: 0x0076c407c000 (510094983168)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 15 ahci-test /x86_64/ahci/io/pio/lba28/long/zero
==8476==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8476==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffdd5549000; bottom 0x7f968e7fe000; size: 0x006746d4b000 (443569975296)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 16 ahci-test /x86_64/ahci/io/pio/lba28/long/low
==8482==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8482==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffddabf5000; bottom 0x7f4d6337c000; size: 0x00b077879000 (757919617024)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 17 ahci-test /x86_64/ahci/io/pio/lba28/long/high
==8488==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 18 ahci-test /x86_64/ahci/io/pio/lba28/short/zero
==8494==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 19 ahci-test /x86_64/ahci/io/pio/lba28/short/low
==8500==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 20 ahci-test /x86_64/ahci/io/pio/lba28/short/high
==8506==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8506==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffe87544000; bottom 0x7fa52bffe000; size: 0x00595b546000 (383784345600)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 21 ahci-test /x86_64/ahci/io/pio/lba48/simple/zero
==8512==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8512==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffdcf60a000; bottom 0x7fa0e3ffe000; size: 0x005ceb60c000 (399085977600)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 22 ahci-test /x86_64/ahci/io/pio/lba48/simple/low
==8518==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8518==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffd9f2eb000; bottom 0x7f156fdfe000; size: 0x00e82f4ed000 (997226106880)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 23 ahci-test /x86_64/ahci/io/pio/lba48/simple/high
==8524==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8524==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffcb84ce000; bottom 0x7f539a1fe000; size: 0x00a91e2d0000 (726355738624)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-qht /qht/mode/default
PASS 24 ahci-test /x86_64/ahci/io/pio/lba48/double/zero
PASS 2 test-qht /qht/mode/resize
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-qht-par -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-qht-par"
==8530==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8530==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fff42f2f000; bottom 0x7efcba5fe000; size: 0x010288931000 (1110392901632)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-qht-par /qht/parallel/2threads-0%updates-1s
PASS 25 ahci-test /x86_64/ahci/io/pio/lba48/double/low
==8549==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8549==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fff99be1000; bottom 0x7fd1297fe000; size: 0x002e703e3000 (199451619328)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 2 test-qht-par /qht/parallel/2threads-20%updates-1s
---
PASS 3 test-qdev-global-props /qdev/properties/dynamic/global
PASS 4 test-qdev-global-props /qdev/properties/global/subclass
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/check-qom-interface -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="check-qom-interface"
==8569==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 check-qom-interface /qom/interface/direct_impl
PASS 2 check-qom-interface /qom/interface/intermediate_impl
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/check-qom-proplist -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="check-qom-proplist"
==8569==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fff3c534000; bottom 0x7fb2625fe000; size: 0x004cd9f36000 (330074120192)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 check-qom-proplist /qom/proplist/createlist
---
PASS 4 test-crypto-hash /crypto/hash/digest
PASS 5 test-crypto-hash /crypto/hash/base64
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-crypto-hmac -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-crypto-hmac"
==8607==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-crypto-hmac /crypto/hmac/iov
PASS 2 test-crypto-hmac /crypto/hmac/alloc
PASS 3 test-crypto-hmac /crypto/hmac/prealloc
PASS 4 test-crypto-hmac /crypto/hmac/digest
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-crypto-cipher -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-crypto-cipher"
==8607==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fffaf4b3000; bottom 0x7fad2d1fe000; size: 0x0052822b5000 (354371194880)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-crypto-cipher /crypto/cipher/aes-ecb-128
---
PASS 28 ahci-test /x86_64/ahci/io/pio/lba48/long/low
PASS 1 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/perfectserver
PASS 2 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/perfectclient
==8637==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8637==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffc864f5000; bottom 0x7f101e97c000; size: 0x00ec67b79000 (1015352365056)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 3 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodca1
---
PASS 6 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/badca1
PASS 7 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/badca2
PASS 29 ahci-test /x86_64/ahci/io/pio/lba48/long/high
==8643==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 8 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/badca3
PASS 9 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver1
PASS 30 ahci-test /x86_64/ahci/io/pio/lba48/short/zero
==8649==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 10 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver2
PASS 11 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver3
PASS 12 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver4
PASS 31 ahci-test /x86_64/ahci/io/pio/lba48/short/low
PASS 13 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver5
==8656==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 14 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver6
PASS 15 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/goodserver7
PASS 16 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/badserver1
---
PASS 38 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/missingserver
PASS 39 test-crypto-tlscredsx509 /qcrypto/tlscredsx509/missingclient
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-crypto-tlssession -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-crypto-tlssession"
==8662==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-crypto-tlssession /qcrypto/tlssession/psk
PASS 2 test-crypto-tlssession /qcrypto/tlssession/basicca
PASS 3 test-crypto-tlssession /qcrypto/tlssession/differentca
PASS 33 ahci-test /x86_64/ahci/io/dma/lba28/fragmented
==8673==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 4 test-crypto-tlssession /qcrypto/tlssession/altname1
PASS 34 ahci-test /x86_64/ahci/io/dma/lba28/retry
==8679==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 5 test-crypto-tlssession /qcrypto/tlssession/altname2
PASS 6 test-crypto-tlssession /qcrypto/tlssession/altname3
PASS 35 ahci-test /x86_64/ahci/io/dma/lba28/simple/zero
==8685==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 7 test-crypto-tlssession /qcrypto/tlssession/altname4
PASS 8 test-crypto-tlssession /qcrypto/tlssession/altname5
PASS 9 test-crypto-tlssession /qcrypto/tlssession/altname6
---
PASS 12 test-crypto-tlssession /qcrypto/tlssession/wildcard3
PASS 36 ahci-test /x86_64/ahci/io/dma/lba28/simple/low
PASS 13 test-crypto-tlssession /qcrypto/tlssession/wildcard4
==8691==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 14 test-crypto-tlssession /qcrypto/tlssession/wildcard5
PASS 37 ahci-test /x86_64/ahci/io/dma/lba28/simple/high
PASS 15 test-crypto-tlssession /qcrypto/tlssession/wildcard6
==8697==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 16 test-crypto-tlssession /qcrypto/tlssession/cachain
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-qga -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-qga"
PASS 38 ahci-test /x86_64/ahci/io/dma/lba28/double/zero
==8707==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-qga /qga/sync-delimited
PASS 2 test-qga /qga/sync
PASS 3 test-qga /qga/ping
---
PASS 16 test-qga /qga/invalid-args
PASS 17 test-qga /qga/fsfreeze-status
PASS 39 ahci-test /x86_64/ahci/io/dma/lba28/double/low
==8716==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 18 test-qga /qga/blacklist
PASS 40 ahci-test /x86_64/ahci/io/dma/lba28/double/high
PASS 19 test-qga /qga/config
PASS 20 test-qga /qga/guest-exec
PASS 21 test-qga /qga/guest-exec-invalid
==8724==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 22 test-qga /qga/guest-get-osinfo
PASS 23 test-qga /qga/guest-get-host-name
PASS 24 test-qga /qga/guest-get-timezone
---
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-timed-average -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-timed-average"
PASS 1 test-timed-average /timed-average/average
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-util-filemonitor -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-util-filemonitor"
==8738==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-util-filemonitor /util/filemonitor
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-util-sockets -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-util-sockets"
PASS 1 test-util-sockets /util/socket/is-socket/bad
---
PASS 8 test-io-channel-socket /io/channel/socket/unix-fd-pass
PASS 9 test-io-channel-socket /io/channel/socket/unix-listen-cleanup
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-io-channel-file -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-io-channel-file"
==8778==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-io-channel-file /io/channel/file
PASS 2 test-io-channel-file /io/channel/file/rdwr
PASS 3 test-io-channel-file /io/channel/file/fd
---
PASS 3 test-base64 /util/base64/not-nul-terminated
PASS 4 test-base64 /util/base64/invalid-chars
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-crypto-pbkdf -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-crypto-pbkdf"
==8857==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-crypto-pbkdf /crypto/pbkdf/rfc3962/sha1/iter1
PASS 2 test-crypto-pbkdf /crypto/pbkdf/rfc3962/sha1/iter2
PASS 3 test-crypto-pbkdf /crypto/pbkdf/rfc3962/sha1/iter1200a
---
PASS 44 ahci-test /x86_64/ahci/io/dma/lba28/short/zero
PASS 1 test-crypto-block /crypto/block/qcow
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-logging -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-logging"
==8892==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-logging /logging/parse_range
PASS 2 test-logging /logging/parse_path
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-replication -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-replication"
==8902==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-replication /replication/primary/read
PASS 45 ahci-test /x86_64/ahci/io/dma/lba28/short/low
PASS 2 test-replication /replication/primary/write
---
PASS 4 test-replication /replication/primary/stop
PASS 5 test-replication /replication/primary/do_checkpoint
PASS 6 test-replication /replication/primary/get_error_all
==8907==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 46 ahci-test /x86_64/ahci/io/dma/lba28/short/high
PASS 7 test-replication /replication/secondary/read
PASS 8 test-replication /replication/secondary/write
==8913==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 47 ahci-test /x86_64/ahci/io/dma/lba48/simple/zero
==8919==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==8902==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7fff7bb64000; bottom 0x7ffbe91fc000; size: 0x000392968000 (15344238592)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 48 ahci-test /x86_64/ahci/io/dma/lba48/simple/low
PASS 9 test-replication /replication/secondary/start
==8945==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 49 ahci-test /x86_64/ahci/io/dma/lba48/simple/high
==8951==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 10 test-replication /replication/secondary/stop
PASS 50 ahci-test /x86_64/ahci/io/dma/lba48/double/zero
==8957==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 51 ahci-test /x86_64/ahci/io/dma/lba48/double/low
PASS 11 test-replication /replication/secondary/do_checkpoint
==8963==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 12 test-replication /replication/secondary/get_error_all
PASS 52 ahci-test /x86_64/ahci/io/dma/lba48/double/high
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-bufferiszero -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-bufferiszero"
==8970==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 53 ahci-test /x86_64/ahci/io/dma/lba48/long/zero
==8979==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 54 ahci-test /x86_64/ahci/io/dma/lba48/long/low
==8985==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 55 ahci-test /x86_64/ahci/io/dma/lba48/long/high
==8991==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 56 ahci-test /x86_64/ahci/io/dma/lba48/short/zero
==8997==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 57 ahci-test /x86_64/ahci/io/dma/lba48/short/low
==9003==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 58 ahci-test /x86_64/ahci/io/dma/lba48/short/high
==9009==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 59 ahci-test /x86_64/ahci/io/ncq/simple
==9015==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 60 ahci-test /x86_64/ahci/io/ncq/retry
==9021==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 61 ahci-test /x86_64/ahci/flush/simple
==9027==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 62 ahci-test /x86_64/ahci/flush/retry
==9033==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==9038==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 63 ahci-test /x86_64/ahci/flush/migrate
==9047==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==9052==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 64 ahci-test /x86_64/ahci/migrate/sanity
==9061==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==9066==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 65 ahci-test /x86_64/ahci/migrate/dma/simple
==9075==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==9080==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 1 test-bufferiszero /cutils/bufferiszero
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-uuid -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="test-uuid"
PASS 66 ahci-test /x86_64/ahci/migrate/dma/halted
---
PASS 504 ptimer-test /ptimer/run_with_delta_0 policy=wrap_after_one_period,no_immediate_reload,no_counter_rounddown,trigger_only_on_decrement,
PASS 505 ptimer-test /ptimer/periodic_with_load_0 policy=wrap_after_one_period,no_immediate_reload,no_counter_rounddown,trigger_only_on_decrement,
PASS 506 ptimer-test /ptimer/oneshot_with_load_0 policy=wrap_after_one_period,no_immediate_reload,no_counter_rounddown,trigger_only_on_decrement,
==9094==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 507 ptimer-test /ptimer/set_count policy=continuous_trigger,no_immediate_reload,no_counter_rounddown,trigger_only_on_decrement,
PASS 508 ptimer-test /ptimer/set_limit policy=continuous_trigger,no_immediate_reload,no_counter_rounddown,trigger_only_on_decrement,
PASS 509 ptimer-test /ptimer/oneshot policy=continuous_trigger,no_immediate_reload,no_counter_rounddown,trigger_only_on_decrement,
---
PASS 21 test-qgraph /qgraph/test_two_test_same_interface
PASS 22 test-qgraph /qgraph/test_test_in_path
PASS 23 test-qgraph /qgraph/test_double_edge
==9107==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 67 ahci-test /x86_64/ahci/migrate/ncq/simple
==9120==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==9125==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 68 ahci-test /x86_64/ahci/migrate/ncq/halted
==9134==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 69 ahci-test /x86_64/ahci/cdrom/eject
==9139==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 70 ahci-test /x86_64/ahci/cdrom/dma/single
==9145==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 71 ahci-test /x86_64/ahci/cdrom/dma/multi
==9151==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 72 ahci-test /x86_64/ahci/cdrom/pio/single
==9157==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
==9157==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top: 0x7ffc18abb000; bottom 0x7f06ff7fe000; size: 0x00f5192bd000 (1052689289216)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 73 ahci-test /x86_64/ahci/cdrom/pio/multi
==9163==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 74 ahci-test /x86_64/ahci/cdrom/pio/bcl
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/hd-geo-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="hd-geo-test"
PASS 1 hd-geo-test /x86_64/hd-geo/ide/none
==9177==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 2 hd-geo-test /x86_64/hd-geo/ide/drive/cd_0
==9183==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 3 hd-geo-test /x86_64/hd-geo/ide/drive/mbr/blank
==9189==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 4 hd-geo-test /x86_64/hd-geo/ide/drive/mbr/lba
==9195==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 5 hd-geo-test /x86_64/hd-geo/ide/drive/mbr/chs
==9201==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 6 hd-geo-test /x86_64/hd-geo/ide/device/mbr/blank
==9207==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 7 hd-geo-test /x86_64/hd-geo/ide/device/mbr/lba
==9213==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 8 hd-geo-test /x86_64/hd-geo/ide/device/mbr/chs
==9219==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 9 hd-geo-test /x86_64/hd-geo/ide/device/user/chs
==9224==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 10 hd-geo-test /x86_64/hd-geo/ide/device/user/chst
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/boot-order-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="boot-order-test"
PASS 1 boot-order-test /x86_64/boot-order/pc
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9292==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP'
Using expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9298==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP'
Using expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9304==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP.bridge'
Looking for expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9310==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP.ipmikcs'
Looking for expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9316==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP.cphp'
Looking for expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9323==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP.memhp'
Looking for expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9329==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP.numamem'
Looking for expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9335==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/pc/FACP.dimmpxm'
Looking for expected file 'tests/data/acpi/pc/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9344==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.bridge'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9350==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.mmio64'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9356==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.ipmibt'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9362==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.cphp'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9369==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.memhp'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9375==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.numamem'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
==9381==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
Looking for expected file 'tests/data/acpi/q35/FACP.dimmpxm'
Looking for expected file 'tests/data/acpi/q35/FACP'
---
PASS 4 pxe-test /x86_64/pxe/ipv4/q35/virtio-net-pci
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/rtc-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="rtc-test"
**
ERROR:/tmp/qemu-test/src/tests/rtc-test.c:173:check_time: assertion failed (ABS(t - s) <= wiggle): (4 <= 2)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/rtc-test.c:173:check_time: assertion failed (ABS(t - s) <= wiggle): (4 <= 2)
make: *** [/tmp/qemu-test/src/tests/Makefile.include:899: check-qtest-x86_64] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
The full log is available at
http://patchew.org/logs/20190723104754.29324-1-ppandit@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
` (3 preceding siblings ...)
2019-07-23 17:44 ` [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ no-reply
@ 2019-07-26 10:26 ` Jason Wang
4 siblings, 0 replies; 23+ messages in thread
From: Jason Wang @ 2019-07-26 10:26 UTC (permalink / raw)
To: P J P, QEMU Developers
Cc: Li Qiang, Daniel P . Berrangé, Prasad J Pandit
On 2019/7/23 下午6:47, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Hello,
>
> Linux net_deivce defines network interface name to be of IFNAMSIZE(=16)
> bytes, including the terminating null('\0') byte.
>
> Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the
> network bridge interface, supplies bridge name of 16 characters, thus
> allowing to create an ACL bypass scenario.
>
> This patch series attempts to fix it. It also updates bridge helper
> invocation routine 'net_bridge_run_helper' to avoid snprintf() calls.
>
> Thank you.
> --
> Prasad J Pandit (3):
> qemu-bridge-helper: restrict interface name to IFNAMSIZ
> qemu-bridge-helper: move repeating code in parse_acl_file
> net: tap: replace snprintf with g_strdup_printf calls
>
> net/tap.c | 19 +++++++++++--------
> qemu-bridge-helper.c | 24 +++++++++++++++++-------
> 2 files changed, 28 insertions(+), 15 deletions(-)
>
Applied.
Thanks
^ permalink raw reply [flat|nested] 23+ messages in thread