Fix files with checkpatch errors/warnings

Fix files with checkpatch errors/warnings

[Alejandro del Rio]

Hi all,

I'm completely new to linux kernel development and I would like to
make a very first contribution by "cleaning" some files. I noticed
that the script checkpatch.pl (inside scripts/ folder) report lots of
style errors on some drivers.
For example try running ./scripts/checkpatch.pl --file
drivers/video/*, you will notice that most of the files contain style
issues.

My questions are: Is people actively fixing this? Maybe they are not
very interested on fixing this typos... Otherwise, could I contribute
by submitting patches on this?
And finally, if I do so, to who should I show this fixes?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

Re: Fix files with checkpatch errors/warnings

[Anatoly Sivov]

Hello Alejandro,

> Is people actively fixing this? Maybe they are not
> very interested on fixing this typos... Otherwise, could I contribute
> by submitting patches on this?
> And finally, if I do so, to who should I show this fixes?

I found this mailing list deadly quiet, so advise you to ask your  
questions somewhere else.
I guess, linux-kernel mailing list is the most active one (just a guess)  
and there is the most probability to be heard.

BR, Anatoly
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

Re: Fix files with checkpatch errors/warnings

[Javier Martinez Canillas]

On Thu, Dec 22, 2011 at 1:49 AM, Alejandro del Rio <scasbyte@gmail.com> wrote:
> Hi all,
>
> I'm completely new to linux kernel development and I would like to
> make a very first contribution by "cleaning" some files. I noticed
> that the script checkpatch.pl (inside scripts/ folder) report lots of
> style errors on some drivers.
> For example try running ./scripts/checkpatch.pl --file
> drivers/video/*, you will notice that most of the files contain style
> issues.
>
> My questions are: Is people actively fixing this? Maybe they are not
> very interested on fixing this typos... Otherwise, could I contribute
> by submitting patches on this?

Hi Alejandro,

The best to figure out is sending the patches ;-)

> And finally, if I do so, to who should I show this fixes?
>

Once you have the patch. You can use ./scripts/get_maintainer.pl to
know who is expecting to receive your patch.

It is only a suggestion not something to follow strictly. Common sense
will tell you if you need to cc someone else or not.

Hope it helps,

-- 
Javier Martínez Canillas
(+34) 682 39 81 69
Barcelona, Spain
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

Re: Fix files with checkpatch errors/warnings

[Anatoly Sivov]

> The best to figure out is sending the patches ;-)

Here is some useful video with Greg Kroah-Hartman about submitting  
patches: http://www.youtube.com/watch?v=LLBrBBImJt4
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

Re: Fix files with checkpatch errors/warnings

[Cyril Roelandt]

On 12/22/2011 01:49 AM, Alejandro del Rio wrote:
> Hi all,
>
> I'm completely new to linux kernel development and I would like to
> make a very first contribution by "cleaning" some files. I noticed
> that the script checkpatch.pl (inside scripts/ folder) report lots of
> style errors on some drivers.
> For example try running ./scripts/checkpatch.pl --file
> drivers/video/*, you will notice that most of the files contain style
> issues.
>
> My questions are: Is people actively fixing this? Maybe they are not
> very interested on fixing this typos... Otherwise, could I contribute
> by submitting patches on this?
> And finally, if I do so, to who should I show this fixes?

Maybe you could help the Kernel Janitors :

http://kernelnewbies.org/KernelJanitors
http://vger.kernel.org/vger-lists.html#kernel-janitors

They "go through the linux kernel sources, doing code reviews, fixing up
unmaintained code and doing other cleanups and API conversion."

Cyril.
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs