* [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages
@ 2017-10-03 22:55 Sujaritha Sundaresan
2017-10-04 6:13 ` Sagar Arun Kamble
0 siblings, 1 reply; 5+ messages in thread
From: Sujaritha Sundaresan @ 2017-10-03 22:55 UTC (permalink / raw)
To: intel-gfx; +Cc: Sujaritha Sundaresan
Unifying the various seq_puts messages to the simplest one
v2: Clarifying the commit message (Anusha)
v3: Unify seq_puts messages, Re-factoring code as per review (Michal)
v4: Rebase
v5: Separated into a separate patch
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Oscar Mateo <oscar.mateo@intel.com>
Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 847f8e8..53e40dd 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1616,7 +1616,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
struct drm_i915_private *dev_priv = node_to_i915(m->private);
if (!HAS_FBC(dev_priv)) {
- seq_puts(m, "FBC unsupported on this chipset\n");
+ seq_puts(m, "not supported\n");
return 0;
}
@@ -1783,7 +1783,7 @@ static int i915_ring_freq_table(struct seq_file *m, void *unused)
unsigned int max_gpu_freq, min_gpu_freq;
if (!HAS_LLC(dev_priv)) {
- seq_puts(m, "unsupported on this chipset\n");
+ seq_puts(m, "not supported\n");
return 0;
}
@@ -2654,7 +2654,7 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
bool enabled = false;
if (!HAS_PSR(dev_priv)) {
- seq_puts(m, "PSR not supported\n");
+ seq_puts(m, "not supported\n");
return 0;
}
@@ -2807,7 +2807,7 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused)
struct pci_dev *pdev = dev_priv->drm.pdev;
if (!HAS_RUNTIME_PM(dev_priv))
- seq_puts(m, "Runtime power management not supported\n");
+ seq_puts(m, "not supported\n");
seq_printf(m, "GPU idle: %s\n", yesno(!dev_priv->gt.awake));
seq_printf(m, "IRQs disabled: %s\n",
@@ -3683,7 +3683,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
mutex_unlock(&drrs->mutex);
} else {
/* DRRS not supported. Print the VBT parameter*/
- seq_puts(m, "\tDRRS Supported : No");
+ seq_puts(m, "not supported\n");
}
seq_puts(m, "\n");
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages
2017-10-03 22:55 [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages Sujaritha Sundaresan
@ 2017-10-04 6:13 ` Sagar Arun Kamble
2017-10-04 11:39 ` Michal Wajdeczko
2017-10-04 17:23 ` Sujaritha
0 siblings, 2 replies; 5+ messages in thread
From: Sagar Arun Kamble @ 2017-10-04 6:13 UTC (permalink / raw)
To: Sujaritha Sundaresan, intel-gfx
On 10/4/2017 4:25 AM, Sujaritha Sundaresan wrote:
> Unifying the various seq_puts messages to the simplest one
>
> v2: Clarifying the commit message (Anusha)
>
> v3: Unify seq_puts messages, Re-factoring code as per review (Michal)
>
> v4: Rebase
>
> v5: Separated into a separate patch
>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 847f8e8..53e40dd 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1616,7 +1616,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
> struct drm_i915_private *dev_priv = node_to_i915(m->private);
>
> if (!HAS_FBC(dev_priv)) {
> - seq_puts(m, "FBC unsupported on this chipset\n");
> + seq_puts(m, "not supported\n");
> return 0;
> }
>
> @@ -1783,7 +1783,7 @@ static int i915_ring_freq_table(struct seq_file *m, void *unused)
> unsigned int max_gpu_freq, min_gpu_freq;
>
> if (!HAS_LLC(dev_priv)) {
> - seq_puts(m, "unsupported on this chipset\n");
> + seq_puts(m, "not supported\n");
> return 0;
> }
>
> @@ -2654,7 +2654,7 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
> bool enabled = false;
>
> if (!HAS_PSR(dev_priv)) {
> - seq_puts(m, "PSR not supported\n");
> + seq_puts(m, "not supported\n");
> return 0;
> }
>
> @@ -2807,7 +2807,7 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused)
> struct pci_dev *pdev = dev_priv->drm.pdev;
>
> if (!HAS_RUNTIME_PM(dev_priv))
> - seq_puts(m, "Runtime power management not supported\n");
> + seq_puts(m, "not supported\n");
>
> seq_printf(m, "GPU idle: %s\n", yesno(!dev_priv->gt.awake));
> seq_printf(m, "IRQs disabled: %s\n",
> @@ -3683,7 +3683,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
> mutex_unlock(&drrs->mutex);
> } else {
> /* DRRS not supported. Print the VBT parameter*/
> - seq_puts(m, "\tDRRS Supported : No");
> + seq_puts(m, "not supported\n");
There is corresponding "Yes" seq_puts above. Please update that as well.
Commit subject looks little ambiguous. can we say unify seq_puts
messages for feature support.
> }
> seq_puts(m, "\n");
> }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages
2017-10-04 6:13 ` Sagar Arun Kamble
@ 2017-10-04 11:39 ` Michal Wajdeczko
2017-10-04 17:29 ` Sujaritha
2017-10-04 17:23 ` Sujaritha
1 sibling, 1 reply; 5+ messages in thread
From: Michal Wajdeczko @ 2017-10-04 11:39 UTC (permalink / raw)
To: Sujaritha Sundaresan, intel-gfx, Sagar Arun Kamble
On Wed, 04 Oct 2017 08:13:12 +0200, Sagar Arun Kamble
<sagar.a.kamble@intel.com> wrote:
>
>
> On 10/4/2017 4:25 AM, Sujaritha Sundaresan wrote:
>> Unifying the various seq_puts messages to the simplest one
>>
>> v2: Clarifying the commit message (Anusha)
>>
>> v3: Unify seq_puts messages, Re-factoring code as per review (Michal)
>>
>> v4: Rebase
>>
>> v5: Separated into a separate patch
>>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Oscar Mateo <oscar.mateo@intel.com>
>> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
>> b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 847f8e8..53e40dd 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -1616,7 +1616,7 @@ static int i915_fbc_status(struct seq_file *m,
>> void *unused)
>> struct drm_i915_private *dev_priv = node_to_i915(m->private);
>> if (!HAS_FBC(dev_priv)) {
>> - seq_puts(m, "FBC unsupported on this chipset\n");
>> + seq_puts(m, "not supported\n");
>> return 0;
>> }
>> @@ -1783,7 +1783,7 @@ static int i915_ring_freq_table(struct seq_file
>> *m, void *unused)
>> unsigned int max_gpu_freq, min_gpu_freq;
>> if (!HAS_LLC(dev_priv)) {
>> - seq_puts(m, "unsupported on this chipset\n");
>> + seq_puts(m, "not supported\n");
>> return 0;
>> }
>> @@ -2654,7 +2654,7 @@ static int i915_edp_psr_status(struct seq_file
>> *m, void *data)
>> bool enabled = false;
>> if (!HAS_PSR(dev_priv)) {
>> - seq_puts(m, "PSR not supported\n");
>> + seq_puts(m, "not supported\n");
>> return 0;
>> }
>> @@ -2807,7 +2807,7 @@ static int i915_runtime_pm_status(struct
>> seq_file *m, void *unused)
>> struct pci_dev *pdev = dev_priv->drm.pdev;
>> if (!HAS_RUNTIME_PM(dev_priv))
>> - seq_puts(m, "Runtime power management not supported\n");
>> + seq_puts(m, "not supported\n");
This one also does not fit into unified "early return" pattern.
>> seq_printf(m, "GPU idle: %s\n", yesno(!dev_priv->gt.awake));
>> seq_printf(m, "IRQs disabled: %s\n",
>> @@ -3683,7 +3683,7 @@ static void drrs_status_per_crtc(struct seq_file
>> *m,
>> mutex_unlock(&drrs->mutex);
>> } else {
>> /* DRRS not supported. Print the VBT parameter*/
>> - seq_puts(m, "\tDRRS Supported : No");
>> + seq_puts(m, "not supported\n");
> There is corresponding "Yes" seq_puts above. Please update that as well.
> Commit subject looks little ambiguous. can we say unify seq_puts
> messages for feature support.
>> }
>> seq_puts(m, "\n");
>> }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages
2017-10-04 6:13 ` Sagar Arun Kamble
2017-10-04 11:39 ` Michal Wajdeczko
@ 2017-10-04 17:23 ` Sujaritha
1 sibling, 0 replies; 5+ messages in thread
From: Sujaritha @ 2017-10-04 17:23 UTC (permalink / raw)
To: Sagar Arun Kamble, intel-gfx
On 10/03/2017 11:13 PM, Sagar Arun Kamble wrote:
>
>
> On 10/4/2017 4:25 AM, Sujaritha Sundaresan wrote:
>> Unifying the various seq_puts messages to the simplest one
>>
>> v2: Clarifying the commit message (Anusha)
>>
>> v3: Unify seq_puts messages, Re-factoring code as per review (Michal)
>>
>> v4: Rebase
>>
>> v5: Separated into a separate patch
>>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Oscar Mateo <oscar.mateo@intel.com>
>> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
>> b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 847f8e8..53e40dd 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -1616,7 +1616,7 @@ static int i915_fbc_status(struct seq_file *m,
>> void *unused)
>> struct drm_i915_private *dev_priv = node_to_i915(m->private);
>> if (!HAS_FBC(dev_priv)) {
>> - seq_puts(m, "FBC unsupported on this chipset\n");
>> + seq_puts(m, "not supported\n");
>> return 0;
>> }
>> @@ -1783,7 +1783,7 @@ static int i915_ring_freq_table(struct
>> seq_file *m, void *unused)
>> unsigned int max_gpu_freq, min_gpu_freq;
>> if (!HAS_LLC(dev_priv)) {
>> - seq_puts(m, "unsupported on this chipset\n");
>> + seq_puts(m, "not supported\n");
>> return 0;
>> }
>> @@ -2654,7 +2654,7 @@ static int i915_edp_psr_status(struct
>> seq_file *m, void *data)
>> bool enabled = false;
>> if (!HAS_PSR(dev_priv)) {
>> - seq_puts(m, "PSR not supported\n");
>> + seq_puts(m, "not supported\n");
>> return 0;
>> }
>> @@ -2807,7 +2807,7 @@ static int i915_runtime_pm_status(struct
>> seq_file *m, void *unused)
>> struct pci_dev *pdev = dev_priv->drm.pdev;
>> if (!HAS_RUNTIME_PM(dev_priv))
>> - seq_puts(m, "Runtime power management not supported\n");
>> + seq_puts(m, "not supported\n");
>> seq_printf(m, "GPU idle: %s\n", yesno(!dev_priv->gt.awake));
>> seq_printf(m, "IRQs disabled: %s\n",
>> @@ -3683,7 +3683,7 @@ static void drrs_status_per_crtc(struct
>> seq_file *m,
>> mutex_unlock(&drrs->mutex);
>> } else {
>> /* DRRS not supported. Print the VBT parameter*/
>> - seq_puts(m, "\tDRRS Supported : No");
>> + seq_puts(m, "not supported\n");
> There is corresponding "Yes" seq_puts above. Please update that as well.
Will do.
> Commit subject looks little ambiguous. can we say unify seq_puts
> messages for feature support.
Yes, I will clarify the commit message.
>> }
>> seq_puts(m, "\n");
>> }
>
Thanks for the review,
Regards,
Sujaritha
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages
2017-10-04 11:39 ` Michal Wajdeczko
@ 2017-10-04 17:29 ` Sujaritha
0 siblings, 0 replies; 5+ messages in thread
From: Sujaritha @ 2017-10-04 17:29 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx, Sagar Arun Kamble
On 10/04/2017 04:39 AM, Michal Wajdeczko wrote:
> On Wed, 04 Oct 2017 08:13:12 +0200, Sagar Arun Kamble
> <sagar.a.kamble@intel.com> wrote:
>
>>
>>
>> On 10/4/2017 4:25 AM, Sujaritha Sundaresan wrote:
>>> Unifying the various seq_puts messages to the simplest one
>>>
>>> v2: Clarifying the commit message (Anusha)
>>>
>>> v3: Unify seq_puts messages, Re-factoring code as per review (Michal)
>>>
>>> v4: Rebase
>>>
>>> v5: Separated into a separate patch
>>>
>>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>> Cc: Oscar Mateo <oscar.mateo@intel.com>
>>> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
>>> b/drivers/gpu/drm/i915/i915_debugfs.c
>>> index 847f8e8..53e40dd 100644
>>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>>> @@ -1616,7 +1616,7 @@ static int i915_fbc_status(struct seq_file *m,
>>> void *unused)
>>> struct drm_i915_private *dev_priv = node_to_i915(m->private);
>>> if (!HAS_FBC(dev_priv)) {
>>> - seq_puts(m, "FBC unsupported on this chipset\n");
>>> + seq_puts(m, "not supported\n");
>>> return 0;
>>> }
>>> @@ -1783,7 +1783,7 @@ static int i915_ring_freq_table(struct
>>> seq_file *m, void *unused)
>>> unsigned int max_gpu_freq, min_gpu_freq;
>>> if (!HAS_LLC(dev_priv)) {
>>> - seq_puts(m, "unsupported on this chipset\n");
>>> + seq_puts(m, "not supported\n");
>>> return 0;
>>> }
>>> @@ -2654,7 +2654,7 @@ static int i915_edp_psr_status(struct
>>> seq_file *m, void *data)
>>> bool enabled = false;
>>> if (!HAS_PSR(dev_priv)) {
>>> - seq_puts(m, "PSR not supported\n");
>>> + seq_puts(m, "not supported\n");
>>> return 0;
>>> }
>>> @@ -2807,7 +2807,7 @@ static int i915_runtime_pm_status(struct
>>> seq_file *m, void *unused)
>>> struct pci_dev *pdev = dev_priv->drm.pdev;
>>> if (!HAS_RUNTIME_PM(dev_priv))
>>> - seq_puts(m, "Runtime power management not supported\n");
>>> + seq_puts(m, "not supported\n");
>
> This one also does not fit into unified "early return" pattern.
Will revert this one.
>
>>> seq_printf(m, "GPU idle: %s\n", yesno(!dev_priv->gt.awake));
>>> seq_printf(m, "IRQs disabled: %s\n",
>>> @@ -3683,7 +3683,7 @@ static void drrs_status_per_crtc(struct
>>> seq_file *m,
>>> mutex_unlock(&drrs->mutex);
>>> } else {
>>> /* DRRS not supported. Print the VBT parameter*/
>>> - seq_puts(m, "\tDRRS Supported : No");
>>> + seq_puts(m, "not supported\n");
>> There is corresponding "Yes" seq_puts above. Please update that as well.
>> Commit subject looks little ambiguous. can we say unify seq_puts
>> messages for feature support.
>>> }
>>> seq_puts(m, "\n");
>>> }
Thanks for the review.
Regards,
Sujaritha
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-04 17:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 22:55 [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages Sujaritha Sundaresan
2017-10-04 6:13 ` Sagar Arun Kamble
2017-10-04 11:39 ` Michal Wajdeczko
2017-10-04 17:29 ` Sujaritha
2017-10-04 17:23 ` Sujaritha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.