* [PATCH] drm/i915/guc: Print CTL params passed to Guc
@ 2018-06-15 14:10 Michal Wajdeczko
2018-06-15 14:33 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Michal Wajdeczko @ 2018-06-15 14:10 UTC (permalink / raw)
To: intel-gfx
While debugging we may want to examine params passed to GuC.
Print them all if config I915_DEBUG_GUC is enabled.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
---
drivers/gpu/drm/i915/intel_guc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
index 1aff30b..f84fbde 100644
--- a/drivers/gpu/drm/i915/intel_guc.c
+++ b/drivers/gpu/drm/i915/intel_guc.c
@@ -327,6 +327,11 @@ void intel_guc_init_params(struct intel_guc *guc)
params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
+#ifdef CONFIG_DRM_I915_DEBUG_GUC
+ for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
+ DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
+#endif
+
/*
* All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and
* they are power context saved so it's ok to release forcewake
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/guc: Print CTL params passed to Guc
2018-06-15 14:10 [PATCH] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
@ 2018-06-15 14:33 ` Patchwork
2018-06-15 17:41 ` [PATCH] " Michel Thierry
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-06-15 14:33 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Print CTL params passed to Guc
URL : https://patchwork.freedesktop.org/series/44834/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4325 -> Patchwork_9327 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44834/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9327 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-skl-6700k2: PASS -> DMESG-WARN (fdo#106697, fdo#104238)
igt@drv_module_reload@basic-reload-inject:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106248, fdo#106725, fdo#106000)
igt@gem_exec_gttfill@basic:
fi-byt-n2820: PASS -> FAIL (fdo#106744)
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: PASS -> FAIL (fdo#100368)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
==== Possible fixes ====
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS +2
igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
fi-glk-j4005: DMESG-WARN (fdo#106097, fdo#106000) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#104238 https://bugs.freedesktop.org/show_bug.cgi?id=104238
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106697 https://bugs.freedesktop.org/show_bug.cgi?id=106697
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
== Participating hosts (43 -> 38) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4325 -> Patchwork_9327
CI_DRM_4325: 4275ebe85ad179007c49b7bcf78d340b7681871e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4520: 91f5d4665b07f073c78abd3cd4b8e0e347dbf638 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9327: fd446e2e7ecc404cb033f64bc40ab0aa06106cd7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fd446e2e7ecc drm/i915/guc: Print CTL params passed to Guc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9327/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/guc: Print CTL params passed to Guc
2018-06-15 14:10 [PATCH] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
2018-06-15 14:33 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-06-15 17:41 ` Michel Thierry
2018-06-15 23:30 ` ✗ Fi.CI.IGT: failure for " Patchwork
2018-06-18 10:50 ` [PATCH] " Michał Winiarski
3 siblings, 0 replies; 6+ messages in thread
From: Michel Thierry @ 2018-06-15 17:41 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx
On 06/15/2018 07:10 AM, Michal Wajdeczko wrote:
> While debugging we may want to examine params passed to GuC.
> Print them all if config I915_DEBUG_GUC is enabled.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/intel_guc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> index 1aff30b..f84fbde 100644
> --- a/drivers/gpu/drm/i915/intel_guc.c
> +++ b/drivers/gpu/drm/i915/intel_guc.c
> @@ -327,6 +327,11 @@ void intel_guc_init_params(struct intel_guc *guc)
> params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
> params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
>
> +#ifdef CONFIG_DRM_I915_DEBUG_GUC
> + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
> + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
> +#endif
> +
> /*
> * All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and
> * they are power context saved so it's ok to release forcewake
>
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/guc: Print CTL params passed to Guc
2018-06-15 14:10 [PATCH] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
2018-06-15 14:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-15 17:41 ` [PATCH] " Michel Thierry
@ 2018-06-15 23:30 ` Patchwork
2018-06-18 10:42 ` Michal Wajdeczko
2018-06-18 10:50 ` [PATCH] " Michał Winiarski
3 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-06-15 23:30 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Print CTL params passed to Guc
URL : https://patchwork.freedesktop.org/series/44834/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4325_full -> Patchwork_9327_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9327_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9327_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9327_full:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_hangcheck:
shard-kbl: PASS -> DMESG-FAIL
==== Warnings ====
igt@drv_selftest@live_execlists:
shard-apl: SKIP -> PASS +1
igt@gem_exec_schedule@deep-render:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9327_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@gem_exec_big:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105189)
igt@kms_flip@2x-plain-flip-ts-check-interruptible:
shard-hsw: PASS -> FAIL (fdo#103928)
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-apl: DMESG-FAIL -> PASS
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-glk: FAIL (fdo#105703) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
==== Warnings ====
igt@drv_selftest@live_gtt:
shard-glk: FAIL (fdo#105347) -> INCOMPLETE (fdo#103359, k.org#198133)
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4325 -> Patchwork_9327
CI_DRM_4325: 4275ebe85ad179007c49b7bcf78d340b7681871e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4520: 91f5d4665b07f073c78abd3cd4b8e0e347dbf638 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9327: fd446e2e7ecc404cb033f64bc40ab0aa06106cd7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9327/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for drm/i915/guc: Print CTL params passed to Guc
2018-06-15 23:30 ` ✗ Fi.CI.IGT: failure for " Patchwork
@ 2018-06-18 10:42 ` Michal Wajdeczko
0 siblings, 0 replies; 6+ messages in thread
From: Michal Wajdeczko @ 2018-06-18 10:42 UTC (permalink / raw)
To: Patchwork, intel-gfx
On Sat, 16 Jun 2018 01:30:09 +0200, Patchwork
<patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/guc: Print CTL params passed to Guc
> URL : https://patchwork.freedesktop.org/series/44834/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4325_full -> Patchwork_9327_full =
>
> == Summary - FAILURE ==
>
> Serious unknown changes coming with Patchwork_9327_full absolutely
> need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_9327_full, please notify your bug team to
> allow them
> to document this new failure mode, which will reduce false positives
> in CI.
>
>
> == Possible new issues ==
>
> Here are the unknown changes that may have been introduced in
> Patchwork_9327_full:
>
> === IGT changes ===
>
> ==== Possible regressions ====
>
> igt@drv_selftest@live_hangcheck:
> shard-kbl: PASS -> DMESG-FAIL
>
> ==== Warnings ====
>
> igt@drv_selftest@live_execlists:
> shard-apl: SKIP -> PASS +1
>
> igt@gem_exec_schedule@deep-render:
> shard-kbl: SKIP -> PASS
it must be unrelated, as due to below config this change was nop ;)
# CONFIG_DRM_I915_DEBUG_GUC is not set
>
> == Known issues ==
>
> Here are the changes found in Patchwork_9327_full that come from known
> issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@drv_suspend@shrink:
> shard-snb: PASS -> INCOMPLETE (fdo#105411)
>
> igt@gem_exec_big:
> shard-hsw: PASS -> INCOMPLETE (fdo#103540)
>
> igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> shard-glk: PASS -> FAIL (fdo#105189)
>
> igt@kms_flip@2x-plain-flip-ts-check-interruptible:
> shard-hsw: PASS -> FAIL (fdo#103928)
>
> igt@kms_flip_tiling@flip-y-tiled:
> shard-glk: PASS -> FAIL (fdo#104724)
>
> igt@kms_setmode@basic:
> shard-apl: PASS -> FAIL (fdo#99912)
>
> ==== Possible fixes ====
>
> igt@drv_selftest@live_hangcheck:
> shard-apl: DMESG-FAIL -> PASS
>
> igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> shard-glk: FAIL (fdo#105703) -> PASS
>
> igt@kms_flip@flip-vs-expired-vblank-interruptible:
> shard-glk: FAIL (fdo#105363) -> PASS
>
> igt@kms_setmode@basic:
> shard-kbl: FAIL (fdo#99912) -> PASS
>
> ==== Warnings ====
>
> igt@drv_selftest@live_gtt:
> shard-glk: FAIL (fdo#105347) -> INCOMPLETE (fdo#103359,
> k.org#198133)
>
> fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
> fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
> fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
> fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
> fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
> fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
> fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
> fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
> fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
> fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
> k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> == Participating hosts (5 -> 5) ==
>
> No changes in participating hosts
>
>
> == Build changes ==
>
> * Linux: CI_DRM_4325 -> Patchwork_9327
>
> CI_DRM_4325: 4275ebe85ad179007c49b7bcf78d340b7681871e @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4520: 91f5d4665b07f073c78abd3cd4b8e0e347dbf638 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_9327: fd446e2e7ecc404cb033f64bc40ab0aa06106cd7 @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9327/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/guc: Print CTL params passed to Guc
2018-06-15 14:10 [PATCH] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
` (2 preceding siblings ...)
2018-06-15 23:30 ` ✗ Fi.CI.IGT: failure for " Patchwork
@ 2018-06-18 10:50 ` Michał Winiarski
3 siblings, 0 replies; 6+ messages in thread
From: Michał Winiarski @ 2018-06-18 10:50 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
On Fri, Jun 15, 2018 at 02:10:56PM +0000, Michal Wajdeczko wrote:
> While debugging we may want to examine params passed to GuC.
> Print them all if config I915_DEBUG_GUC is enabled.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/intel_guc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> index 1aff30b..f84fbde 100644
> --- a/drivers/gpu/drm/i915/intel_guc.c
> +++ b/drivers/gpu/drm/i915/intel_guc.c
> @@ -327,6 +327,11 @@ void intel_guc_init_params(struct intel_guc *guc)
> params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
> params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
>
> +#ifdef CONFIG_DRM_I915_DEBUG_GUC
> + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
> + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
> +#endif
> +
It's not even called if we're not using GuC, please drop the ifdef.
We don't want to sprinkle #ifdefs for GuC debug all over the place, and if we do
care about differentiation between GuC related stuff, we should probably create
a separate printer (like for GuC CT).
-Michał
> /*
> * All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and
> * they are power context saved so it's ok to release forcewake
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-18 10:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 14:10 [PATCH] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
2018-06-15 14:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-15 17:41 ` [PATCH] " Michel Thierry
2018-06-15 23:30 ` ✗ Fi.CI.IGT: failure for " Patchwork
2018-06-18 10:42 ` Michal Wajdeczko
2018-06-18 10:50 ` [PATCH] " Michał Winiarski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.