[U-Boot] bootefi regression from v2017.9: GRUB fails to see partitions on NXP LS1043A

[U-Boot] bootefi regression from v2017.9: GRUB fails to see partitions on NXP LS1043A

[Mathew McBride]

Hi all,

We are testing EFI support on u-boot for our (Traverse) NXP LS1043 
boards, as being able to only maintain one bootloader codebase (u-boot) 
is very appealing to us.

So far it has worked well, but I have had trouble getting it to work 
under v2017.11-rc*. It works fine on v2017.09.

I've traced the issue to this commit:
95c5553ea268144056c4bafc318b9e8b5c096a6c efi_loader: refactor boot 
device and loaded_image handling

After this commit, GRUB is unable to see the partitions of any attached 
devices, yet alone its own memdisk.
(This is a grub binary which I've built with modules in the memdisk, in 
theory it can function without a storage device)

Before:

Device 0: Vendor: TOSHIBA Rev: 1.00 Prod: TransMemory
             Type: Removable Hard Disk
             Capacity: 7391.2 MB = 7.2 GB (15137280 x 512)
... is now current device
Scanning usb 0:1...
reading /dtb/fsl-ls1043a-rdb.dtb
23140 bytes read in 43 ms (525.4 KiB/s)
Found EFI removable media binary efi/boot/bootaa64.efi
reading efi/boot/bootaa64.efi
238592 bytes read in 153 ms (1.5 MiB/s)
## Starting EFI application at 81000000 ...
Scanning disks on scsi...
Scanning disks on usb...
Scanning disks on mmc...
Card did not respond to voltage select!
mmc_init: -95, time 46
MMC Device 1 not found
MMC Device 2 not found
MMC Device 3 not found
Found 8 disks
Welcome to GRUB!

error: file `/boot/grub/arm64-efi/normal.mod' not found.
Entering rescue mode...
grub rescue> insmod fat
grub rescue> ls
(memdisk) (hd0) (hd0,gpt2) (hd0,gpt1)
grub rescue> ls (memdisk)/
boot/
grub rescue> ls (hd0,gpt1)/
grub/ vmlinuz-4.14.0-rc5-00018-g52569513daea 
System.map-4.14.0-rc5-00018-g52569513daea 
config-4.14.0-rc5-00018-g52569513daea efi/ dtb/


After:

reading efi/boot/bootaa64.efi
238592 bytes read in 153 ms (1.5 MiB/s)
## Starting EFI application at 81000000 ...
Scanning disks on scsi...
Scanning disks on usb...
Scanning disks on mmc...
Card did not respond to voltage select!
mmc_init: -95, time 46
MMC Device 1 not found
MMC Device 2 not found
MMC Device 3 not found
Found 8 disks
Welcome to GRUB!

error: variable `root' isn't set.
Entering rescue mode...
grub rescue> ls
(hd0)

The tests above are on a LS1043ARDB (reference board), loading u-boot 
from NAND and booting GRUB from a USB drive.


I am not a EFI expert at all, but is there anything I can do to help 
debug/fix this?



Regards,
Matt